blob: c89c61376bd7be4af56ea31b37a8426a346975f4 [file] [log] [blame]
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +00001#!/usr/bin/env python3
Maxim Kuvyrkov59877482021-07-07 11:22:26 +00002
3# Script to compare testsuite failures against a list of known-to-fail
4# tests.
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +00005
Maxim Kuvyrkov59877482021-07-07 11:22:26 +00006# Contributed by Diego Novillo <dnovillo@google.com>
7#
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +00008# Copyright (C) 2011-2023 Free Software Foundation, Inc.
Maxim Kuvyrkov59877482021-07-07 11:22:26 +00009#
10# This file is part of GCC.
11#
12# GCC is free software; you can redistribute it and/or modify
13# it under the terms of the GNU General Public License as published by
14# the Free Software Foundation; either version 3, or (at your option)
15# any later version.
16#
17# GCC is distributed in the hope that it will be useful,
18# but WITHOUT ANY WARRANTY; without even the implied warranty of
19# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
20# GNU General Public License for more details.
21#
22# You should have received a copy of the GNU General Public License
23# along with GCC; see the file COPYING. If not, write to
24# the Free Software Foundation, 51 Franklin Street, Fifth Floor,
25# Boston, MA 02110-1301, USA.
26
27"""This script provides a coarser XFAILing mechanism that requires no
28detailed DejaGNU markings. This is useful in a variety of scenarios:
29
30- Development branches with many known failures waiting to be fixed.
31- Release branches with known failures that are not considered
32 important for the particular release criteria used in that branch.
33
34The script must be executed from the toplevel build directory. When
35executed it will:
36
371- Determine the target built: TARGET
382- Determine the source directory: SRCDIR
393- Look for a failure manifest file in
40 <SRCDIR>/<MANIFEST_SUBDIR>/<MANIFEST_NAME>.xfail
414- Collect all the <tool>.sum files from the build tree.
425- Produce a report stating:
43 a- Failures expected in the manifest but not present in the build.
44 b- Failures in the build not expected in the manifest.
456- If all the build failures are expected in the manifest, it exits
46 with exit code 0. Otherwise, it exits with error code 1.
47
48Manifest files contain expected DejaGNU results that are otherwise
49treated as failures.
50They may also contain additional text:
51
52# This is a comment. - self explanatory
53@include file - the file is a path relative to the includer
54@remove result text - result text is removed from the expected set
55"""
56
57import datetime
58import optparse
59import os
60import re
61import sys
Maxim Kuvyrkova0d90542024-07-23 11:37:04 +000062import json
Maxim Kuvyrkov59877482021-07-07 11:22:26 +000063
Maxim Kuvyrkova0d90542024-07-23 11:37:04 +000064# Results that we want keep an eye on.
65# Note, 'NOEXE' state is used by llvm-test-suite.
66_INTERESTING_RESULTS = [ 'FAIL', 'UNRESOLVED', 'XPASS', 'ERROR', 'NOEXE' ]
Maxim Kuvyrkov8704bc12023-05-03 15:03:34 +000067# <STATE>: <NAME> <DESCRIPTION"
Maxim Kuvyrkov966fac42024-04-01 11:47:27 +000068_INTERESTING_RESULTS_REX = re.compile('(%s):\s*(\S+)\s*(.*)'
69 % "|".join(_INTERESTING_RESULTS))
Maxim Kuvyrkov8704bc12023-05-03 15:03:34 +000070
Maxim Kuvyrkov88799c62024-04-01 12:33:09 +000071_VALID_RESULTS_REX = re.compile('([A-Z]+):\s*(\S+)\s*(.*)')
72
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +000073# Formats of .sum file sections
74_TOOL_LINE_FORMAT = '\t\t=== %s tests ===\n'
Christophe Lyona7d8c4c2023-04-14 12:01:23 +000075_EXP_LINE_FORMAT = '\nRunning %s:%s ...\n'
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +000076_SUMMARY_LINE_FORMAT = '\n\t\t=== %s Summary ===\n'
77
78# ... and their compiled regexs.
79_TOOL_LINE_REX = re.compile('^\t\t=== (.*) tests ===\n')
Christophe Lyona7d8c4c2023-04-14 12:01:23 +000080# Match .exp file name, optionally prefixed by a "tool:" name and a
81# path ending with "testsuite/"
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +000082_EXP_LINE_REX = re.compile('^Running (?:.*:)?(.*) \.\.\.\n')
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +000083_SUMMARY_LINE_REX = re.compile('^\t\t=== (.*) Summary ===\n')
84
Maxim Kuvyrkov59877482021-07-07 11:22:26 +000085# Subdirectory of srcdir in which to find the manifest file.
86_MANIFEST_SUBDIR = 'contrib/testsuite-management'
87
88# Pattern for naming manifest files.
89# The first argument should be the toplevel GCC(/GNU tool) source directory.
90# The second argument is the manifest subdir.
91# The third argument is the manifest target, which defaults to the target
92# triplet used during the build.
93_MANIFEST_PATH_PATTERN = '%s/%s/%s.xfail'
94
95# The options passed to the program.
96_OPTIONS = None
97
98def Error(msg):
Maxim Kuvyrkov63ad5352021-07-04 07:38:22 +000099 print('error: %s' % msg, file=sys.stderr)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000100 sys.exit(1)
101
102
103class TestResult(object):
104 """Describes a single DejaGNU test result as emitted in .sum files.
105
106 We are only interested in representing unsuccessful tests. So, only
107 a subset of all the tests are loaded.
108
109 The summary line used to build the test result should have this format:
110
111 attrlist | XPASS: gcc.dg/unroll_1.c (test for excess errors)
112 ^^^^^^^^ ^^^^^ ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^
113 optional state name description
114 attributes
115
116 Attributes:
117 attrlist: A comma separated list of attributes.
118 Valid values:
119 flaky Indicates that this test may not always fail. These
120 tests are reported, but their presence does not affect
121 the results.
122
123 expire=YYYYMMDD After this date, this test will produce an error
124 whether it is in the manifest or not.
125
126 state: One of UNRESOLVED, XPASS or FAIL.
127 name: File name for the test.
128 description: String describing the test (flags used, dejagnu message, etc)
129 ordinal: Monotonically increasing integer.
130 It is used to keep results for one .exp file sorted
131 by the order the tests were run.
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000132 tool: Top-level testsuite name (aka "tool" in DejaGnu parlance) of the test.
133 exp: Name of .exp testsuite file.
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000134 """
135
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000136 def __init__(self, summary_line, ordinal, tool, exp):
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000137 try:
138 (self.attrs, summary_line) = SplitAttributesFromSummaryLine(summary_line)
139 try:
140 (self.state,
141 self.name,
Maxim Kuvyrkov966fac42024-04-01 11:47:27 +0000142 self.description) = _INTERESTING_RESULTS_REX.match(summary_line).groups()
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000143 if _OPTIONS.srcpath_regex and _OPTIONS.srcpath_regex != '':
144 self.description = re.sub(_OPTIONS.srcpath_regex, '',
145 self.description)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000146 except:
Thiago Jung Bauermann7b82a592023-04-22 14:12:06 +0000147 print('Failed to parse summary line: "%s"' % summary_line,
148 file=sys.stderr)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000149 raise
150 self.ordinal = ordinal
Maxim Kuvyrkovf09ab0e2021-08-30 14:19:04 +0000151 if tool == None or exp == None:
152 # .sum file seem to be broken. There was no "tool" and/or "exp"
153 # lines preceding this result.
Thiago Jung Bauermann7b82a592023-04-22 14:12:06 +0000154 print(f'.sum file seems to be broken: tool="{tool}", exp="{exp}", summary_line="{summary_line}"',
155 file=sys.stderr)
Maxim Kuvyrkovf09ab0e2021-08-30 14:19:04 +0000156 raise
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000157 self.tool = tool
158 self.exp = exp
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000159 except ValueError:
160 Error('Cannot parse summary line "%s"' % summary_line)
161
Maxim Kuvyrkov966fac42024-04-01 11:47:27 +0000162 if self.state not in _INTERESTING_RESULTS:
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000163 Error('Invalid test result %s in "%s" (parsed as "%s")' % (
164 self.state, summary_line, self))
165
166 def __lt__(self, other):
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000167 if (self.tool != other.tool):
168 return self.tool < other.tool
169 if (self.exp != other.exp):
170 return self.exp < other.exp
171 if (self.name != other.name):
172 return self.name < other.name
173 return self.ordinal < other.ordinal
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000174
175 def __hash__(self):
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000176 return (hash(self.state) ^ hash(self.tool) ^ hash(self.exp)
177 ^ hash(self.name) ^ hash(self.description))
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000178
Maxim Kuvyrkov7df81782023-05-25 06:42:06 +0000179 # Note that we don't include "attrs" in this comparison. This means that
180 # result entries "FAIL: test" and "flaky | FAIL: test" are considered
181 # the same. Therefore the ResultSet will preserve only the first occurence.
182 # In practice this means that flaky entries should preceed expected fails
183 # entries.
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000184 def __eq__(self, other):
185 return (self.state == other.state and
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000186 self.tool == other.tool and
187 self.exp == other.exp and
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000188 self.name == other.name and
189 self.description == other.description)
190
191 def __ne__(self, other):
192 return not (self == other)
193
194 def __str__(self):
195 attrs = ''
196 if self.attrs:
197 attrs = '%s | ' % self.attrs
198 return '%s%s: %s %s' % (attrs, self.state, self.name, self.description)
199
200 def ExpirationDate(self):
201 # Return a datetime.date object with the expiration date for this
202 # test result. Return None, if no expiration has been set.
203 if re.search(r'expire=', self.attrs):
204 expiration = re.search(r'expire=(\d\d\d\d)(\d\d)(\d\d)', self.attrs)
205 if not expiration:
206 Error('Invalid expire= format in "%s". Must be of the form '
207 '"expire=YYYYMMDD"' % self)
208 return datetime.date(int(expiration.group(1)),
209 int(expiration.group(2)),
210 int(expiration.group(3)))
211 return None
212
213 def HasExpired(self):
214 # Return True if the expiration date of this result has passed.
215 expiration_date = self.ExpirationDate()
216 if expiration_date:
Maxim Kuvyrkov158e61d2023-05-25 12:18:30 +0000217 return _OPTIONS.expiry_today_date > expiration_date
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000218
219
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000220class ResultSet(set):
221 """Describes a set of DejaGNU test results.
222 This set can be read in from .sum files or emitted as a manifest.
223
224 Attributes:
225 current_tool: Name of the current top-level DejaGnu testsuite.
226 current_exp: Name of the current .exp testsuite file.
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000227 testsuites: A set of (tool, exp) tuples representing encountered testsuites.
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000228 """
229
230 def __init__(self):
231 super().__init__()
232 self.ResetToolExp()
Maxim Kuvyrkov88799c62024-04-01 12:33:09 +0000233 self.testsuites = set()
234 self.total = 0
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000235
236 def update(self, other):
237 super().update(other)
238 self.testsuites.update(other.testsuites)
Maxim Kuvyrkov88799c62024-04-01 12:33:09 +0000239 self.total += other.total
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000240
241 def ResetToolExp(self):
242 self.current_tool = None
243 self.current_exp = None
244
245 def MakeTestResult(self, summary_line, ordinal=-1):
246 return TestResult(summary_line, ordinal,
247 self.current_tool, self.current_exp)
248
249 def Print(self, outfile=sys.stdout):
250 current_tool = None
251 current_exp = None
252
253 for result in sorted(self):
254 if current_tool != result.tool:
255 current_tool = result.tool
256 outfile.write(_TOOL_LINE_FORMAT % current_tool)
Maxim Kuvyrkov3a777532024-04-18 11:35:58 +0000257 current_exp = None
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000258 if current_exp != result.exp:
259 current_exp = result.exp
Christophe Lyona7d8c4c2023-04-14 12:01:23 +0000260 outfile.write(_EXP_LINE_FORMAT % (current_tool, current_exp))
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000261 outfile.write('%s\n' % result)
262
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000263 # Check if testsuite of expected_result is present in current results.
264 # This is used to compare partial test results against a full manifest.
265 def HasTestsuite(self, expected_result):
266 return (expected_result.tool, expected_result.exp) in self.testsuites
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000267
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000268def GetMakefileValue(makefile_name, value_name):
269 if os.path.exists(makefile_name):
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000270 makefile = open(makefile_name, encoding='latin-1', mode='r')
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000271 for line in makefile:
272 if line.startswith(value_name):
273 (_, value) = line.split('=', 1)
274 value = value.strip()
275 makefile.close()
276 return value
277 makefile.close()
278 return None
279
280
281def ValidBuildDirectory(builddir):
282 if (not os.path.exists(builddir) or
283 not os.path.exists('%s/Makefile' % builddir)):
284 return False
285 return True
286
287
288def IsComment(line):
289 """Return True if line is a comment."""
290 return line.startswith('#')
291
292
293def SplitAttributesFromSummaryLine(line):
294 """Splits off attributes from a summary line, if present."""
Maxim Kuvyrkov966fac42024-04-01 11:47:27 +0000295 if '|' in line and not _INTERESTING_RESULTS_REX.match(line):
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000296 (attrs, line) = line.split('|', 1)
297 attrs = attrs.strip()
298 else:
299 attrs = ''
300 line = line.strip()
301 return (attrs, line)
302
303
Thiago Jung Bauermann41505402023-06-14 14:37:00 +0200304def IsInterestingResult(result_set, line):
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000305 """Return True if line is one of the summary lines we care about."""
306 (_, line) = SplitAttributesFromSummaryLine(line)
Maxim Kuvyrkov966fac42024-04-01 11:47:27 +0000307 interesting_result = bool(_INTERESTING_RESULTS_REX.match(line))
Thiago Jung Bauermann41505402023-06-14 14:37:00 +0200308
Maxim Kuvyrkovc0253642024-04-01 11:51:59 +0000309 # If there's no .exp defined it means that either the results section hasn't
Thiago Jung Bauermann41505402023-06-14 14:37:00 +0200310 # started yet, or it is already over.
Maxim Kuvyrkovc0253642024-04-01 11:51:59 +0000311 if interesting_result and result_set.current_exp is None:
Thiago Jung Bauermann41505402023-06-14 14:37:00 +0200312 if _OPTIONS.verbosity >= 3:
Maxim Kuvyrkovc0253642024-04-01 11:51:59 +0000313 print(f'WARNING: Result "{line}" found outside sum file boundaries.')
Thiago Jung Bauermann41505402023-06-14 14:37:00 +0200314 return False
315
Maxim Kuvyrkov966fac42024-04-01 11:47:27 +0000316 return interesting_result
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000317
318
Maxim Kuvyrkov88799c62024-04-01 12:33:09 +0000319def IsValidResult(result_set, line):
320 """Return True if line is a valid test result."""
321 valid_result = bool(_VALID_RESULTS_REX.match(line))
322
323 # If there's no .exp defined it means that either the results section hasn't
324 # started yet, or it is already over.
325 if valid_result and result_set.current_exp is None:
326 if _OPTIONS.verbosity >= 3:
327 print(f'WARNING: Result "{line}" found outside sum file boundaries.')
328 return False
329
330 return valid_result
331
332
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000333def IsToolLine(line):
334 """Return True if line mentions the tool (in DejaGnu terms) for the following tests."""
335 return bool(_TOOL_LINE_REX.match(line))
336
337
338def IsExpLine(line):
339 """Return True if line mentions the .exp file for the following tests."""
340 return bool(_EXP_LINE_REX.match(line))
341
342
343def IsSummaryLine(line):
344 """Return True if line starts .sum footer."""
345 return bool(_SUMMARY_LINE_REX.match(line))
346
347
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000348def IsInclude(line):
349 """Return True if line is an include of another file."""
350 return line.startswith("@include ")
351
352
353def GetIncludeFile(line, includer):
354 """Extract the name of the include file from line."""
355 includer_dir = os.path.dirname(includer)
356 include_file = line[len("@include "):]
357 return os.path.join(includer_dir, include_file.strip())
358
359
360def IsNegativeResult(line):
361 """Return True if line should be removed from the expected results."""
362 return line.startswith("@remove ")
363
364
365def GetNegativeResult(line):
366 """Extract the name of the negative result from line."""
367 line = line[len("@remove "):]
368 return line.strip()
369
370
371def ParseManifestWorker(result_set, manifest_path):
372 """Read manifest_path, adding the contents to result_set."""
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000373 if _OPTIONS.verbosity >= 5:
Maxim Kuvyrkov63ad5352021-07-04 07:38:22 +0000374 print('Parsing manifest file %s.' % manifest_path)
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000375 manifest_file = open(manifest_path, encoding='latin-1', mode='r')
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000376 for orig_line in manifest_file:
377 line = orig_line.strip()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000378 if line == "":
379 pass
380 elif IsComment(line):
381 pass
382 elif IsNegativeResult(line):
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000383 result_set.remove(result_set.MakeTestResult(GetNegativeResult(line)))
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000384 elif IsInclude(line):
385 ParseManifestWorker(result_set, GetIncludeFile(line, manifest_path))
Thiago Jung Bauermann41505402023-06-14 14:37:00 +0200386 elif IsInterestingResult(result_set, line):
Maxim Kuvyrkova6b29dd2023-04-12 14:35:39 +0000387 result = result_set.MakeTestResult(line)
388 if result.HasExpired():
389 # Ignore expired manifest entries.
Maxim Kuvyrkov7df81782023-05-25 06:42:06 +0000390 if _OPTIONS.verbosity >= 4:
Maxim Kuvyrkova6b29dd2023-04-12 14:35:39 +0000391 print('WARNING: Expected failure "%s" has expired.' % line.strip())
392 continue
393 result_set.add(result)
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000394 elif IsExpLine(orig_line):
395 result_set.current_exp = _EXP_LINE_REX.match(orig_line).groups()[0]
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000396 if _OPTIONS.srcpath_regex and _OPTIONS.srcpath_regex != '':
397 result_set.current_exp = re.sub(_OPTIONS.srcpath_regex, '',
398 result_set.current_exp)
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000399 elif IsToolLine(orig_line):
400 result_set.current_tool = _TOOL_LINE_REX.match(orig_line).groups()[0]
Maxim Kuvyrkovc0253642024-04-01 11:51:59 +0000401 result_set.current_exp = None
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000402 elif IsSummaryLine(orig_line):
403 result_set.ResetToolExp()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000404 else:
405 Error('Unrecognized line in manifest file: %s' % line)
406 manifest_file.close()
407
408
409def ParseManifest(manifest_path):
410 """Create a set of TestResult instances from the given manifest file."""
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000411 result_set = ResultSet()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000412 ParseManifestWorker(result_set, manifest_path)
413 return result_set
414
415
Maxim Kuvyrkova0d90542024-07-23 11:37:04 +0000416def convertJSONResult(json_result):
417 """Convert JSON result into a dejagnu-like line."""
418 # We are just starting to process JSON data (from LLVM's testsuite),
419 # and it seems prudent to convert JSON into dejagnu-like lines, so that we
420 # can re-use dejagnu parsing logic, rather than duplicating it for JSON.
421
422 name = json_result['name']
423 tool_exp = name.split(' :: ')
424 tool_exp[1] = os.path.dirname(tool_exp[1])
425 line = json_result['code'] + ': ' + json_result['name']
426 tool_exp.append(line)
427 return tool_exp
428
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000429def ParseSummary(sum_fname):
430 """Create a set of TestResult instances from the given summary file."""
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000431 result_set = ResultSet()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000432 # ordinal is used when sorting the results so that tests within each
433 # .exp file are kept sorted.
434 ordinal=0
Maxim Kuvyrkova0d90542024-07-23 11:37:04 +0000435
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000436 sum_file = open(sum_fname, encoding='latin-1', mode='r')
Maxim Kuvyrkova0d90542024-07-23 11:37:04 +0000437 file_results = sum_file
438 json_input = sum_fname.endswith('.json')
439
440 if json_input:
441 file_results = json.load(sum_file)
Maxim Kuvyrkova9243212024-08-03 09:37:01 +0000442 if not 'tests' in file_results:
443 if _OPTIONS.verbosity >= 2:
444 # GCC's testing generates random .json files, which we can detect
445 # as results.
446 print(f'WARNING: malformed JSON result file "{sum_fname}"')
447 return result_set
448
Maxim Kuvyrkova0d90542024-07-23 11:37:04 +0000449 file_results = file_results['tests']
450
451 for file_result in file_results:
452 if json_input:
453 (result_set.current_tool, result_set.current_exp, line)\
454 = convertJSONResult(file_result)
Maxim Kuvyrkov13a82492024-07-31 07:32:16 +0000455 # This is a copy of logic from IsExpLine below
456 if _OPTIONS.srcpath_regex and _OPTIONS.srcpath_regex != '':
457 result_set.current_exp = re.sub(_OPTIONS.srcpath_regex, '',
458 result_set.current_exp)
459 result_set.testsuites.add((result_set.current_tool,
460 result_set.current_exp))
Thiago Jung Bauermann672eb022024-07-24 14:43:47 -0300461 else:
462 line = file_result
Maxim Kuvyrkova0d90542024-07-23 11:37:04 +0000463
Thiago Jung Bauermann41505402023-06-14 14:37:00 +0200464 if IsInterestingResult(result_set, line):
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000465 result = result_set.MakeTestResult(line, ordinal)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000466 ordinal += 1
467 if result.HasExpired():
Maxim Kuvyrkova6b29dd2023-04-12 14:35:39 +0000468 # ??? What is the use-case for this? How "expiry" annotations are
469 # ??? supposed to be added to .sum results?
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000470 # Tests that have expired are not added to the set of expected
471 # results. If they are still present in the set of actual results,
472 # they will cause an error to be reported.
Maxim Kuvyrkov7df81782023-05-25 06:42:06 +0000473 if _OPTIONS.verbosity >= 4:
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000474 print('WARNING: Expected failure "%s" has expired.' % line.strip())
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000475 continue
476 result_set.add(result)
Maxim Kuvyrkov88799c62024-04-01 12:33:09 +0000477 result_set.total += 1
478 elif IsValidResult(result_set, line):
479 result_set.total += 1
Maxim Kuvyrkova0d90542024-07-23 11:37:04 +0000480 elif json_input:
481 Error('Unrecognized json result: %s' % line)
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000482 elif IsExpLine(line):
483 result_set.current_exp = _EXP_LINE_REX.match(line).groups()[0]
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000484 if _OPTIONS.srcpath_regex and _OPTIONS.srcpath_regex != '':
485 result_set.current_exp = re.sub(_OPTIONS.srcpath_regex, '',
486 result_set.current_exp)
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000487 result_set.testsuites.add((result_set.current_tool,
488 result_set.current_exp))
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000489 elif IsToolLine(line):
490 result_set.current_tool = _TOOL_LINE_REX.match(line).groups()[0]
Maxim Kuvyrkovd8951a22021-07-08 08:20:28 +0000491 result_set.current_exp = None
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000492 elif IsSummaryLine(line):
493 result_set.ResetToolExp()
Maxim Kuvyrkova0d90542024-07-23 11:37:04 +0000494
495 if json_input:
496 result_set.ResetToolExp()
497
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000498 sum_file.close()
499 return result_set
500
501
502def GetManifest(manifest_path):
503 """Build a set of expected failures from the manifest file.
504
505 Each entry in the manifest file should have the format understood
506 by the TestResult constructor.
507
508 If no manifest file exists for this target, it returns an empty set.
509 """
510 if os.path.exists(manifest_path):
511 return ParseManifest(manifest_path)
512 else:
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000513 return ResultSet()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000514
515
516def CollectSumFiles(builddir):
517 sum_files = []
518 for root, dirs, files in os.walk(builddir):
519 for ignored in ('.svn', '.git'):
520 if ignored in dirs:
521 dirs.remove(ignored)
522 for fname in files:
Maxim Kuvyrkovdfc04502024-07-29 13:00:19 +0000523 if fname.endswith('.sum') or fname.endswith('.json'):
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000524 sum_files.append(os.path.join(root, fname))
525 return sum_files
526
527
Maxim Kuvyrkov8ef7c852021-07-08 08:21:18 +0000528def GetResults(sum_files, build_results = None):
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000529 """Collect all the test results from the given .sum files."""
Maxim Kuvyrkov8ef7c852021-07-08 08:21:18 +0000530 if build_results == None:
531 build_results = ResultSet()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000532 for sum_fname in sum_files:
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000533 if _OPTIONS.verbosity >= 3:
534 print('\t%s' % sum_fname)
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000535 build_results.update(ParseSummary(sum_fname))
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000536 return build_results
537
Maxim Kuvyrkovc0014022024-04-01 12:26:44 +0000538class ResultsStats:
539 """Describes statistics of DejaGNU test results.
540
541 Attributes:
542 fails: Number of non-flaky failed tests in the results.
543 flaky: Number of flaky entries in the manifest.
544 total: Total number of tests in the results, including flaky passes and
545 fails.
546 """
547
548 def __init__(self):
549 self.fails = 0
550 self.flaky = 0
551 self.total = 0
552
553 def Print(self, outfile=sys.stdout):
554 outfile.write(_SUMMARY_LINE_FORMAT % 'Results')
555 outfile.write(f'\n')
556 outfile.write(f'# of stable fails\t\t{self.fails}\n')
557 outfile.write(f'# of flaky entries\t\t{self.flaky}\n')
558 outfile.write(f'# of all tests\t\t\t{self.total}\n')
559
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000560
561def CompareResults(manifest, actual):
562 """Compare sets of results and return two lists:
563 - List of results present in ACTUAL but missing from MANIFEST.
564 - List of results present in MANIFEST but missing from ACTUAL.
565 """
566 # Collect all the actual results not present in the manifest.
567 # Results in this set will be reported as errors.
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000568 actual_vs_manifest = ResultSet()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000569 for actual_result in actual:
570 if actual_result not in manifest:
571 actual_vs_manifest.add(actual_result)
572
573 # Collect all the tests in the manifest that were not found
574 # in the actual results.
575 # Results in this set will be reported as warnings (since
576 # they are expected failures that are not failing anymore).
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000577 manifest_vs_actual = ResultSet()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000578 for expected_result in manifest:
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000579 # We try to support comparing partial results vs full manifest
580 # (e.g., manifest has failures for gcc, g++, gfortran, but we ran only
581 # g++ testsuite). To achieve this we record encountered testsuites in
582 # actual.testsuites set, and then we check it here using HasTestsuite().
583 if expected_result not in actual and actual.HasTestsuite(expected_result):
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000584 manifest_vs_actual.add(expected_result)
585
586 return actual_vs_manifest, manifest_vs_actual
587
588
Maxim Kuvyrkov918bc262021-07-08 08:27:39 +0000589def GetManifestPath(user_provided_must_exist):
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000590 """Return the full path to the manifest file."""
591 manifest_path = _OPTIONS.manifest
592 if manifest_path:
593 if user_provided_must_exist and not os.path.exists(manifest_path):
594 Error('Manifest does not exist: %s' % manifest_path)
595 return manifest_path
596 else:
Maxim Kuvyrkov918bc262021-07-08 08:27:39 +0000597 (srcdir, target) = GetBuildData()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000598 if not srcdir:
599 Error('Could not determine the location of GCC\'s source tree. '
600 'The Makefile does not contain a definition for "srcdir".')
601 if not target:
602 Error('Could not determine the target triplet for this build. '
603 'The Makefile does not contain a definition for "target_alias".')
604 return _MANIFEST_PATH_PATTERN % (srcdir, _MANIFEST_SUBDIR, target)
605
606
607def GetBuildData():
608 if not ValidBuildDirectory(_OPTIONS.build_dir):
609 # If we have been given a set of results to use, we may
610 # not be inside a valid GCC build directory. In that case,
611 # the user must provide both a manifest file and a set
612 # of results to check against it.
613 if not _OPTIONS.results or not _OPTIONS.manifest:
614 Error('%s is not a valid GCC top level build directory. '
615 'You must use --manifest and --results to do the validation.' %
616 _OPTIONS.build_dir)
617 else:
618 return None, None
619 srcdir = GetMakefileValue('%s/Makefile' % _OPTIONS.build_dir, 'srcdir =')
620 target = GetMakefileValue('%s/Makefile' % _OPTIONS.build_dir, 'target_alias=')
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000621 if _OPTIONS.verbosity >= 3:
622 print('Source directory: %s' % srcdir)
623 print('Build target: %s' % target)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000624 return srcdir, target
625
626
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000627def PrintSummary(summary):
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000628 summary.Print()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000629
630def GetSumFiles(results, build_dir):
631 if not results:
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000632 if _OPTIONS.verbosity >= 3:
633 print('Getting actual results from build directory %s' % build_dir)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000634 sum_files = CollectSumFiles(build_dir)
635 else:
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000636 if _OPTIONS.verbosity >= 3:
637 print('Getting actual results from user-provided results')
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000638 sum_files = results.split()
639 return sum_files
640
Maxim Kuvyrkoveb482c72024-04-01 12:30:19 +0000641def DiscardFlaky(expected, actual):
642 flaky_list = []
643 for expected_result in expected:
644 if 'flaky' in expected_result.attrs:
645 flaky_list.append(expected_result)
646
647 for expected_result in flaky_list:
648 expected.remove(expected_result)
649 actual.discard(expected_result)
650
651 return len(flaky_list)
652
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000653
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000654def PerformComparison(expected, actual):
Maxim Kuvyrkovc0014022024-04-01 12:26:44 +0000655 stats = ResultsStats()
Maxim Kuvyrkoveb482c72024-04-01 12:30:19 +0000656 stats.total = actual.total
657 # We need to ignore flaky tests in comparison, so remove them now from
658 # both expected and actual sets.
659 stats.flaky = DiscardFlaky(expected, actual)
Maxim Kuvyrkovc0014022024-04-01 12:26:44 +0000660 stats.fails = len(actual)
661
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000662 actual_vs_expected, expected_vs_actual = CompareResults(expected, actual)
663
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000664 if _OPTIONS.inverse_match:
665 # Switch results if inverse comparison is requested.
666 # This is useful in detecting flaky tests that FAILed in expected set,
667 # but PASSed in actual set.
668 actual_vs_expected, expected_vs_actual \
Maxim Kuvyrkov7df81782023-05-25 06:42:06 +0000669 = expected_vs_actual, actual_vs_expected
Maxim Kuvyrkov55213032024-04-08 12:52:21 +0000670 stats.fails = len(expected)
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000671
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000672 tests_ok = True
673 if len(actual_vs_expected) > 0:
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000674 if _OPTIONS.verbosity >= 3:
675 print('\n\nUnexpected results in this build (new failures)')
676 if _OPTIONS.verbosity >= 1:
677 PrintSummary(actual_vs_expected)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000678 tests_ok = False
679
Maxim Kuvyrkov55213032024-04-08 12:52:21 +0000680 if _OPTIONS.verbosity >= 1:
Maxim Kuvyrkovc0014022024-04-01 12:26:44 +0000681 stats.Print()
682
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000683 if _OPTIONS.verbosity >= 2 and len(expected_vs_actual) > 0:
684 print('\n\nExpected results not present in this build (fixed tests)'
685 '\n\nNOTE: This is not a failure. It just means that these '
686 'tests were expected\nto fail, but either they worked in '
687 'this configuration or they were not\npresent at all.\n')
688 PrintSummary(expected_vs_actual)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000689
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000690 if tests_ok and _OPTIONS.verbosity >= 3:
Maxim Kuvyrkov63ad5352021-07-04 07:38:22 +0000691 print('\nSUCCESS: No unexpected failures.')
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000692
693 return tests_ok
694
695
696def CheckExpectedResults():
Maxim Kuvyrkov918bc262021-07-08 08:27:39 +0000697 manifest_path = GetManifestPath(True)
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000698 if _OPTIONS.verbosity >= 3:
699 print('Manifest: %s' % manifest_path)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000700 manifest = GetManifest(manifest_path)
701 sum_files = GetSumFiles(_OPTIONS.results, _OPTIONS.build_dir)
702 actual = GetResults(sum_files)
703
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000704 if _OPTIONS.verbosity >= 5:
705 print('\n\nTests expected to fail')
706 PrintSummary(manifest)
707 print('\n\nActual test results')
708 PrintSummary(actual)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000709
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000710 return PerformComparison(manifest, actual)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000711
712
713def ProduceManifest():
Maxim Kuvyrkov918bc262021-07-08 08:27:39 +0000714 manifest_path = GetManifestPath(False)
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000715 if _OPTIONS.verbosity >= 3:
716 print('Manifest: %s' % manifest_path)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000717 if os.path.exists(manifest_path) and not _OPTIONS.force:
718 Error('Manifest file %s already exists.\nUse --force to overwrite.' %
719 manifest_path)
720
721 sum_files = GetSumFiles(_OPTIONS.results, _OPTIONS.build_dir)
722 actual = GetResults(sum_files)
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000723 manifest_file = open(manifest_path, encoding='latin-1', mode='w')
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000724 actual.Print(manifest_file)
725 actual.Print()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000726 manifest_file.close()
727
728 return True
729
730
731def CompareBuilds():
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000732 sum_files = GetSumFiles(_OPTIONS.results, _OPTIONS.build_dir)
733 actual = GetResults(sum_files)
734
Maxim Kuvyrkov8ef7c852021-07-08 08:21:18 +0000735 clean = ResultSet()
736
737 if _OPTIONS.manifest:
Maxim Kuvyrkov918bc262021-07-08 08:27:39 +0000738 manifest_path = GetManifestPath(True)
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000739 if _OPTIONS.verbosity >= 3:
740 print('Manifest: %s' % manifest_path)
Maxim Kuvyrkov8ef7c852021-07-08 08:21:18 +0000741 clean = GetManifest(manifest_path)
742
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000743 clean_sum_files = GetSumFiles(_OPTIONS.results, _OPTIONS.clean_build)
Maxim Kuvyrkov8ef7c852021-07-08 08:21:18 +0000744 clean = GetResults(clean_sum_files, clean)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000745
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000746 return PerformComparison(clean, actual)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000747
748
749def Main(argv):
750 parser = optparse.OptionParser(usage=__doc__)
751
752 # Keep the following list sorted by option name.
753 parser.add_option('--build_dir', action='store', type='string',
754 dest='build_dir', default='.',
755 help='Build directory to check (default = .)')
756 parser.add_option('--clean_build', action='store', type='string',
757 dest='clean_build', default=None,
758 help='Compare test results from this build against '
759 'those of another (clean) build. Use this option '
760 'when comparing the test results of your patch versus '
761 'the test results of a clean build without your patch. '
762 'You must provide the path to the top directory of your '
763 'clean build.')
764 parser.add_option('--force', action='store_true', dest='force',
765 default=False, help='When used with --produce_manifest, '
766 'it will overwrite an existing manifest file '
767 '(default = False)')
Maxim Kuvyrkov158e61d2023-05-25 12:18:30 +0000768 parser.add_option('--expiry_date', action='store',
769 dest='expiry_today_date', default=None,
770 help='Use provided date YYYYMMDD to decide whether '
771 'manifest entries with expiry settings have expired '
772 'or not. (default = Use today date)')
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000773 parser.add_option('--srcpath', action='store', type='string',
774 dest='srcpath_regex', default='[^ ]+/testsuite/',
775 help='Remove provided path (can be a regex) from '
776 'the result entries. This is useful to remove '
777 'occasional filesystem path from the results. '
778 '(default = "[^ ]+/testsuite/")')
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000779 parser.add_option('--inverse_match', action='store_true',
780 dest='inverse_match', default=False,
781 help='Inverse result sets in comparison. '
782 'Output unexpected passes as unexpected failures and '
783 'unexpected failures as unexpected passes. '
784 'This is used to catch FAIL->PASS flaky tests. '
785 '(default = False)')
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000786 parser.add_option('--manifest', action='store', type='string',
787 dest='manifest', default=None,
788 help='Name of the manifest file to use (default = '
789 'taken from '
790 'contrib/testsuite-managment/<target_alias>.xfail)')
791 parser.add_option('--produce_manifest', action='store_true',
792 dest='produce_manifest', default=False,
793 help='Produce the manifest for the current '
794 'build (default = False)')
795 parser.add_option('--results', action='store', type='string',
796 dest='results', default=None, help='Space-separated list '
797 'of .sum files with the testing results to check. The '
798 'only content needed from these files are the lines '
799 'starting with FAIL, XPASS or UNRESOLVED (default = '
800 '.sum files collected from the build directory).')
801 parser.add_option('--verbosity', action='store', dest='verbosity',
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000802 type='int', default=3, help='Verbosity level '
803 '(default = 3). Level 0: only error output, this is '
804 'useful in scripting when only the exit code is used. '
805 'Level 1: output unexpected failures. '
806 'Level 2: output unexpected passes. '
807 'Level 3: output helpful information. '
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000808 'Level 4: output notification on expired entries. '
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000809 'Level 5: output debug information.')
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000810 global _OPTIONS
811 (_OPTIONS, _) = parser.parse_args(argv[1:])
812
Maxim Kuvyrkov158e61d2023-05-25 12:18:30 +0000813 # Set "today" date to compare expiration entries against.
814 # Setting expiration date into the future allows re-detection of flaky
815 # tests and creating fresh entries for them before the current flaky entries
816 # expire.
817 if _OPTIONS.expiry_today_date:
818 today_date = re.search(r'(\d\d\d\d)(\d\d)(\d\d)',
819 _OPTIONS.expiry_today_date)
820 if not today_date:
821 Error('Invalid --expiry_today_date format "%s". Must be of the form '
822 '"expire=YYYYMMDD"' % _OPTIONS.expiry_today_date)
823 _OPTIONS.expiry_today_date=datetime.date(int(today_date.group(1)),
824 int(today_date.group(2)),
825 int(today_date.group(3)))
826 else:
827 _OPTIONS.expiry_today_date = datetime.date.today()
828
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000829 if _OPTIONS.produce_manifest:
830 retval = ProduceManifest()
831 elif _OPTIONS.clean_build:
832 retval = CompareBuilds()
833 else:
834 retval = CheckExpectedResults()
835
836 if retval:
837 return 0
838 else:
Maxim Kuvyrkov972bb812021-08-30 14:18:09 +0000839 return 2
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000840
841
842if __name__ == '__main__':
843 retval = Main(sys.argv)
844 sys.exit(retval)