blob: 1d69376c0060853c01bf549fabe1dac707098b9b [file] [log] [blame]
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +00001#!/usr/bin/env python3
Maxim Kuvyrkov59877482021-07-07 11:22:26 +00002
3# Script to compare testsuite failures against a list of known-to-fail
4# tests.
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +00005
Maxim Kuvyrkov59877482021-07-07 11:22:26 +00006# Contributed by Diego Novillo <dnovillo@google.com>
7#
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +00008# Copyright (C) 2011-2023 Free Software Foundation, Inc.
Maxim Kuvyrkov59877482021-07-07 11:22:26 +00009#
10# This file is part of GCC.
11#
12# GCC is free software; you can redistribute it and/or modify
13# it under the terms of the GNU General Public License as published by
14# the Free Software Foundation; either version 3, or (at your option)
15# any later version.
16#
17# GCC is distributed in the hope that it will be useful,
18# but WITHOUT ANY WARRANTY; without even the implied warranty of
19# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
20# GNU General Public License for more details.
21#
22# You should have received a copy of the GNU General Public License
23# along with GCC; see the file COPYING. If not, write to
24# the Free Software Foundation, 51 Franklin Street, Fifth Floor,
25# Boston, MA 02110-1301, USA.
26
27"""This script provides a coarser XFAILing mechanism that requires no
28detailed DejaGNU markings. This is useful in a variety of scenarios:
29
30- Development branches with many known failures waiting to be fixed.
31- Release branches with known failures that are not considered
32 important for the particular release criteria used in that branch.
33
34The script must be executed from the toplevel build directory. When
35executed it will:
36
371- Determine the target built: TARGET
382- Determine the source directory: SRCDIR
393- Look for a failure manifest file in
40 <SRCDIR>/<MANIFEST_SUBDIR>/<MANIFEST_NAME>.xfail
414- Collect all the <tool>.sum files from the build tree.
425- Produce a report stating:
43 a- Failures expected in the manifest but not present in the build.
44 b- Failures in the build not expected in the manifest.
456- If all the build failures are expected in the manifest, it exits
46 with exit code 0. Otherwise, it exits with error code 1.
47
48Manifest files contain expected DejaGNU results that are otherwise
49treated as failures.
50They may also contain additional text:
51
52# This is a comment. - self explanatory
53@include file - the file is a path relative to the includer
54@remove result text - result text is removed from the expected set
55"""
56
57import datetime
58import optparse
59import os
60import re
61import sys
62
Maxim Kuvyrkov966fac42024-04-01 11:47:27 +000063_INTERESTING_RESULTS = [ 'FAIL', 'UNRESOLVED', 'XPASS', 'ERROR' ]
Maxim Kuvyrkov8704bc12023-05-03 15:03:34 +000064# <STATE>: <NAME> <DESCRIPTION"
Maxim Kuvyrkov966fac42024-04-01 11:47:27 +000065_INTERESTING_RESULTS_REX = re.compile('(%s):\s*(\S+)\s*(.*)'
66 % "|".join(_INTERESTING_RESULTS))
Maxim Kuvyrkov8704bc12023-05-03 15:03:34 +000067
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +000068# Formats of .sum file sections
69_TOOL_LINE_FORMAT = '\t\t=== %s tests ===\n'
Christophe Lyona7d8c4c2023-04-14 12:01:23 +000070_EXP_LINE_FORMAT = '\nRunning %s:%s ...\n'
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +000071_SUMMARY_LINE_FORMAT = '\n\t\t=== %s Summary ===\n'
72
73# ... and their compiled regexs.
74_TOOL_LINE_REX = re.compile('^\t\t=== (.*) tests ===\n')
Christophe Lyona7d8c4c2023-04-14 12:01:23 +000075# Match .exp file name, optionally prefixed by a "tool:" name and a
76# path ending with "testsuite/"
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +000077_EXP_LINE_REX = re.compile('^Running (?:.*:)?(.*) \.\.\.\n')
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +000078_SUMMARY_LINE_REX = re.compile('^\t\t=== (.*) Summary ===\n')
79
Maxim Kuvyrkov59877482021-07-07 11:22:26 +000080# Subdirectory of srcdir in which to find the manifest file.
81_MANIFEST_SUBDIR = 'contrib/testsuite-management'
82
83# Pattern for naming manifest files.
84# The first argument should be the toplevel GCC(/GNU tool) source directory.
85# The second argument is the manifest subdir.
86# The third argument is the manifest target, which defaults to the target
87# triplet used during the build.
88_MANIFEST_PATH_PATTERN = '%s/%s/%s.xfail'
89
90# The options passed to the program.
91_OPTIONS = None
92
93def Error(msg):
Maxim Kuvyrkov63ad5352021-07-04 07:38:22 +000094 print('error: %s' % msg, file=sys.stderr)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +000095 sys.exit(1)
96
97
98class TestResult(object):
99 """Describes a single DejaGNU test result as emitted in .sum files.
100
101 We are only interested in representing unsuccessful tests. So, only
102 a subset of all the tests are loaded.
103
104 The summary line used to build the test result should have this format:
105
106 attrlist | XPASS: gcc.dg/unroll_1.c (test for excess errors)
107 ^^^^^^^^ ^^^^^ ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^
108 optional state name description
109 attributes
110
111 Attributes:
112 attrlist: A comma separated list of attributes.
113 Valid values:
114 flaky Indicates that this test may not always fail. These
115 tests are reported, but their presence does not affect
116 the results.
117
118 expire=YYYYMMDD After this date, this test will produce an error
119 whether it is in the manifest or not.
120
121 state: One of UNRESOLVED, XPASS or FAIL.
122 name: File name for the test.
123 description: String describing the test (flags used, dejagnu message, etc)
124 ordinal: Monotonically increasing integer.
125 It is used to keep results for one .exp file sorted
126 by the order the tests were run.
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000127 tool: Top-level testsuite name (aka "tool" in DejaGnu parlance) of the test.
128 exp: Name of .exp testsuite file.
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000129 """
130
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000131 def __init__(self, summary_line, ordinal, tool, exp):
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000132 try:
133 (self.attrs, summary_line) = SplitAttributesFromSummaryLine(summary_line)
134 try:
135 (self.state,
136 self.name,
Maxim Kuvyrkov966fac42024-04-01 11:47:27 +0000137 self.description) = _INTERESTING_RESULTS_REX.match(summary_line).groups()
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000138 if _OPTIONS.srcpath_regex and _OPTIONS.srcpath_regex != '':
139 self.description = re.sub(_OPTIONS.srcpath_regex, '',
140 self.description)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000141 except:
Thiago Jung Bauermann7b82a592023-04-22 14:12:06 +0000142 print('Failed to parse summary line: "%s"' % summary_line,
143 file=sys.stderr)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000144 raise
145 self.ordinal = ordinal
Maxim Kuvyrkovf09ab0e2021-08-30 14:19:04 +0000146 if tool == None or exp == None:
147 # .sum file seem to be broken. There was no "tool" and/or "exp"
148 # lines preceding this result.
Thiago Jung Bauermann7b82a592023-04-22 14:12:06 +0000149 print(f'.sum file seems to be broken: tool="{tool}", exp="{exp}", summary_line="{summary_line}"',
150 file=sys.stderr)
Maxim Kuvyrkovf09ab0e2021-08-30 14:19:04 +0000151 raise
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000152 self.tool = tool
153 self.exp = exp
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000154 except ValueError:
155 Error('Cannot parse summary line "%s"' % summary_line)
156
Maxim Kuvyrkov966fac42024-04-01 11:47:27 +0000157 if self.state not in _INTERESTING_RESULTS:
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000158 Error('Invalid test result %s in "%s" (parsed as "%s")' % (
159 self.state, summary_line, self))
160
161 def __lt__(self, other):
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000162 if (self.tool != other.tool):
163 return self.tool < other.tool
164 if (self.exp != other.exp):
165 return self.exp < other.exp
166 if (self.name != other.name):
167 return self.name < other.name
168 return self.ordinal < other.ordinal
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000169
170 def __hash__(self):
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000171 return (hash(self.state) ^ hash(self.tool) ^ hash(self.exp)
172 ^ hash(self.name) ^ hash(self.description))
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000173
Maxim Kuvyrkov7df81782023-05-25 06:42:06 +0000174 # Note that we don't include "attrs" in this comparison. This means that
175 # result entries "FAIL: test" and "flaky | FAIL: test" are considered
176 # the same. Therefore the ResultSet will preserve only the first occurence.
177 # In practice this means that flaky entries should preceed expected fails
178 # entries.
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000179 def __eq__(self, other):
180 return (self.state == other.state and
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000181 self.tool == other.tool and
182 self.exp == other.exp and
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000183 self.name == other.name and
184 self.description == other.description)
185
186 def __ne__(self, other):
187 return not (self == other)
188
189 def __str__(self):
190 attrs = ''
191 if self.attrs:
192 attrs = '%s | ' % self.attrs
193 return '%s%s: %s %s' % (attrs, self.state, self.name, self.description)
194
195 def ExpirationDate(self):
196 # Return a datetime.date object with the expiration date for this
197 # test result. Return None, if no expiration has been set.
198 if re.search(r'expire=', self.attrs):
199 expiration = re.search(r'expire=(\d\d\d\d)(\d\d)(\d\d)', self.attrs)
200 if not expiration:
201 Error('Invalid expire= format in "%s". Must be of the form '
202 '"expire=YYYYMMDD"' % self)
203 return datetime.date(int(expiration.group(1)),
204 int(expiration.group(2)),
205 int(expiration.group(3)))
206 return None
207
208 def HasExpired(self):
209 # Return True if the expiration date of this result has passed.
210 expiration_date = self.ExpirationDate()
211 if expiration_date:
Maxim Kuvyrkov158e61d2023-05-25 12:18:30 +0000212 return _OPTIONS.expiry_today_date > expiration_date
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000213
214
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000215class ResultSet(set):
216 """Describes a set of DejaGNU test results.
217 This set can be read in from .sum files or emitted as a manifest.
218
219 Attributes:
220 current_tool: Name of the current top-level DejaGnu testsuite.
221 current_exp: Name of the current .exp testsuite file.
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000222 testsuites: A set of (tool, exp) tuples representing encountered testsuites.
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000223 """
224
225 def __init__(self):
226 super().__init__()
227 self.ResetToolExp()
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000228 self.testsuites=set()
229
230 def update(self, other):
231 super().update(other)
232 self.testsuites.update(other.testsuites)
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000233
234 def ResetToolExp(self):
235 self.current_tool = None
236 self.current_exp = None
237
238 def MakeTestResult(self, summary_line, ordinal=-1):
239 return TestResult(summary_line, ordinal,
240 self.current_tool, self.current_exp)
241
242 def Print(self, outfile=sys.stdout):
243 current_tool = None
244 current_exp = None
245
246 for result in sorted(self):
247 if current_tool != result.tool:
248 current_tool = result.tool
249 outfile.write(_TOOL_LINE_FORMAT % current_tool)
250 if current_exp != result.exp:
251 current_exp = result.exp
Christophe Lyona7d8c4c2023-04-14 12:01:23 +0000252 outfile.write(_EXP_LINE_FORMAT % (current_tool, current_exp))
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000253 outfile.write('%s\n' % result)
254
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000255
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000256 # Check if testsuite of expected_result is present in current results.
257 # This is used to compare partial test results against a full manifest.
258 def HasTestsuite(self, expected_result):
259 return (expected_result.tool, expected_result.exp) in self.testsuites
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000260
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000261def GetMakefileValue(makefile_name, value_name):
262 if os.path.exists(makefile_name):
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000263 makefile = open(makefile_name, encoding='latin-1', mode='r')
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000264 for line in makefile:
265 if line.startswith(value_name):
266 (_, value) = line.split('=', 1)
267 value = value.strip()
268 makefile.close()
269 return value
270 makefile.close()
271 return None
272
273
274def ValidBuildDirectory(builddir):
275 if (not os.path.exists(builddir) or
276 not os.path.exists('%s/Makefile' % builddir)):
277 return False
278 return True
279
280
281def IsComment(line):
282 """Return True if line is a comment."""
283 return line.startswith('#')
284
285
286def SplitAttributesFromSummaryLine(line):
287 """Splits off attributes from a summary line, if present."""
Maxim Kuvyrkov966fac42024-04-01 11:47:27 +0000288 if '|' in line and not _INTERESTING_RESULTS_REX.match(line):
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000289 (attrs, line) = line.split('|', 1)
290 attrs = attrs.strip()
291 else:
292 attrs = ''
293 line = line.strip()
294 return (attrs, line)
295
296
Thiago Jung Bauermann41505402023-06-14 14:37:00 +0200297def IsInterestingResult(result_set, line):
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000298 """Return True if line is one of the summary lines we care about."""
299 (_, line) = SplitAttributesFromSummaryLine(line)
Maxim Kuvyrkov966fac42024-04-01 11:47:27 +0000300 interesting_result = bool(_INTERESTING_RESULTS_REX.match(line))
Thiago Jung Bauermann41505402023-06-14 14:37:00 +0200301
Maxim Kuvyrkovc0253642024-04-01 11:51:59 +0000302 # If there's no .exp defined it means that either the results section hasn't
Thiago Jung Bauermann41505402023-06-14 14:37:00 +0200303 # started yet, or it is already over.
Maxim Kuvyrkovc0253642024-04-01 11:51:59 +0000304 if interesting_result and result_set.current_exp is None:
Thiago Jung Bauermann41505402023-06-14 14:37:00 +0200305 if _OPTIONS.verbosity >= 3:
Maxim Kuvyrkovc0253642024-04-01 11:51:59 +0000306 print(f'WARNING: Result "{line}" found outside sum file boundaries.')
Thiago Jung Bauermann41505402023-06-14 14:37:00 +0200307 return False
308
Maxim Kuvyrkov966fac42024-04-01 11:47:27 +0000309 return interesting_result
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000310
311
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000312def IsToolLine(line):
313 """Return True if line mentions the tool (in DejaGnu terms) for the following tests."""
314 return bool(_TOOL_LINE_REX.match(line))
315
316
317def IsExpLine(line):
318 """Return True if line mentions the .exp file for the following tests."""
319 return bool(_EXP_LINE_REX.match(line))
320
321
322def IsSummaryLine(line):
323 """Return True if line starts .sum footer."""
324 return bool(_SUMMARY_LINE_REX.match(line))
325
326
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000327def IsInclude(line):
328 """Return True if line is an include of another file."""
329 return line.startswith("@include ")
330
331
332def GetIncludeFile(line, includer):
333 """Extract the name of the include file from line."""
334 includer_dir = os.path.dirname(includer)
335 include_file = line[len("@include "):]
336 return os.path.join(includer_dir, include_file.strip())
337
338
339def IsNegativeResult(line):
340 """Return True if line should be removed from the expected results."""
341 return line.startswith("@remove ")
342
343
344def GetNegativeResult(line):
345 """Extract the name of the negative result from line."""
346 line = line[len("@remove "):]
347 return line.strip()
348
349
350def ParseManifestWorker(result_set, manifest_path):
351 """Read manifest_path, adding the contents to result_set."""
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000352 if _OPTIONS.verbosity >= 5:
Maxim Kuvyrkov63ad5352021-07-04 07:38:22 +0000353 print('Parsing manifest file %s.' % manifest_path)
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000354 manifest_file = open(manifest_path, encoding='latin-1', mode='r')
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000355 for orig_line in manifest_file:
356 line = orig_line.strip()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000357 if line == "":
358 pass
359 elif IsComment(line):
360 pass
361 elif IsNegativeResult(line):
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000362 result_set.remove(result_set.MakeTestResult(GetNegativeResult(line)))
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000363 elif IsInclude(line):
364 ParseManifestWorker(result_set, GetIncludeFile(line, manifest_path))
Thiago Jung Bauermann41505402023-06-14 14:37:00 +0200365 elif IsInterestingResult(result_set, line):
Maxim Kuvyrkova6b29dd2023-04-12 14:35:39 +0000366 result = result_set.MakeTestResult(line)
367 if result.HasExpired():
368 # Ignore expired manifest entries.
Maxim Kuvyrkov7df81782023-05-25 06:42:06 +0000369 if _OPTIONS.verbosity >= 4:
Maxim Kuvyrkova6b29dd2023-04-12 14:35:39 +0000370 print('WARNING: Expected failure "%s" has expired.' % line.strip())
371 continue
372 result_set.add(result)
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000373 elif IsExpLine(orig_line):
374 result_set.current_exp = _EXP_LINE_REX.match(orig_line).groups()[0]
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000375 if _OPTIONS.srcpath_regex and _OPTIONS.srcpath_regex != '':
376 result_set.current_exp = re.sub(_OPTIONS.srcpath_regex, '',
377 result_set.current_exp)
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000378 elif IsToolLine(orig_line):
379 result_set.current_tool = _TOOL_LINE_REX.match(orig_line).groups()[0]
Maxim Kuvyrkovc0253642024-04-01 11:51:59 +0000380 result_set.current_exp = None
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000381 elif IsSummaryLine(orig_line):
382 result_set.ResetToolExp()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000383 else:
384 Error('Unrecognized line in manifest file: %s' % line)
385 manifest_file.close()
386
387
388def ParseManifest(manifest_path):
389 """Create a set of TestResult instances from the given manifest file."""
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000390 result_set = ResultSet()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000391 ParseManifestWorker(result_set, manifest_path)
392 return result_set
393
394
395def ParseSummary(sum_fname):
396 """Create a set of TestResult instances from the given summary file."""
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000397 result_set = ResultSet()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000398 # ordinal is used when sorting the results so that tests within each
399 # .exp file are kept sorted.
400 ordinal=0
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000401 sum_file = open(sum_fname, encoding='latin-1', mode='r')
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000402 for line in sum_file:
Thiago Jung Bauermann41505402023-06-14 14:37:00 +0200403 if IsInterestingResult(result_set, line):
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000404 result = result_set.MakeTestResult(line, ordinal)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000405 ordinal += 1
406 if result.HasExpired():
Maxim Kuvyrkova6b29dd2023-04-12 14:35:39 +0000407 # ??? What is the use-case for this? How "expiry" annotations are
408 # ??? supposed to be added to .sum results?
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000409 # Tests that have expired are not added to the set of expected
410 # results. If they are still present in the set of actual results,
411 # they will cause an error to be reported.
Maxim Kuvyrkov7df81782023-05-25 06:42:06 +0000412 if _OPTIONS.verbosity >= 4:
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000413 print('WARNING: Expected failure "%s" has expired.' % line.strip())
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000414 continue
415 result_set.add(result)
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000416 elif IsExpLine(line):
417 result_set.current_exp = _EXP_LINE_REX.match(line).groups()[0]
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000418 if _OPTIONS.srcpath_regex and _OPTIONS.srcpath_regex != '':
419 result_set.current_exp = re.sub(_OPTIONS.srcpath_regex, '',
420 result_set.current_exp)
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000421 result_set.testsuites.add((result_set.current_tool,
422 result_set.current_exp))
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000423 elif IsToolLine(line):
424 result_set.current_tool = _TOOL_LINE_REX.match(line).groups()[0]
Maxim Kuvyrkovd8951a22021-07-08 08:20:28 +0000425 result_set.current_exp = None
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000426 elif IsSummaryLine(line):
427 result_set.ResetToolExp()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000428 sum_file.close()
429 return result_set
430
431
432def GetManifest(manifest_path):
433 """Build a set of expected failures from the manifest file.
434
435 Each entry in the manifest file should have the format understood
436 by the TestResult constructor.
437
438 If no manifest file exists for this target, it returns an empty set.
439 """
440 if os.path.exists(manifest_path):
441 return ParseManifest(manifest_path)
442 else:
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000443 return ResultSet()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000444
445
446def CollectSumFiles(builddir):
447 sum_files = []
448 for root, dirs, files in os.walk(builddir):
449 for ignored in ('.svn', '.git'):
450 if ignored in dirs:
451 dirs.remove(ignored)
452 for fname in files:
453 if fname.endswith('.sum'):
454 sum_files.append(os.path.join(root, fname))
455 return sum_files
456
457
Maxim Kuvyrkov8ef7c852021-07-08 08:21:18 +0000458def GetResults(sum_files, build_results = None):
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000459 """Collect all the test results from the given .sum files."""
Maxim Kuvyrkov8ef7c852021-07-08 08:21:18 +0000460 if build_results == None:
461 build_results = ResultSet()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000462 for sum_fname in sum_files:
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000463 if _OPTIONS.verbosity >= 3:
464 print('\t%s' % sum_fname)
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000465 build_results.update(ParseSummary(sum_fname))
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000466 return build_results
467
Maxim Kuvyrkovc0014022024-04-01 12:26:44 +0000468class ResultsStats:
469 """Describes statistics of DejaGNU test results.
470
471 Attributes:
472 fails: Number of non-flaky failed tests in the results.
473 flaky: Number of flaky entries in the manifest.
474 total: Total number of tests in the results, including flaky passes and
475 fails.
476 """
477
478 def __init__(self):
479 self.fails = 0
480 self.flaky = 0
481 self.total = 0
482
483 def Print(self, outfile=sys.stdout):
484 outfile.write(_SUMMARY_LINE_FORMAT % 'Results')
485 outfile.write(f'\n')
486 outfile.write(f'# of stable fails\t\t{self.fails}\n')
487 outfile.write(f'# of flaky entries\t\t{self.flaky}\n')
488 outfile.write(f'# of all tests\t\t\t{self.total}\n')
489
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000490
491def CompareResults(manifest, actual):
492 """Compare sets of results and return two lists:
493 - List of results present in ACTUAL but missing from MANIFEST.
494 - List of results present in MANIFEST but missing from ACTUAL.
495 """
496 # Collect all the actual results not present in the manifest.
497 # Results in this set will be reported as errors.
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000498 actual_vs_manifest = ResultSet()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000499 for actual_result in actual:
500 if actual_result not in manifest:
501 actual_vs_manifest.add(actual_result)
502
503 # Collect all the tests in the manifest that were not found
504 # in the actual results.
505 # Results in this set will be reported as warnings (since
506 # they are expected failures that are not failing anymore).
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000507 manifest_vs_actual = ResultSet()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000508 for expected_result in manifest:
509 # Ignore tests marked flaky.
510 if 'flaky' in expected_result.attrs:
511 continue
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000512 # We try to support comparing partial results vs full manifest
513 # (e.g., manifest has failures for gcc, g++, gfortran, but we ran only
514 # g++ testsuite). To achieve this we record encountered testsuites in
515 # actual.testsuites set, and then we check it here using HasTestsuite().
516 if expected_result not in actual and actual.HasTestsuite(expected_result):
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000517 manifest_vs_actual.add(expected_result)
518
519 return actual_vs_manifest, manifest_vs_actual
520
521
Maxim Kuvyrkov918bc262021-07-08 08:27:39 +0000522def GetManifestPath(user_provided_must_exist):
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000523 """Return the full path to the manifest file."""
524 manifest_path = _OPTIONS.manifest
525 if manifest_path:
526 if user_provided_must_exist and not os.path.exists(manifest_path):
527 Error('Manifest does not exist: %s' % manifest_path)
528 return manifest_path
529 else:
Maxim Kuvyrkov918bc262021-07-08 08:27:39 +0000530 (srcdir, target) = GetBuildData()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000531 if not srcdir:
532 Error('Could not determine the location of GCC\'s source tree. '
533 'The Makefile does not contain a definition for "srcdir".')
534 if not target:
535 Error('Could not determine the target triplet for this build. '
536 'The Makefile does not contain a definition for "target_alias".')
537 return _MANIFEST_PATH_PATTERN % (srcdir, _MANIFEST_SUBDIR, target)
538
539
540def GetBuildData():
541 if not ValidBuildDirectory(_OPTIONS.build_dir):
542 # If we have been given a set of results to use, we may
543 # not be inside a valid GCC build directory. In that case,
544 # the user must provide both a manifest file and a set
545 # of results to check against it.
546 if not _OPTIONS.results or not _OPTIONS.manifest:
547 Error('%s is not a valid GCC top level build directory. '
548 'You must use --manifest and --results to do the validation.' %
549 _OPTIONS.build_dir)
550 else:
551 return None, None
552 srcdir = GetMakefileValue('%s/Makefile' % _OPTIONS.build_dir, 'srcdir =')
553 target = GetMakefileValue('%s/Makefile' % _OPTIONS.build_dir, 'target_alias=')
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000554 if _OPTIONS.verbosity >= 3:
555 print('Source directory: %s' % srcdir)
556 print('Build target: %s' % target)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000557 return srcdir, target
558
559
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000560def PrintSummary(summary):
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000561 summary.Print()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000562
563def GetSumFiles(results, build_dir):
564 if not results:
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000565 if _OPTIONS.verbosity >= 3:
566 print('Getting actual results from build directory %s' % build_dir)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000567 sum_files = CollectSumFiles(build_dir)
568 else:
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000569 if _OPTIONS.verbosity >= 3:
570 print('Getting actual results from user-provided results')
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000571 sum_files = results.split()
572 return sum_files
573
574
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000575def PerformComparison(expected, actual):
Maxim Kuvyrkovc0014022024-04-01 12:26:44 +0000576 stats = ResultsStats()
577 stats.fails = len(actual)
578
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000579 actual_vs_expected, expected_vs_actual = CompareResults(expected, actual)
580
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000581 if _OPTIONS.inverse_match:
582 # Switch results if inverse comparison is requested.
583 # This is useful in detecting flaky tests that FAILed in expected set,
584 # but PASSed in actual set.
585 actual_vs_expected, expected_vs_actual \
Maxim Kuvyrkov7df81782023-05-25 06:42:06 +0000586 = expected_vs_actual, actual_vs_expected
Maxim Kuvyrkovc0014022024-04-01 12:26:44 +0000587 stats = None
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000588
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000589 tests_ok = True
590 if len(actual_vs_expected) > 0:
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000591 if _OPTIONS.verbosity >= 3:
592 print('\n\nUnexpected results in this build (new failures)')
593 if _OPTIONS.verbosity >= 1:
594 PrintSummary(actual_vs_expected)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000595 tests_ok = False
596
Maxim Kuvyrkovc0014022024-04-01 12:26:44 +0000597 if _OPTIONS.verbosity >= 1 and stats:
598 stats.Print()
599
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000600 if _OPTIONS.verbosity >= 2 and len(expected_vs_actual) > 0:
601 print('\n\nExpected results not present in this build (fixed tests)'
602 '\n\nNOTE: This is not a failure. It just means that these '
603 'tests were expected\nto fail, but either they worked in '
604 'this configuration or they were not\npresent at all.\n')
605 PrintSummary(expected_vs_actual)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000606
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000607 if tests_ok and _OPTIONS.verbosity >= 3:
Maxim Kuvyrkov63ad5352021-07-04 07:38:22 +0000608 print('\nSUCCESS: No unexpected failures.')
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000609
610 return tests_ok
611
612
613def CheckExpectedResults():
Maxim Kuvyrkov918bc262021-07-08 08:27:39 +0000614 manifest_path = GetManifestPath(True)
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000615 if _OPTIONS.verbosity >= 3:
616 print('Manifest: %s' % manifest_path)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000617 manifest = GetManifest(manifest_path)
618 sum_files = GetSumFiles(_OPTIONS.results, _OPTIONS.build_dir)
619 actual = GetResults(sum_files)
620
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000621 if _OPTIONS.verbosity >= 5:
622 print('\n\nTests expected to fail')
623 PrintSummary(manifest)
624 print('\n\nActual test results')
625 PrintSummary(actual)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000626
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000627 return PerformComparison(manifest, actual)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000628
629
630def ProduceManifest():
Maxim Kuvyrkov918bc262021-07-08 08:27:39 +0000631 manifest_path = GetManifestPath(False)
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000632 if _OPTIONS.verbosity >= 3:
633 print('Manifest: %s' % manifest_path)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000634 if os.path.exists(manifest_path) and not _OPTIONS.force:
635 Error('Manifest file %s already exists.\nUse --force to overwrite.' %
636 manifest_path)
637
638 sum_files = GetSumFiles(_OPTIONS.results, _OPTIONS.build_dir)
639 actual = GetResults(sum_files)
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000640 manifest_file = open(manifest_path, encoding='latin-1', mode='w')
Maxim Kuvyrkov51e3fa12021-07-04 10:58:53 +0000641 actual.Print(manifest_file)
642 actual.Print()
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000643 manifest_file.close()
644
645 return True
646
647
648def CompareBuilds():
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000649 sum_files = GetSumFiles(_OPTIONS.results, _OPTIONS.build_dir)
650 actual = GetResults(sum_files)
651
Maxim Kuvyrkov8ef7c852021-07-08 08:21:18 +0000652 clean = ResultSet()
653
654 if _OPTIONS.manifest:
Maxim Kuvyrkov918bc262021-07-08 08:27:39 +0000655 manifest_path = GetManifestPath(True)
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000656 if _OPTIONS.verbosity >= 3:
657 print('Manifest: %s' % manifest_path)
Maxim Kuvyrkov8ef7c852021-07-08 08:21:18 +0000658 clean = GetManifest(manifest_path)
659
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000660 clean_sum_files = GetSumFiles(_OPTIONS.results, _OPTIONS.clean_build)
Maxim Kuvyrkov8ef7c852021-07-08 08:21:18 +0000661 clean = GetResults(clean_sum_files, clean)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000662
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000663 return PerformComparison(clean, actual)
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000664
665
666def Main(argv):
667 parser = optparse.OptionParser(usage=__doc__)
668
669 # Keep the following list sorted by option name.
670 parser.add_option('--build_dir', action='store', type='string',
671 dest='build_dir', default='.',
672 help='Build directory to check (default = .)')
673 parser.add_option('--clean_build', action='store', type='string',
674 dest='clean_build', default=None,
675 help='Compare test results from this build against '
676 'those of another (clean) build. Use this option '
677 'when comparing the test results of your patch versus '
678 'the test results of a clean build without your patch. '
679 'You must provide the path to the top directory of your '
680 'clean build.')
681 parser.add_option('--force', action='store_true', dest='force',
682 default=False, help='When used with --produce_manifest, '
683 'it will overwrite an existing manifest file '
684 '(default = False)')
Maxim Kuvyrkov158e61d2023-05-25 12:18:30 +0000685 parser.add_option('--expiry_date', action='store',
686 dest='expiry_today_date', default=None,
687 help='Use provided date YYYYMMDD to decide whether '
688 'manifest entries with expiry settings have expired '
689 'or not. (default = Use today date)')
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000690 parser.add_option('--srcpath', action='store', type='string',
691 dest='srcpath_regex', default='[^ ]+/testsuite/',
692 help='Remove provided path (can be a regex) from '
693 'the result entries. This is useful to remove '
694 'occasional filesystem path from the results. '
695 '(default = "[^ ]+/testsuite/")')
Maxim Kuvyrkovd8d6c472023-05-03 15:53:17 +0000696 parser.add_option('--inverse_match', action='store_true',
697 dest='inverse_match', default=False,
698 help='Inverse result sets in comparison. '
699 'Output unexpected passes as unexpected failures and '
700 'unexpected failures as unexpected passes. '
701 'This is used to catch FAIL->PASS flaky tests. '
702 '(default = False)')
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000703 parser.add_option('--manifest', action='store', type='string',
704 dest='manifest', default=None,
705 help='Name of the manifest file to use (default = '
706 'taken from '
707 'contrib/testsuite-managment/<target_alias>.xfail)')
708 parser.add_option('--produce_manifest', action='store_true',
709 dest='produce_manifest', default=False,
710 help='Produce the manifest for the current '
711 'build (default = False)')
712 parser.add_option('--results', action='store', type='string',
713 dest='results', default=None, help='Space-separated list '
714 'of .sum files with the testing results to check. The '
715 'only content needed from these files are the lines '
716 'starting with FAIL, XPASS or UNRESOLVED (default = '
717 '.sum files collected from the build directory).')
718 parser.add_option('--verbosity', action='store', dest='verbosity',
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000719 type='int', default=3, help='Verbosity level '
720 '(default = 3). Level 0: only error output, this is '
721 'useful in scripting when only the exit code is used. '
722 'Level 1: output unexpected failures. '
723 'Level 2: output unexpected passes. '
724 'Level 3: output helpful information. '
Maxim Kuvyrkov8396bb32023-06-14 14:32:38 +0000725 'Level 4: output notification on expired entries. '
Maxim Kuvyrkov40205382021-07-12 15:41:47 +0000726 'Level 5: output debug information.')
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000727 global _OPTIONS
728 (_OPTIONS, _) = parser.parse_args(argv[1:])
729
Maxim Kuvyrkov158e61d2023-05-25 12:18:30 +0000730 # Set "today" date to compare expiration entries against.
731 # Setting expiration date into the future allows re-detection of flaky
732 # tests and creating fresh entries for them before the current flaky entries
733 # expire.
734 if _OPTIONS.expiry_today_date:
735 today_date = re.search(r'(\d\d\d\d)(\d\d)(\d\d)',
736 _OPTIONS.expiry_today_date)
737 if not today_date:
738 Error('Invalid --expiry_today_date format "%s". Must be of the form '
739 '"expire=YYYYMMDD"' % _OPTIONS.expiry_today_date)
740 _OPTIONS.expiry_today_date=datetime.date(int(today_date.group(1)),
741 int(today_date.group(2)),
742 int(today_date.group(3)))
743 else:
744 _OPTIONS.expiry_today_date = datetime.date.today()
745
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000746 if _OPTIONS.produce_manifest:
747 retval = ProduceManifest()
748 elif _OPTIONS.clean_build:
749 retval = CompareBuilds()
750 else:
751 retval = CheckExpectedResults()
752
753 if retval:
754 return 0
755 else:
Maxim Kuvyrkov972bb812021-08-30 14:18:09 +0000756 return 2
Maxim Kuvyrkov59877482021-07-07 11:22:26 +0000757
758
759if __name__ == '__main__':
760 retval = Main(sys.argv)
761 sys.exit(retval)