diff options
author | Nicholas Allegra <comexk@gmail.com> | 2019-09-27 01:58:31 +0000 |
---|---|---|
committer | Nicholas Allegra <comexk@gmail.com> | 2019-09-27 01:58:31 +0000 |
commit | 26105cbd682a5756098f2360ebde8b194ce698b5 (patch) | |
tree | 957d8c4d640cea5ac2ea42e6b68d425a359688d6 | |
parent | 8bb8102fb5a75a921513a358b5fd1acdd849a37f (diff) |
Revert r373034
It breaks the build on MSVC.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@373039 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | include/clang/AST/Stmt.h | 3 | ||||
-rw-r--r-- | lib/Analysis/Consumed.cpp | 43 |
2 files changed, 21 insertions, 25 deletions
diff --git a/include/clang/AST/Stmt.h b/include/clang/AST/Stmt.h index d07fec4a11..403b88ac3a 100644 --- a/include/clang/AST/Stmt.h +++ b/include/clang/AST/Stmt.h @@ -1041,8 +1041,7 @@ protected: template<typename T, typename TPtr = T *, typename StmtPtr = Stmt *> struct CastIterator : llvm::iterator_adaptor_base<CastIterator<T, TPtr, StmtPtr>, StmtPtr *, - std::random_access_iterator_tag, TPtr, - int, void, TPtr> { + std::random_access_iterator_tag, TPtr> { using Base = typename CastIterator::iterator_adaptor_base; CastIterator() : Base(nullptr) {} diff --git a/lib/Analysis/Consumed.cpp b/lib/Analysis/Consumed.cpp index c277177dc6..cde753e8ec 100644 --- a/lib/Analysis/Consumed.cpp +++ b/lib/Analysis/Consumed.cpp @@ -494,10 +494,8 @@ public: void checkCallability(const PropagationInfo &PInfo, const FunctionDecl *FunDecl, SourceLocation BlameLoc); - - using ArgRange = llvm::iterator_range<CallExpr::const_arg_iterator>; - bool handleCall(const Expr *Call, const Expr *ObjArg, - ArgRange args, const FunctionDecl *FunD); + bool handleCall(const CallExpr *Call, const Expr *ObjArg, + const FunctionDecl *FunD); void VisitBinaryOperator(const BinaryOperator *BinOp); void VisitCallExpr(const CallExpr *Call); @@ -610,21 +608,22 @@ void ConsumedStmtVisitor::checkCallability(const PropagationInfo &PInfo, // Factors out common behavior for function, method, and operator calls. // Check parameters and set parameter state if necessary. // Returns true if the state of ObjArg is set, or false otherwise. -bool ConsumedStmtVisitor::handleCall(const Expr *Call, - const Expr *ObjArg, - ArgRange Args, +bool ConsumedStmtVisitor::handleCall(const CallExpr *Call, const Expr *ObjArg, const FunctionDecl *FunD) { + unsigned Offset = 0; + if (isa<CXXOperatorCallExpr>(Call) && isa<CXXMethodDecl>(FunD)) + Offset = 1; // first argument is 'this' + // check explicit parameters - unsigned Index = 0; - for (const Expr *Arg : Args) { + for (unsigned Index = Offset; Index < Call->getNumArgs(); ++Index) { // Skip variable argument lists. - if (Index >= FunD->getNumParams()) + if (Index - Offset >= FunD->getNumParams()) break; - const ParmVarDecl *Param = FunD->getParamDecl(Index++); + const ParmVarDecl *Param = FunD->getParamDecl(Index - Offset); QualType ParamType = Param->getType(); - InfoEntry Entry = findInfo(Arg); + InfoEntry Entry = findInfo(Call->getArg(Index)); if (Entry == PropagationMap.end() || Entry->second.isTest()) continue; @@ -637,7 +636,7 @@ bool ConsumedStmtVisitor::handleCall(const Expr *Call, if (ParamState != ExpectedState) Analyzer.WarningsHandler.warnParamTypestateMismatch( - Arg->getExprLoc(), + Call->getArg(Index)->getExprLoc(), stateToString(ExpectedState), stateToString(ParamState)); } @@ -750,7 +749,7 @@ void ConsumedStmtVisitor::VisitCallExpr(const CallExpr *Call) { return; } - handleCall(Call, nullptr, Call->arguments(), FunDecl); + handleCall(Call, nullptr, FunDecl); propagateReturnType(Call, FunDecl); } @@ -806,7 +805,7 @@ void ConsumedStmtVisitor::VisitCXXMemberCallExpr( if (!MD) return; - handleCall(Call, Call->getImplicitObjectArgument(), Call->arguments(), MD); + handleCall(Call, Call->getImplicitObjectArgument(), MD); propagateReturnType(Call, MD); } @@ -814,20 +813,18 @@ void ConsumedStmtVisitor::VisitCXXOperatorCallExpr( const CXXOperatorCallExpr *Call) { const auto *FunDecl = dyn_cast_or_null<FunctionDecl>(Call->getDirectCallee()); if (!FunDecl) return; - ArgRange Args = Call->arguments(); if (Call->getOperator() == OO_Equal) { - ConsumedState CS = getInfo(llvm::index(Args, 1)); - if (!handleCall(Call, llvm::index(Args, 0), llvm::drop_begin(Args, 1), - FunDecl)) - setInfo(llvm::index(Args, 0), CS); + ConsumedState CS = getInfo(Call->getArg(1)); + if (!handleCall(Call, Call->getArg(0), FunDecl)) + setInfo(Call->getArg(0), CS); return; } - if (isa<CXXMethodDecl>(FunDecl)) - handleCall(Call, llvm::index(Args, 0), llvm::drop_begin(Args, 1), FunDecl); + if (const auto *MCall = dyn_cast<CXXMemberCallExpr>(Call)) + handleCall(MCall, MCall->getImplicitObjectArgument(), FunDecl); else - handleCall(Call, nullptr, Args, FunDecl); + handleCall(Call, Call->getArg(0), FunDecl); propagateReturnType(Call, FunDecl); } |