diff options
| author | Alex Langford <apl@fb.com> | 2019-01-16 00:09:50 +0000 |
|---|---|---|
| committer | Alex Langford <apl@fb.com> | 2019-01-16 00:09:50 +0000 |
| commit | af98187851cda5b796b3464c2b2f3f0340543fe1 (patch) | |
| tree | 8a4252ce121d19702f25ded0f73a92f84556a412 | |
| parent | 5cd5f06568cac10f94268c287f861392cab63d8d (diff) | |
[lldb-mi] Remove use of dialog box
Summary:
This really is only implemented on Windows, and it requires us to pull
in User32. This was only useful when debugging on lldb-mi on Windows, and there
doesn't seem to be a good reason why using a dialog box is better than what
exists for other platforms.
Reviewers: zturner, jingham, compnerd
Subscribers: ki.stfu
Differential Revision: https://reviews.llvm.org/D56755
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@351276 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | tools/lldb-mi/MIDriverMain.cpp | 4 | ||||
| -rw-r--r-- | tools/lldb-mi/MIUtilDebug.cpp | 19 | ||||
| -rw-r--r-- | tools/lldb-mi/MIUtilDebug.h | 1 |
3 files changed, 0 insertions, 24 deletions
diff --git a/tools/lldb-mi/MIDriverMain.cpp b/tools/lldb-mi/MIDriverMain.cpp index 4e4b92ca0..d347ecbbe 100644 --- a/tools/lldb-mi/MIDriverMain.cpp +++ b/tools/lldb-mi/MIDriverMain.cpp @@ -165,11 +165,7 @@ bool DriverSystemShutdown(const bool vbAppExitOk) { //-- int main(int argc, char const *argv[]) { #if MICONFIG_DEBUG_SHOW_ATTACH_DBG_DLG -#ifdef _WIN32 - CMIUtilDebug::ShowDlgWaitForDbgAttach(); -#else CMIUtilDebug::WaitForDbgAttachInfinteLoop(); -#endif // _WIN32 #endif // MICONFIG_DEBUG_SHOW_ATTACH_DBG_DLG llvm::StringRef ToolName = argv[0]; diff --git a/tools/lldb-mi/MIUtilDebug.cpp b/tools/lldb-mi/MIUtilDebug.cpp index 519fd950f..598a1a710 100644 --- a/tools/lldb-mi/MIUtilDebug.cpp +++ b/tools/lldb-mi/MIUtilDebug.cpp @@ -39,25 +39,6 @@ CMIUtilDebug::~CMIUtilDebug() {} //++ //------------------------------------------------------------------------------------ -// Details: Show a dialog to the process/application halts. It gives the -// opportunity to -// attach a debugger. -// Type: Static method. -// Args: None. -// Return: None. -// Throws: None. -//-- -void CMIUtilDebug::ShowDlgWaitForDbgAttach() { - const CMIUtilString strCaption(CMIDriver::Instance().GetAppNameShort()); -#ifdef _WIN32 - ::MessageBoxA(NULL, "Attach your debugger now", strCaption.c_str(), MB_OK); -#else -// ToDo: Implement other platform version of an Ok to continue dialog box -#endif // _WIN32 -} - -//++ -//------------------------------------------------------------------------------------ // Details: Temporarily stall the process/application to give the programmer the // opportunity to attach a debugger. How to use: Put a break in the // programmer diff --git a/tools/lldb-mi/MIUtilDebug.h b/tools/lldb-mi/MIUtilDebug.h index a49fd9a86..16b080ee7 100644 --- a/tools/lldb-mi/MIUtilDebug.h +++ b/tools/lldb-mi/MIUtilDebug.h @@ -24,7 +24,6 @@ class CMICmnLog; class CMIUtilDebug { // Statics: public: - static void ShowDlgWaitForDbgAttach(); static void WaitForDbgAttachInfinteLoop(); // Methods: |