Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 1 | /* |
| 2 | * Live block commit |
| 3 | * |
| 4 | * Copyright Red Hat, Inc. 2012 |
| 5 | * |
| 6 | * Authors: |
| 7 | * Jeff Cody <jcody@redhat.com> |
| 8 | * Based on stream.c by Stefan Hajnoczi |
| 9 | * |
| 10 | * This work is licensed under the terms of the GNU LGPL, version 2 or later. |
| 11 | * See the COPYING.LIB file in the top-level directory. |
| 12 | * |
| 13 | */ |
| 14 | |
Peter Maydell | 80c71a2 | 2016-01-18 18:01:42 +0000 | [diff] [blame] | 15 | #include "qemu/osdep.h" |
Kevin Wolf | dcbf37c | 2017-03-09 11:49:16 +0100 | [diff] [blame] | 16 | #include "qemu/cutils.h" |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 17 | #include "trace.h" |
Paolo Bonzini | 737e150 | 2012-12-17 18:19:44 +0100 | [diff] [blame] | 18 | #include "block/block_int.h" |
John Snow | c87621e | 2016-10-27 12:07:00 -0400 | [diff] [blame] | 19 | #include "block/blockjob_int.h" |
Markus Armbruster | da34e65 | 2016-03-14 09:01:28 +0100 | [diff] [blame] | 20 | #include "qapi/error.h" |
Markus Armbruster | cc7a8ea | 2015-03-17 17:22:46 +0100 | [diff] [blame] | 21 | #include "qapi/qmp/qerror.h" |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 22 | #include "qemu/ratelimit.h" |
Max Reitz | 373340b | 2015-10-19 17:53:22 +0200 | [diff] [blame] | 23 | #include "sysemu/block-backend.h" |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 24 | |
| 25 | enum { |
| 26 | /* |
| 27 | * Size of data buffer for populating the image file. This should be large |
| 28 | * enough to process multiple clusters in a single call, so that populating |
| 29 | * contiguous regions of the image is efficient. |
| 30 | */ |
| 31 | COMMIT_BUFFER_SIZE = 512 * 1024, /* in bytes */ |
| 32 | }; |
| 33 | |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 34 | typedef struct CommitBlockJob { |
| 35 | BlockJob common; |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 36 | BlockDriverState *commit_top_bs; |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 37 | BlockBackend *top; |
| 38 | BlockBackend *base; |
John Snow | 22dffcb | 2018-09-06 09:02:13 -0400 | [diff] [blame] | 39 | BlockDriverState *base_bs; |
Max Reitz | 9a71b9d | 2019-06-12 17:47:37 +0200 | [diff] [blame] | 40 | BlockDriverState *base_overlay; |
Paolo Bonzini | 92aa5c6 | 2012-09-28 17:22:55 +0200 | [diff] [blame] | 41 | BlockdevOnError on_error; |
Alberto Garcia | e70cdc5 | 2018-11-12 16:00:35 +0200 | [diff] [blame] | 42 | bool base_read_only; |
Alberto Garcia | df82733 | 2019-03-12 18:48:41 +0200 | [diff] [blame] | 43 | bool chain_frozen; |
Jeff Cody | 54e2690 | 2014-06-25 15:40:10 -0400 | [diff] [blame] | 44 | char *backing_file_str; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 45 | } CommitBlockJob; |
| 46 | |
John Snow | 22dffcb | 2018-09-06 09:02:13 -0400 | [diff] [blame] | 47 | static int commit_prepare(Job *job) |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 48 | { |
Kevin Wolf | 1908a55 | 2018-04-17 16:41:17 +0200 | [diff] [blame] | 49 | CommitBlockJob *s = container_of(job, CommitBlockJob, common.job); |
Kevin Wolf | 19ebd13 | 2017-06-02 23:04:55 +0200 | [diff] [blame] | 50 | |
Alberto Garcia | df82733 | 2019-03-12 18:48:41 +0200 | [diff] [blame] | 51 | bdrv_unfreeze_backing_chain(s->commit_top_bs, s->base_bs); |
| 52 | s->chain_frozen = false; |
| 53 | |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 54 | /* Remove base node parent that still uses BLK_PERM_WRITE/RESIZE before |
| 55 | * the normal backing chain can be restored. */ |
| 56 | blk_unref(s->base); |
John Snow | 22dffcb | 2018-09-06 09:02:13 -0400 | [diff] [blame] | 57 | s->base = NULL; |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 58 | |
John Snow | 22dffcb | 2018-09-06 09:02:13 -0400 | [diff] [blame] | 59 | /* FIXME: bdrv_drop_intermediate treats total failures and partial failures |
| 60 | * identically. Further work is needed to disambiguate these cases. */ |
| 61 | return bdrv_drop_intermediate(s->commit_top_bs, s->base_bs, |
| 62 | s->backing_file_str); |
| 63 | } |
| 64 | |
| 65 | static void commit_abort(Job *job) |
| 66 | { |
| 67 | CommitBlockJob *s = container_of(job, CommitBlockJob, common.job); |
| 68 | BlockDriverState *top_bs = blk_bs(s->top); |
| 69 | |
Alberto Garcia | df82733 | 2019-03-12 18:48:41 +0200 | [diff] [blame] | 70 | if (s->chain_frozen) { |
| 71 | bdrv_unfreeze_backing_chain(s->commit_top_bs, s->base_bs); |
| 72 | } |
| 73 | |
John Snow | 22dffcb | 2018-09-06 09:02:13 -0400 | [diff] [blame] | 74 | /* Make sure commit_top_bs and top stay around until bdrv_replace_node() */ |
| 75 | bdrv_ref(top_bs); |
| 76 | bdrv_ref(s->commit_top_bs); |
| 77 | |
| 78 | if (s->base) { |
| 79 | blk_unref(s->base); |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 80 | } |
| 81 | |
John Snow | 22dffcb | 2018-09-06 09:02:13 -0400 | [diff] [blame] | 82 | /* free the blockers on the intermediate nodes so that bdrv_replace_nodes |
| 83 | * can succeed */ |
| 84 | block_job_remove_all_bdrv(&s->common); |
| 85 | |
| 86 | /* If bdrv_drop_intermediate() failed (or was not invoked), remove the |
| 87 | * commit filter driver from the backing chain now. Do this as the final |
| 88 | * step so that the 'consistent read' permission can be granted. |
| 89 | * |
| 90 | * XXX Can (or should) we somehow keep 'consistent read' blocked even |
| 91 | * after the failed/cancelled commit job is gone? If we already wrote |
| 92 | * something to base, the intermediate images aren't valid any more. */ |
Max Reitz | 9a71b9d | 2019-06-12 17:47:37 +0200 | [diff] [blame] | 93 | bdrv_replace_node(s->commit_top_bs, s->commit_top_bs->backing->bs, |
John Snow | 22dffcb | 2018-09-06 09:02:13 -0400 | [diff] [blame] | 94 | &error_abort); |
| 95 | |
| 96 | bdrv_unref(s->commit_top_bs); |
| 97 | bdrv_unref(top_bs); |
| 98 | } |
| 99 | |
| 100 | static void commit_clean(Job *job) |
| 101 | { |
| 102 | CommitBlockJob *s = container_of(job, CommitBlockJob, common.job); |
| 103 | |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 104 | /* restore base open flags here if appropriate (e.g., change the base back |
| 105 | * to r/o). These reopens do not need to be atomic, since we won't abort |
| 106 | * even on failure here */ |
Alberto Garcia | e70cdc5 | 2018-11-12 16:00:35 +0200 | [diff] [blame] | 107 | if (s->base_read_only) { |
| 108 | bdrv_reopen_set_read_only(s->base_bs, true, NULL); |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 109 | } |
John Snow | 22dffcb | 2018-09-06 09:02:13 -0400 | [diff] [blame] | 110 | |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 111 | g_free(s->backing_file_str); |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 112 | blk_unref(s->top); |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 113 | } |
| 114 | |
John Snow | f67432a | 2018-08-29 21:57:26 -0400 | [diff] [blame] | 115 | static int coroutine_fn commit_run(Job *job, Error **errp) |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 116 | { |
John Snow | f67432a | 2018-08-29 21:57:26 -0400 | [diff] [blame] | 117 | CommitBlockJob *s = container_of(job, CommitBlockJob, common.job); |
Eric Blake | 317a667 | 2017-07-07 07:44:45 -0500 | [diff] [blame] | 118 | int64_t offset; |
Sascha Silbe | f14a39c | 2016-06-28 17:28:41 +0200 | [diff] [blame] | 119 | uint64_t delay_ns = 0; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 120 | int ret = 0; |
Eric Blake | 51b0a48 | 2017-07-07 07:44:59 -0500 | [diff] [blame] | 121 | int64_t n = 0; /* bytes */ |
Vladimir Sementsov-Ogievskiy | 7170170 | 2021-06-28 15:11:33 +0300 | [diff] [blame^] | 122 | QEMU_AUTO_VFREE void *buf = NULL; |
Kevin Wolf | 05df8a6 | 2018-01-18 18:08:22 +0100 | [diff] [blame] | 123 | int64_t len, base_len; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 124 | |
Vladimir Sementsov-Ogievskiy | 7170170 | 2021-06-28 15:11:33 +0300 | [diff] [blame^] | 125 | len = blk_getlength(s->top); |
Kevin Wolf | 05df8a6 | 2018-01-18 18:08:22 +0100 | [diff] [blame] | 126 | if (len < 0) { |
Vladimir Sementsov-Ogievskiy | 7170170 | 2021-06-28 15:11:33 +0300 | [diff] [blame^] | 127 | return len; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 128 | } |
Kevin Wolf | 30a5c88 | 2018-05-04 12:17:20 +0200 | [diff] [blame] | 129 | job_progress_set_remaining(&s->common.job, len); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 130 | |
Vladimir Sementsov-Ogievskiy | 7170170 | 2021-06-28 15:11:33 +0300 | [diff] [blame^] | 131 | base_len = blk_getlength(s->base); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 132 | if (base_len < 0) { |
Vladimir Sementsov-Ogievskiy | 7170170 | 2021-06-28 15:11:33 +0300 | [diff] [blame^] | 133 | return base_len; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 134 | } |
| 135 | |
Kevin Wolf | 05df8a6 | 2018-01-18 18:08:22 +0100 | [diff] [blame] | 136 | if (base_len < len) { |
Kevin Wolf | 8c6242b | 2020-04-24 14:54:41 +0200 | [diff] [blame] | 137 | ret = blk_truncate(s->base, len, false, PREALLOC_MODE_OFF, 0, NULL); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 138 | if (ret) { |
Vladimir Sementsov-Ogievskiy | 7170170 | 2021-06-28 15:11:33 +0300 | [diff] [blame^] | 139 | return ret; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 140 | } |
| 141 | } |
| 142 | |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 143 | buf = blk_blockalign(s->top, COMMIT_BUFFER_SIZE); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 144 | |
Kevin Wolf | 05df8a6 | 2018-01-18 18:08:22 +0100 | [diff] [blame] | 145 | for (offset = 0; offset < len; offset += n) { |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 146 | bool copy; |
Kevin Wolf | 9ad1e79 | 2020-02-14 21:08:10 +0100 | [diff] [blame] | 147 | bool error_in_source = true; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 148 | |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 149 | /* Note that even when no rate limit is applied we need to yield |
Kevin Wolf | c57b665 | 2012-11-13 16:35:13 +0100 | [diff] [blame] | 150 | * with no pending I/O here so that bdrv_drain_all() returns. |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 151 | */ |
Kevin Wolf | 5d43e86 | 2018-04-18 16:32:20 +0200 | [diff] [blame] | 152 | job_sleep_ns(&s->common.job, delay_ns); |
Kevin Wolf | daa7f2f | 2018-04-17 12:56:07 +0200 | [diff] [blame] | 153 | if (job_is_cancelled(&s->common.job)) { |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 154 | break; |
| 155 | } |
| 156 | /* Copy if allocated above the base */ |
Max Reitz | 9a71b9d | 2019-06-12 17:47:37 +0200 | [diff] [blame] | 157 | ret = bdrv_is_allocated_above(blk_bs(s->top), s->base_overlay, true, |
Eric Blake | 51b0a48 | 2017-07-07 07:44:59 -0500 | [diff] [blame] | 158 | offset, COMMIT_BUFFER_SIZE, &n); |
Eric Blake | a92b1b0 | 2020-10-27 00:05:53 -0500 | [diff] [blame] | 159 | copy = (ret > 0); |
Eric Blake | 51b0a48 | 2017-07-07 07:44:59 -0500 | [diff] [blame] | 160 | trace_commit_one_iteration(s, offset, n, ret); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 161 | if (copy) { |
Kevin Wolf | 0c42e17 | 2020-02-14 21:08:09 +0100 | [diff] [blame] | 162 | assert(n < SIZE_MAX); |
| 163 | |
| 164 | ret = blk_co_pread(s->top, offset, n, buf, 0); |
| 165 | if (ret >= 0) { |
| 166 | ret = blk_co_pwrite(s->base, offset, n, buf, 0); |
Kevin Wolf | 9ad1e79 | 2020-02-14 21:08:10 +0100 | [diff] [blame] | 167 | if (ret < 0) { |
| 168 | error_in_source = false; |
| 169 | } |
Kevin Wolf | 0c42e17 | 2020-02-14 21:08:09 +0100 | [diff] [blame] | 170 | } |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 171 | } |
| 172 | if (ret < 0) { |
Kevin Wolf | 1e8fb7f | 2016-06-29 17:38:57 +0200 | [diff] [blame] | 173 | BlockErrorAction action = |
Kevin Wolf | 9ad1e79 | 2020-02-14 21:08:10 +0100 | [diff] [blame] | 174 | block_job_error_action(&s->common, s->on_error, |
| 175 | error_in_source, -ret); |
Kevin Wolf | 1e8fb7f | 2016-06-29 17:38:57 +0200 | [diff] [blame] | 176 | if (action == BLOCK_ERROR_ACTION_REPORT) { |
Vladimir Sementsov-Ogievskiy | 7170170 | 2021-06-28 15:11:33 +0300 | [diff] [blame^] | 177 | return ret; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 178 | } else { |
| 179 | n = 0; |
| 180 | continue; |
| 181 | } |
| 182 | } |
| 183 | /* Publish progress */ |
Kevin Wolf | 30a5c88 | 2018-05-04 12:17:20 +0200 | [diff] [blame] | 184 | job_progress_update(&s->common.job, n); |
Sascha Silbe | f14a39c | 2016-06-28 17:28:41 +0200 | [diff] [blame] | 185 | |
Kevin Wolf | dee81d5 | 2018-01-18 21:19:38 +0100 | [diff] [blame] | 186 | if (copy) { |
| 187 | delay_ns = block_job_ratelimit_get_delay(&s->common, n); |
Kevin Wolf | 2fe4bba | 2018-01-18 21:23:52 +0100 | [diff] [blame] | 188 | } else { |
| 189 | delay_ns = 0; |
Sascha Silbe | f14a39c | 2016-06-28 17:28:41 +0200 | [diff] [blame] | 190 | } |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 191 | } |
| 192 | |
Vladimir Sementsov-Ogievskiy | 7170170 | 2021-06-28 15:11:33 +0300 | [diff] [blame^] | 193 | return 0; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 194 | } |
| 195 | |
Fam Zheng | 3fc4b10 | 2013-10-08 17:29:38 +0800 | [diff] [blame] | 196 | static const BlockJobDriver commit_job_driver = { |
Kevin Wolf | 33e9e9b | 2018-04-12 17:29:59 +0200 | [diff] [blame] | 197 | .job_driver = { |
| 198 | .instance_size = sizeof(CommitBlockJob), |
Kevin Wolf | 252291e | 2018-04-12 17:57:08 +0200 | [diff] [blame] | 199 | .job_type = JOB_TYPE_COMMIT, |
Kevin Wolf | 80fa2c7 | 2018-04-13 18:50:05 +0200 | [diff] [blame] | 200 | .free = block_job_free, |
Kevin Wolf | b15de82 | 2018-04-18 17:10:26 +0200 | [diff] [blame] | 201 | .user_resume = block_job_user_resume, |
John Snow | f67432a | 2018-08-29 21:57:26 -0400 | [diff] [blame] | 202 | .run = commit_run, |
John Snow | 22dffcb | 2018-09-06 09:02:13 -0400 | [diff] [blame] | 203 | .prepare = commit_prepare, |
| 204 | .abort = commit_abort, |
| 205 | .clean = commit_clean |
Kevin Wolf | 33e9e9b | 2018-04-12 17:29:59 +0200 | [diff] [blame] | 206 | }, |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 207 | }; |
| 208 | |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 209 | static int coroutine_fn bdrv_commit_top_preadv(BlockDriverState *bs, |
| 210 | uint64_t offset, uint64_t bytes, QEMUIOVector *qiov, int flags) |
| 211 | { |
| 212 | return bdrv_co_preadv(bs->backing, offset, bytes, qiov, flags); |
| 213 | } |
| 214 | |
Max Reitz | 998b3a1 | 2019-02-01 20:29:28 +0100 | [diff] [blame] | 215 | static void bdrv_commit_top_refresh_filename(BlockDriverState *bs) |
Kevin Wolf | dcbf37c | 2017-03-09 11:49:16 +0100 | [diff] [blame] | 216 | { |
Kevin Wolf | dcbf37c | 2017-03-09 11:49:16 +0100 | [diff] [blame] | 217 | pstrcpy(bs->exact_filename, sizeof(bs->exact_filename), |
| 218 | bs->backing->bs->filename); |
| 219 | } |
Kevin Wolf | 9196565 | 2017-03-08 15:07:12 +0100 | [diff] [blame] | 220 | |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 221 | static void bdrv_commit_top_child_perm(BlockDriverState *bs, BdrvChild *c, |
Max Reitz | bf8e925 | 2020-05-13 13:05:16 +0200 | [diff] [blame] | 222 | BdrvChildRole role, |
Kevin Wolf | e0995dc | 2017-09-14 12:47:11 +0200 | [diff] [blame] | 223 | BlockReopenQueue *reopen_queue, |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 224 | uint64_t perm, uint64_t shared, |
| 225 | uint64_t *nperm, uint64_t *nshared) |
| 226 | { |
| 227 | *nperm = 0; |
| 228 | *nshared = BLK_PERM_ALL; |
| 229 | } |
| 230 | |
| 231 | /* Dummy node that provides consistent read to its users without requiring it |
| 232 | * from its backing file and that allows writes on the backing file chain. */ |
| 233 | static BlockDriver bdrv_commit_top = { |
Kevin Wolf | 9196565 | 2017-03-08 15:07:12 +0100 | [diff] [blame] | 234 | .format_name = "commit_top", |
| 235 | .bdrv_co_preadv = bdrv_commit_top_preadv, |
Kevin Wolf | dcbf37c | 2017-03-09 11:49:16 +0100 | [diff] [blame] | 236 | .bdrv_refresh_filename = bdrv_commit_top_refresh_filename, |
Kevin Wolf | 9196565 | 2017-03-08 15:07:12 +0100 | [diff] [blame] | 237 | .bdrv_child_perm = bdrv_commit_top_child_perm, |
Max Reitz | 6540fd1 | 2020-05-13 13:05:11 +0200 | [diff] [blame] | 238 | |
| 239 | .is_filter = true, |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 240 | }; |
| 241 | |
Alberto Garcia | fd62c60 | 2016-07-05 17:29:00 +0300 | [diff] [blame] | 242 | void commit_start(const char *job_id, BlockDriverState *bs, |
John Snow | 5360782 | 2018-09-06 09:02:10 -0400 | [diff] [blame] | 243 | BlockDriverState *base, BlockDriverState *top, |
| 244 | int creation_flags, int64_t speed, |
John Snow | 8254b6d | 2016-10-27 12:06:58 -0400 | [diff] [blame] | 245 | BlockdevOnError on_error, const char *backing_file_str, |
Kevin Wolf | 0db832f | 2017-02-20 18:10:05 +0100 | [diff] [blame] | 246 | const char *filter_node_name, Error **errp) |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 247 | { |
| 248 | CommitBlockJob *s; |
Alberto Garcia | 3e4c512 | 2016-10-28 10:08:08 +0300 | [diff] [blame] | 249 | BlockDriverState *iter; |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 250 | BlockDriverState *commit_top_bs = NULL; |
Max Reitz | 9a71b9d | 2019-06-12 17:47:37 +0200 | [diff] [blame] | 251 | BlockDriverState *filtered_base; |
Max Reitz | 9a71b9d | 2019-06-12 17:47:37 +0200 | [diff] [blame] | 252 | int64_t base_size, top_size; |
| 253 | uint64_t base_perms, iter_shared_perms; |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 254 | int ret; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 255 | |
Fam Zheng | 18da7f9 | 2013-12-16 14:45:33 +0800 | [diff] [blame] | 256 | assert(top != bs); |
Max Reitz | 9a71b9d | 2019-06-12 17:47:37 +0200 | [diff] [blame] | 257 | if (bdrv_skip_filters(top) == bdrv_skip_filters(base)) { |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 258 | error_setg(errp, "Invalid files for merge: top and base are the same"); |
| 259 | return; |
| 260 | } |
| 261 | |
Max Reitz | 9a71b9d | 2019-06-12 17:47:37 +0200 | [diff] [blame] | 262 | base_size = bdrv_getlength(base); |
| 263 | if (base_size < 0) { |
| 264 | error_setg_errno(errp, -base_size, "Could not inquire base image size"); |
| 265 | return; |
| 266 | } |
| 267 | |
| 268 | top_size = bdrv_getlength(top); |
| 269 | if (top_size < 0) { |
| 270 | error_setg_errno(errp, -top_size, "Could not inquire top image size"); |
| 271 | return; |
| 272 | } |
| 273 | |
| 274 | base_perms = BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE; |
| 275 | if (base_size < top_size) { |
| 276 | base_perms |= BLK_PERM_RESIZE; |
| 277 | } |
| 278 | |
John Snow | 75859b9 | 2018-03-10 03:27:27 -0500 | [diff] [blame] | 279 | s = block_job_create(job_id, &commit_job_driver, NULL, bs, 0, BLK_PERM_ALL, |
John Snow | 5360782 | 2018-09-06 09:02:10 -0400 | [diff] [blame] | 280 | speed, creation_flags, NULL, NULL, errp); |
Alberto Garcia | 834fe28 | 2016-05-27 12:53:39 +0200 | [diff] [blame] | 281 | if (!s) { |
| 282 | return; |
| 283 | } |
| 284 | |
Kevin Wolf | bde7071 | 2017-06-27 20:36:18 +0200 | [diff] [blame] | 285 | /* convert base to r/w, if necessary */ |
Alberto Garcia | e70cdc5 | 2018-11-12 16:00:35 +0200 | [diff] [blame] | 286 | s->base_read_only = bdrv_is_read_only(base); |
| 287 | if (s->base_read_only) { |
| 288 | if (bdrv_reopen_set_read_only(base, false, errp) != 0) { |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 289 | goto fail; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 290 | } |
| 291 | } |
| 292 | |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 293 | /* Insert commit_top block node above top, so we can block consistent read |
| 294 | * on the backing chain below it */ |
Kevin Wolf | 0db832f | 2017-02-20 18:10:05 +0100 | [diff] [blame] | 295 | commit_top_bs = bdrv_new_open_driver(&bdrv_commit_top, filter_node_name, 0, |
| 296 | errp); |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 297 | if (commit_top_bs == NULL) { |
| 298 | goto fail; |
| 299 | } |
Kevin Wolf | d3c8c67 | 2017-07-18 17:24:05 +0200 | [diff] [blame] | 300 | if (!filter_node_name) { |
| 301 | commit_top_bs->implicit = true; |
| 302 | } |
Max Reitz | e5182c1 | 2019-07-03 19:28:02 +0200 | [diff] [blame] | 303 | |
| 304 | /* So that we can always drop this node */ |
| 305 | commit_top_bs->never_freeze = true; |
| 306 | |
Kevin Wolf | 0d0676a | 2017-04-06 19:07:14 +0200 | [diff] [blame] | 307 | commit_top_bs->total_sectors = top->total_sectors; |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 308 | |
Vladimir Sementsov-Ogievskiy | 934aee1 | 2021-02-02 15:49:44 +0300 | [diff] [blame] | 309 | ret = bdrv_append(commit_top_bs, top, errp); |
Vladimir Sementsov-Ogievskiy | ae9d441 | 2021-04-28 18:17:32 +0300 | [diff] [blame] | 310 | bdrv_unref(commit_top_bs); /* referenced by new parents or failed */ |
Vladimir Sementsov-Ogievskiy | 934aee1 | 2021-02-02 15:49:44 +0300 | [diff] [blame] | 311 | if (ret < 0) { |
Fam Zheng | b69f00d | 2017-03-07 19:07:22 +0800 | [diff] [blame] | 312 | commit_top_bs = NULL; |
Fam Zheng | b69f00d | 2017-03-07 19:07:22 +0800 | [diff] [blame] | 313 | goto fail; |
| 314 | } |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 315 | |
| 316 | s->commit_top_bs = commit_top_bs; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 317 | |
Max Reitz | 9a71b9d | 2019-06-12 17:47:37 +0200 | [diff] [blame] | 318 | /* |
| 319 | * Block all nodes between top and base, because they will |
| 320 | * disappear from the chain after this operation. |
| 321 | * Note that this assumes that the user is fine with removing all |
| 322 | * nodes (including R/W filters) between top and base. Assuring |
| 323 | * this is the responsibility of the interface (i.e. whoever calls |
| 324 | * commit_start()). |
| 325 | */ |
| 326 | s->base_overlay = bdrv_find_overlay(top, base); |
| 327 | assert(s->base_overlay); |
| 328 | |
| 329 | /* |
| 330 | * The topmost node with |
| 331 | * bdrv_skip_filters(filtered_base) == bdrv_skip_filters(base) |
| 332 | */ |
| 333 | filtered_base = bdrv_cow_bs(s->base_overlay); |
| 334 | assert(bdrv_skip_filters(filtered_base) == bdrv_skip_filters(base)); |
| 335 | |
| 336 | /* |
| 337 | * XXX BLK_PERM_WRITE needs to be allowed so we don't block ourselves |
| 338 | * at s->base (if writes are blocked for a node, they are also blocked |
| 339 | * for its backing file). The other options would be a second filter |
| 340 | * driver above s->base. |
| 341 | */ |
| 342 | iter_shared_perms = BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE; |
| 343 | |
| 344 | for (iter = top; iter != base; iter = bdrv_filter_or_cow_bs(iter)) { |
| 345 | if (iter == filtered_base) { |
| 346 | /* |
| 347 | * From here on, all nodes are filters on the base. This |
| 348 | * allows us to share BLK_PERM_CONSISTENT_READ. |
| 349 | */ |
| 350 | iter_shared_perms |= BLK_PERM_CONSISTENT_READ; |
| 351 | } |
| 352 | |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 353 | ret = block_job_add_bdrv(&s->common, "intermediate node", iter, 0, |
Max Reitz | 9a71b9d | 2019-06-12 17:47:37 +0200 | [diff] [blame] | 354 | iter_shared_perms, errp); |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 355 | if (ret < 0) { |
| 356 | goto fail; |
| 357 | } |
Alberto Garcia | 3e4c512 | 2016-10-28 10:08:08 +0300 | [diff] [blame] | 358 | } |
| 359 | |
Alberto Garcia | df82733 | 2019-03-12 18:48:41 +0200 | [diff] [blame] | 360 | if (bdrv_freeze_backing_chain(commit_top_bs, base, errp) < 0) { |
| 361 | goto fail; |
| 362 | } |
| 363 | s->chain_frozen = true; |
| 364 | |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 365 | ret = block_job_add_bdrv(&s->common, "base", base, 0, BLK_PERM_ALL, errp); |
| 366 | if (ret < 0) { |
| 367 | goto fail; |
| 368 | } |
| 369 | |
Kevin Wolf | d861ab3 | 2019-04-25 14:25:10 +0200 | [diff] [blame] | 370 | s->base = blk_new(s->common.job.aio_context, |
Max Reitz | 9a71b9d | 2019-06-12 17:47:37 +0200 | [diff] [blame] | 371 | base_perms, |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 372 | BLK_PERM_CONSISTENT_READ |
| 373 | | BLK_PERM_GRAPH_MOD |
| 374 | | BLK_PERM_WRITE_UNCHANGED); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 375 | ret = blk_insert_bs(s->base, base, errp); |
| 376 | if (ret < 0) { |
| 377 | goto fail; |
| 378 | } |
Kevin Wolf | cf31293 | 2019-07-22 17:46:23 +0200 | [diff] [blame] | 379 | blk_set_disable_request_queuing(s->base, true); |
John Snow | 22dffcb | 2018-09-06 09:02:13 -0400 | [diff] [blame] | 380 | s->base_bs = base; |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 381 | |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 382 | /* Required permissions are already taken with block_job_add_bdrv() */ |
Kevin Wolf | d861ab3 | 2019-04-25 14:25:10 +0200 | [diff] [blame] | 383 | s->top = blk_new(s->common.job.aio_context, 0, BLK_PERM_ALL); |
Kevin Wolf | b247767 | 2017-03-03 16:54:21 +0100 | [diff] [blame] | 384 | ret = blk_insert_bs(s->top, top, errp); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 385 | if (ret < 0) { |
| 386 | goto fail; |
| 387 | } |
Kevin Wolf | cf31293 | 2019-07-22 17:46:23 +0200 | [diff] [blame] | 388 | blk_set_disable_request_queuing(s->top, true); |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 389 | |
Jeff Cody | 54e2690 | 2014-06-25 15:40:10 -0400 | [diff] [blame] | 390 | s->backing_file_str = g_strdup(backing_file_str); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 391 | s->on_error = on_error; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 392 | |
John Snow | 5ccac6f | 2016-11-08 01:50:37 -0500 | [diff] [blame] | 393 | trace_commit_start(bs, base, top, s); |
Kevin Wolf | da01ff7 | 2018-04-13 17:31:02 +0200 | [diff] [blame] | 394 | job_start(&s->common.job); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 395 | return; |
| 396 | |
| 397 | fail: |
Alberto Garcia | df82733 | 2019-03-12 18:48:41 +0200 | [diff] [blame] | 398 | if (s->chain_frozen) { |
| 399 | bdrv_unfreeze_backing_chain(commit_top_bs, base); |
| 400 | } |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 401 | if (s->base) { |
| 402 | blk_unref(s->base); |
| 403 | } |
| 404 | if (s->top) { |
| 405 | blk_unref(s->top); |
| 406 | } |
Alberto Garcia | 065abf9 | 2019-04-29 15:51:08 +0200 | [diff] [blame] | 407 | if (s->base_read_only) { |
| 408 | bdrv_reopen_set_read_only(base, true, NULL); |
| 409 | } |
Alberto Garcia | 2468eed | 2019-02-15 15:49:32 +0200 | [diff] [blame] | 410 | job_early_fail(&s->common.job); |
| 411 | /* commit_top_bs has to be replaced after deleting the block job, |
| 412 | * otherwise this would fail because of lack of permissions. */ |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 413 | if (commit_top_bs) { |
Kevin Wolf | bde7071 | 2017-06-27 20:36:18 +0200 | [diff] [blame] | 414 | bdrv_replace_node(commit_top_bs, top, &error_abort); |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 415 | } |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 416 | } |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 417 | |
| 418 | |
Eric Blake | d6a644b | 2017-07-07 07:44:57 -0500 | [diff] [blame] | 419 | #define COMMIT_BUF_SIZE (2048 * BDRV_SECTOR_SIZE) |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 420 | |
| 421 | /* commit COW file into the raw image */ |
| 422 | int bdrv_commit(BlockDriverState *bs) |
| 423 | { |
Kevin Wolf | f8e2bd5 | 2016-05-30 16:29:47 +0200 | [diff] [blame] | 424 | BlockBackend *src, *backing; |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 425 | BlockDriverState *backing_file_bs = NULL; |
| 426 | BlockDriverState *commit_top_bs = NULL; |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 427 | BlockDriver *drv = bs->drv; |
Kevin Wolf | d861ab3 | 2019-04-25 14:25:10 +0200 | [diff] [blame] | 428 | AioContext *ctx; |
Eric Blake | d6a644b | 2017-07-07 07:44:57 -0500 | [diff] [blame] | 429 | int64_t offset, length, backing_length; |
Alberto Garcia | c742a36 | 2018-11-12 16:00:36 +0200 | [diff] [blame] | 430 | int ro; |
Eric Blake | d6a644b | 2017-07-07 07:44:57 -0500 | [diff] [blame] | 431 | int64_t n; |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 432 | int ret = 0; |
Vladimir Sementsov-Ogievskiy | 7170170 | 2021-06-28 15:11:33 +0300 | [diff] [blame^] | 433 | QEMU_AUTO_VFREE uint8_t *buf = NULL; |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 434 | Error *local_err = NULL; |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 435 | |
| 436 | if (!drv) |
| 437 | return -ENOMEDIUM; |
| 438 | |
Max Reitz | 9a71b9d | 2019-06-12 17:47:37 +0200 | [diff] [blame] | 439 | backing_file_bs = bdrv_cow_bs(bs); |
| 440 | |
| 441 | if (!backing_file_bs) { |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 442 | return -ENOTSUP; |
| 443 | } |
| 444 | |
| 445 | if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_COMMIT_SOURCE, NULL) || |
Max Reitz | 9a71b9d | 2019-06-12 17:47:37 +0200 | [diff] [blame] | 446 | bdrv_op_is_blocked(backing_file_bs, BLOCK_OP_TYPE_COMMIT_TARGET, NULL)) |
| 447 | { |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 448 | return -EBUSY; |
| 449 | } |
| 450 | |
Vladimir Sementsov-Ogievskiy | 307261b | 2021-05-27 18:40:54 +0300 | [diff] [blame] | 451 | ro = bdrv_is_read_only(backing_file_bs); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 452 | |
| 453 | if (ro) { |
Max Reitz | 9a71b9d | 2019-06-12 17:47:37 +0200 | [diff] [blame] | 454 | if (bdrv_reopen_set_read_only(backing_file_bs, false, NULL)) { |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 455 | return -EACCES; |
| 456 | } |
| 457 | } |
| 458 | |
Kevin Wolf | d861ab3 | 2019-04-25 14:25:10 +0200 | [diff] [blame] | 459 | ctx = bdrv_get_aio_context(bs); |
Max Reitz | 2d97fde | 2020-04-29 16:11:26 +0200 | [diff] [blame] | 460 | /* WRITE_UNCHANGED is required for bdrv_make_empty() */ |
| 461 | src = blk_new(ctx, BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE_UNCHANGED, |
| 462 | BLK_PERM_ALL); |
Kevin Wolf | d861ab3 | 2019-04-25 14:25:10 +0200 | [diff] [blame] | 463 | backing = blk_new(ctx, BLK_PERM_WRITE | BLK_PERM_RESIZE, BLK_PERM_ALL); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 464 | |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 465 | ret = blk_insert_bs(src, bs, &local_err); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 466 | if (ret < 0) { |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 467 | error_report_err(local_err); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 468 | goto ro_cleanup; |
| 469 | } |
| 470 | |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 471 | /* Insert commit_top block node above backing, so we can write to it */ |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 472 | commit_top_bs = bdrv_new_open_driver(&bdrv_commit_top, NULL, BDRV_O_RDWR, |
| 473 | &local_err); |
| 474 | if (commit_top_bs == NULL) { |
| 475 | error_report_err(local_err); |
| 476 | goto ro_cleanup; |
| 477 | } |
| 478 | |
Kevin Wolf | 12fa4af | 2017-02-17 20:42:32 +0100 | [diff] [blame] | 479 | bdrv_set_backing_hd(commit_top_bs, backing_file_bs, &error_abort); |
| 480 | bdrv_set_backing_hd(bs, commit_top_bs, &error_abort); |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 481 | |
| 482 | ret = blk_insert_bs(backing, backing_file_bs, &local_err); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 483 | if (ret < 0) { |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 484 | error_report_err(local_err); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 485 | goto ro_cleanup; |
| 486 | } |
Kevin Wolf | f8e2bd5 | 2016-05-30 16:29:47 +0200 | [diff] [blame] | 487 | |
| 488 | length = blk_getlength(src); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 489 | if (length < 0) { |
| 490 | ret = length; |
| 491 | goto ro_cleanup; |
| 492 | } |
| 493 | |
Kevin Wolf | f8e2bd5 | 2016-05-30 16:29:47 +0200 | [diff] [blame] | 494 | backing_length = blk_getlength(backing); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 495 | if (backing_length < 0) { |
| 496 | ret = backing_length; |
| 497 | goto ro_cleanup; |
| 498 | } |
| 499 | |
| 500 | /* If our top snapshot is larger than the backing file image, |
| 501 | * grow the backing file image if possible. If not possible, |
| 502 | * we must return an error */ |
| 503 | if (length > backing_length) { |
Kevin Wolf | 8c6242b | 2020-04-24 14:54:41 +0200 | [diff] [blame] | 504 | ret = blk_truncate(backing, length, false, PREALLOC_MODE_OFF, 0, |
Max Reitz | c80d8b0 | 2019-09-18 11:51:40 +0200 | [diff] [blame] | 505 | &local_err); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 506 | if (ret < 0) { |
Max Reitz | ed3d2ec | 2017-03-28 22:51:27 +0200 | [diff] [blame] | 507 | error_report_err(local_err); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 508 | goto ro_cleanup; |
| 509 | } |
| 510 | } |
| 511 | |
Kevin Wolf | f8e2bd5 | 2016-05-30 16:29:47 +0200 | [diff] [blame] | 512 | /* blk_try_blockalign() for src will choose an alignment that works for |
| 513 | * backing as well, so no need to compare the alignment manually. */ |
Eric Blake | d6a644b | 2017-07-07 07:44:57 -0500 | [diff] [blame] | 514 | buf = blk_try_blockalign(src, COMMIT_BUF_SIZE); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 515 | if (buf == NULL) { |
| 516 | ret = -ENOMEM; |
| 517 | goto ro_cleanup; |
| 518 | } |
| 519 | |
Eric Blake | d6a644b | 2017-07-07 07:44:57 -0500 | [diff] [blame] | 520 | for (offset = 0; offset < length; offset += n) { |
| 521 | ret = bdrv_is_allocated(bs, offset, COMMIT_BUF_SIZE, &n); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 522 | if (ret < 0) { |
| 523 | goto ro_cleanup; |
| 524 | } |
| 525 | if (ret) { |
Eric Blake | d6a644b | 2017-07-07 07:44:57 -0500 | [diff] [blame] | 526 | ret = blk_pread(src, offset, buf, n); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 527 | if (ret < 0) { |
| 528 | goto ro_cleanup; |
| 529 | } |
| 530 | |
Eric Blake | d6a644b | 2017-07-07 07:44:57 -0500 | [diff] [blame] | 531 | ret = blk_pwrite(backing, offset, buf, n, 0); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 532 | if (ret < 0) { |
| 533 | goto ro_cleanup; |
| 534 | } |
| 535 | } |
| 536 | } |
| 537 | |
Max Reitz | 2d97fde | 2020-04-29 16:11:26 +0200 | [diff] [blame] | 538 | ret = blk_make_empty(src, NULL); |
| 539 | /* Ignore -ENOTSUP */ |
| 540 | if (ret < 0 && ret != -ENOTSUP) { |
| 541 | goto ro_cleanup; |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 542 | } |
| 543 | |
Max Reitz | 2d97fde | 2020-04-29 16:11:26 +0200 | [diff] [blame] | 544 | blk_flush(src); |
| 545 | |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 546 | /* |
| 547 | * Make sure all data we wrote to the backing device is actually |
| 548 | * stable on disk. |
| 549 | */ |
Kevin Wolf | f8e2bd5 | 2016-05-30 16:29:47 +0200 | [diff] [blame] | 550 | blk_flush(backing); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 551 | |
| 552 | ret = 0; |
| 553 | ro_cleanup: |
Kevin Wolf | f8e2bd5 | 2016-05-30 16:29:47 +0200 | [diff] [blame] | 554 | blk_unref(backing); |
Max Reitz | 9a71b9d | 2019-06-12 17:47:37 +0200 | [diff] [blame] | 555 | if (bdrv_cow_bs(bs) != backing_file_bs) { |
Kevin Wolf | 12fa4af | 2017-02-17 20:42:32 +0100 | [diff] [blame] | 556 | bdrv_set_backing_hd(bs, backing_file_bs, &error_abort); |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 557 | } |
| 558 | bdrv_unref(commit_top_bs); |
| 559 | blk_unref(src); |
Kevin Wolf | f8e2bd5 | 2016-05-30 16:29:47 +0200 | [diff] [blame] | 560 | |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 561 | if (ro) { |
| 562 | /* ignoring error return here */ |
Max Reitz | 9a71b9d | 2019-06-12 17:47:37 +0200 | [diff] [blame] | 563 | bdrv_reopen_set_read_only(backing_file_bs, true, NULL); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 564 | } |
| 565 | |
| 566 | return ret; |
| 567 | } |