Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 1 | /* |
| 2 | * Live block commit |
| 3 | * |
| 4 | * Copyright Red Hat, Inc. 2012 |
| 5 | * |
| 6 | * Authors: |
| 7 | * Jeff Cody <jcody@redhat.com> |
| 8 | * Based on stream.c by Stefan Hajnoczi |
| 9 | * |
| 10 | * This work is licensed under the terms of the GNU LGPL, version 2 or later. |
| 11 | * See the COPYING.LIB file in the top-level directory. |
| 12 | * |
| 13 | */ |
| 14 | |
Peter Maydell | 80c71a2 | 2016-01-18 18:01:42 +0000 | [diff] [blame] | 15 | #include "qemu/osdep.h" |
Kevin Wolf | dcbf37c | 2017-03-09 11:49:16 +0100 | [diff] [blame] | 16 | #include "qemu/cutils.h" |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 17 | #include "trace.h" |
Paolo Bonzini | 737e150 | 2012-12-17 18:19:44 +0100 | [diff] [blame] | 18 | #include "block/block_int.h" |
John Snow | c87621e | 2016-10-27 12:07:00 -0400 | [diff] [blame] | 19 | #include "block/blockjob_int.h" |
Markus Armbruster | da34e65 | 2016-03-14 09:01:28 +0100 | [diff] [blame] | 20 | #include "qapi/error.h" |
Markus Armbruster | cc7a8ea | 2015-03-17 17:22:46 +0100 | [diff] [blame] | 21 | #include "qapi/qmp/qerror.h" |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 22 | #include "qemu/ratelimit.h" |
Max Reitz | 373340b | 2015-10-19 17:53:22 +0200 | [diff] [blame] | 23 | #include "sysemu/block-backend.h" |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 24 | |
| 25 | enum { |
| 26 | /* |
| 27 | * Size of data buffer for populating the image file. This should be large |
| 28 | * enough to process multiple clusters in a single call, so that populating |
| 29 | * contiguous regions of the image is efficient. |
| 30 | */ |
| 31 | COMMIT_BUFFER_SIZE = 512 * 1024, /* in bytes */ |
| 32 | }; |
| 33 | |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 34 | typedef struct CommitBlockJob { |
| 35 | BlockJob common; |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 36 | BlockDriverState *commit_top_bs; |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 37 | BlockBackend *top; |
| 38 | BlockBackend *base; |
Paolo Bonzini | 92aa5c6 | 2012-09-28 17:22:55 +0200 | [diff] [blame] | 39 | BlockdevOnError on_error; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 40 | int base_flags; |
Jeff Cody | 54e2690 | 2014-06-25 15:40:10 -0400 | [diff] [blame] | 41 | char *backing_file_str; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 42 | } CommitBlockJob; |
| 43 | |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 44 | static int coroutine_fn commit_populate(BlockBackend *bs, BlockBackend *base, |
Eric Blake | d8a9858 | 2017-07-07 07:44:44 -0500 | [diff] [blame] | 45 | int64_t offset, uint64_t bytes, |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 46 | void *buf) |
| 47 | { |
| 48 | int ret = 0; |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 49 | QEMUIOVector qiov; |
| 50 | struct iovec iov = { |
| 51 | .iov_base = buf, |
Eric Blake | d8a9858 | 2017-07-07 07:44:44 -0500 | [diff] [blame] | 52 | .iov_len = bytes, |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 53 | }; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 54 | |
Eric Blake | d8a9858 | 2017-07-07 07:44:44 -0500 | [diff] [blame] | 55 | assert(bytes < SIZE_MAX); |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 56 | qemu_iovec_init_external(&qiov, &iov, 1); |
| 57 | |
Eric Blake | d8a9858 | 2017-07-07 07:44:44 -0500 | [diff] [blame] | 58 | ret = blk_co_preadv(bs, offset, qiov.size, &qiov, 0); |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 59 | if (ret < 0) { |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 60 | return ret; |
| 61 | } |
| 62 | |
Eric Blake | d8a9858 | 2017-07-07 07:44:44 -0500 | [diff] [blame] | 63 | ret = blk_co_pwritev(base, offset, qiov.size, &qiov, 0); |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 64 | if (ret < 0) { |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 65 | return ret; |
| 66 | } |
| 67 | |
| 68 | return 0; |
| 69 | } |
| 70 | |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 71 | typedef struct { |
| 72 | int ret; |
| 73 | } CommitCompleteData; |
| 74 | |
Kevin Wolf | 1908a55 | 2018-04-17 16:41:17 +0200 | [diff] [blame] | 75 | static void commit_complete(Job *job, void *opaque) |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 76 | { |
Kevin Wolf | 1908a55 | 2018-04-17 16:41:17 +0200 | [diff] [blame] | 77 | CommitBlockJob *s = container_of(job, CommitBlockJob, common.job); |
| 78 | BlockJob *bjob = &s->common; |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 79 | CommitCompleteData *data = opaque; |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 80 | BlockDriverState *top = blk_bs(s->top); |
| 81 | BlockDriverState *base = blk_bs(s->base); |
Kevin Wolf | bde7071 | 2017-06-27 20:36:18 +0200 | [diff] [blame] | 82 | BlockDriverState *commit_top_bs = s->commit_top_bs; |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 83 | int ret = data->ret; |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 84 | bool remove_commit_top_bs = false; |
| 85 | |
Kevin Wolf | bde7071 | 2017-06-27 20:36:18 +0200 | [diff] [blame] | 86 | /* Make sure commit_top_bs and top stay around until bdrv_replace_node() */ |
Kevin Wolf | 19ebd13 | 2017-06-02 23:04:55 +0200 | [diff] [blame] | 87 | bdrv_ref(top); |
Kevin Wolf | bde7071 | 2017-06-27 20:36:18 +0200 | [diff] [blame] | 88 | bdrv_ref(commit_top_bs); |
Kevin Wolf | 19ebd13 | 2017-06-02 23:04:55 +0200 | [diff] [blame] | 89 | |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 90 | /* Remove base node parent that still uses BLK_PERM_WRITE/RESIZE before |
| 91 | * the normal backing chain can be restored. */ |
| 92 | blk_unref(s->base); |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 93 | |
Kevin Wolf | 1908a55 | 2018-04-17 16:41:17 +0200 | [diff] [blame] | 94 | if (!job_is_cancelled(job) && ret == 0) { |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 95 | /* success */ |
Kevin Wolf | bde7071 | 2017-06-27 20:36:18 +0200 | [diff] [blame] | 96 | ret = bdrv_drop_intermediate(s->commit_top_bs, base, |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 97 | s->backing_file_str); |
Kevin Wolf | bde7071 | 2017-06-27 20:36:18 +0200 | [diff] [blame] | 98 | } else { |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 99 | /* XXX Can (or should) we somehow keep 'consistent read' blocked even |
| 100 | * after the failed/cancelled commit job is gone? If we already wrote |
| 101 | * something to base, the intermediate images aren't valid any more. */ |
| 102 | remove_commit_top_bs = true; |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 103 | } |
| 104 | |
| 105 | /* restore base open flags here if appropriate (e.g., change the base back |
| 106 | * to r/o). These reopens do not need to be atomic, since we won't abort |
| 107 | * even on failure here */ |
| 108 | if (s->base_flags != bdrv_get_flags(base)) { |
| 109 | bdrv_reopen(base, s->base_flags, NULL); |
| 110 | } |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 111 | g_free(s->backing_file_str); |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 112 | blk_unref(s->top); |
Kevin Wolf | 4f78a16 | 2017-06-09 13:29:36 +0200 | [diff] [blame] | 113 | |
| 114 | /* If there is more than one reference to the job (e.g. if called from |
Kevin Wolf | 3d70ff5 | 2018-04-24 16:13:52 +0200 | [diff] [blame] | 115 | * job_finish_sync()), job_completed() won't free it and therefore the |
| 116 | * blockers on the intermediate nodes remain. This would cause |
Kevin Wolf | 6a74c07 | 2018-04-20 15:33:57 +0200 | [diff] [blame] | 117 | * bdrv_set_backing_hd() to fail. */ |
Kevin Wolf | 1908a55 | 2018-04-17 16:41:17 +0200 | [diff] [blame] | 118 | block_job_remove_all_bdrv(bjob); |
Kevin Wolf | 4f78a16 | 2017-06-09 13:29:36 +0200 | [diff] [blame] | 119 | |
Kevin Wolf | 1266c9b | 2018-05-24 15:26:10 +0200 | [diff] [blame] | 120 | job_completed(job, ret, NULL); |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 121 | g_free(data); |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 122 | |
| 123 | /* If bdrv_drop_intermediate() didn't already do that, remove the commit |
| 124 | * filter driver from the backing chain. Do this as the final step so that |
| 125 | * the 'consistent read' permission can be granted. */ |
| 126 | if (remove_commit_top_bs) { |
Kevin Wolf | bde7071 | 2017-06-27 20:36:18 +0200 | [diff] [blame] | 127 | bdrv_child_try_set_perm(commit_top_bs->backing, 0, BLK_PERM_ALL, |
| 128 | &error_abort); |
| 129 | bdrv_replace_node(commit_top_bs, backing_bs(commit_top_bs), |
| 130 | &error_abort); |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 131 | } |
Kevin Wolf | 19ebd13 | 2017-06-02 23:04:55 +0200 | [diff] [blame] | 132 | |
Kevin Wolf | bde7071 | 2017-06-27 20:36:18 +0200 | [diff] [blame] | 133 | bdrv_unref(commit_top_bs); |
Kevin Wolf | 19ebd13 | 2017-06-02 23:04:55 +0200 | [diff] [blame] | 134 | bdrv_unref(top); |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 135 | } |
| 136 | |
John Snow | f67432a | 2018-08-29 21:57:26 -0400 | [diff] [blame^] | 137 | static int coroutine_fn commit_run(Job *job, Error **errp) |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 138 | { |
John Snow | f67432a | 2018-08-29 21:57:26 -0400 | [diff] [blame^] | 139 | CommitBlockJob *s = container_of(job, CommitBlockJob, common.job); |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 140 | CommitCompleteData *data; |
Eric Blake | 317a667 | 2017-07-07 07:44:45 -0500 | [diff] [blame] | 141 | int64_t offset; |
Sascha Silbe | f14a39c | 2016-06-28 17:28:41 +0200 | [diff] [blame] | 142 | uint64_t delay_ns = 0; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 143 | int ret = 0; |
Eric Blake | 51b0a48 | 2017-07-07 07:44:59 -0500 | [diff] [blame] | 144 | int64_t n = 0; /* bytes */ |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 145 | void *buf = NULL; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 146 | int bytes_written = 0; |
Kevin Wolf | 05df8a6 | 2018-01-18 18:08:22 +0100 | [diff] [blame] | 147 | int64_t len, base_len; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 148 | |
Kevin Wolf | 05df8a6 | 2018-01-18 18:08:22 +0100 | [diff] [blame] | 149 | ret = len = blk_getlength(s->top); |
| 150 | if (len < 0) { |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 151 | goto out; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 152 | } |
Kevin Wolf | 30a5c88 | 2018-05-04 12:17:20 +0200 | [diff] [blame] | 153 | job_progress_set_remaining(&s->common.job, len); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 154 | |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 155 | ret = base_len = blk_getlength(s->base); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 156 | if (base_len < 0) { |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 157 | goto out; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 158 | } |
| 159 | |
Kevin Wolf | 05df8a6 | 2018-01-18 18:08:22 +0100 | [diff] [blame] | 160 | if (base_len < len) { |
| 161 | ret = blk_truncate(s->base, len, PREALLOC_MODE_OFF, NULL); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 162 | if (ret) { |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 163 | goto out; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 164 | } |
| 165 | } |
| 166 | |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 167 | buf = blk_blockalign(s->top, COMMIT_BUFFER_SIZE); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 168 | |
Kevin Wolf | 05df8a6 | 2018-01-18 18:08:22 +0100 | [diff] [blame] | 169 | for (offset = 0; offset < len; offset += n) { |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 170 | bool copy; |
| 171 | |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 172 | /* Note that even when no rate limit is applied we need to yield |
Kevin Wolf | c57b665 | 2012-11-13 16:35:13 +0100 | [diff] [blame] | 173 | * with no pending I/O here so that bdrv_drain_all() returns. |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 174 | */ |
Kevin Wolf | 5d43e86 | 2018-04-18 16:32:20 +0200 | [diff] [blame] | 175 | job_sleep_ns(&s->common.job, delay_ns); |
Kevin Wolf | daa7f2f | 2018-04-17 12:56:07 +0200 | [diff] [blame] | 176 | if (job_is_cancelled(&s->common.job)) { |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 177 | break; |
| 178 | } |
| 179 | /* Copy if allocated above the base */ |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 180 | ret = bdrv_is_allocated_above(blk_bs(s->top), blk_bs(s->base), |
Eric Blake | 51b0a48 | 2017-07-07 07:44:59 -0500 | [diff] [blame] | 181 | offset, COMMIT_BUFFER_SIZE, &n); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 182 | copy = (ret == 1); |
Eric Blake | 51b0a48 | 2017-07-07 07:44:59 -0500 | [diff] [blame] | 183 | trace_commit_one_iteration(s, offset, n, ret); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 184 | if (copy) { |
Eric Blake | 51b0a48 | 2017-07-07 07:44:59 -0500 | [diff] [blame] | 185 | ret = commit_populate(s->top, s->base, offset, n, buf); |
| 186 | bytes_written += n; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 187 | } |
| 188 | if (ret < 0) { |
Kevin Wolf | 1e8fb7f | 2016-06-29 17:38:57 +0200 | [diff] [blame] | 189 | BlockErrorAction action = |
| 190 | block_job_error_action(&s->common, false, s->on_error, -ret); |
| 191 | if (action == BLOCK_ERROR_ACTION_REPORT) { |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 192 | goto out; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 193 | } else { |
| 194 | n = 0; |
| 195 | continue; |
| 196 | } |
| 197 | } |
| 198 | /* Publish progress */ |
Kevin Wolf | 30a5c88 | 2018-05-04 12:17:20 +0200 | [diff] [blame] | 199 | job_progress_update(&s->common.job, n); |
Sascha Silbe | f14a39c | 2016-06-28 17:28:41 +0200 | [diff] [blame] | 200 | |
Kevin Wolf | dee81d5 | 2018-01-18 21:19:38 +0100 | [diff] [blame] | 201 | if (copy) { |
| 202 | delay_ns = block_job_ratelimit_get_delay(&s->common, n); |
Kevin Wolf | 2fe4bba | 2018-01-18 21:23:52 +0100 | [diff] [blame] | 203 | } else { |
| 204 | delay_ns = 0; |
Sascha Silbe | f14a39c | 2016-06-28 17:28:41 +0200 | [diff] [blame] | 205 | } |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 206 | } |
| 207 | |
| 208 | ret = 0; |
| 209 | |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 210 | out: |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 211 | qemu_vfree(buf); |
| 212 | |
Stefan Hajnoczi | 9e85cd5 | 2014-10-21 12:03:59 +0100 | [diff] [blame] | 213 | data = g_malloc(sizeof(*data)); |
| 214 | data->ret = ret; |
Kevin Wolf | 1908a55 | 2018-04-17 16:41:17 +0200 | [diff] [blame] | 215 | job_defer_to_main_loop(&s->common.job, commit_complete, data); |
John Snow | f67432a | 2018-08-29 21:57:26 -0400 | [diff] [blame^] | 216 | return ret; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 217 | } |
| 218 | |
Fam Zheng | 3fc4b10 | 2013-10-08 17:29:38 +0800 | [diff] [blame] | 219 | static const BlockJobDriver commit_job_driver = { |
Kevin Wolf | 33e9e9b | 2018-04-12 17:29:59 +0200 | [diff] [blame] | 220 | .job_driver = { |
| 221 | .instance_size = sizeof(CommitBlockJob), |
Kevin Wolf | 252291e | 2018-04-12 17:57:08 +0200 | [diff] [blame] | 222 | .job_type = JOB_TYPE_COMMIT, |
Kevin Wolf | 80fa2c7 | 2018-04-13 18:50:05 +0200 | [diff] [blame] | 223 | .free = block_job_free, |
Kevin Wolf | b15de82 | 2018-04-18 17:10:26 +0200 | [diff] [blame] | 224 | .user_resume = block_job_user_resume, |
Kevin Wolf | b69f777 | 2018-04-20 17:00:29 +0200 | [diff] [blame] | 225 | .drain = block_job_drain, |
John Snow | f67432a | 2018-08-29 21:57:26 -0400 | [diff] [blame^] | 226 | .run = commit_run, |
Kevin Wolf | 33e9e9b | 2018-04-12 17:29:59 +0200 | [diff] [blame] | 227 | }, |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 228 | }; |
| 229 | |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 230 | static int coroutine_fn bdrv_commit_top_preadv(BlockDriverState *bs, |
| 231 | uint64_t offset, uint64_t bytes, QEMUIOVector *qiov, int flags) |
| 232 | { |
| 233 | return bdrv_co_preadv(bs->backing, offset, bytes, qiov, flags); |
| 234 | } |
| 235 | |
Kevin Wolf | dcbf37c | 2017-03-09 11:49:16 +0100 | [diff] [blame] | 236 | static void bdrv_commit_top_refresh_filename(BlockDriverState *bs, QDict *opts) |
| 237 | { |
| 238 | bdrv_refresh_filename(bs->backing->bs); |
| 239 | pstrcpy(bs->exact_filename, sizeof(bs->exact_filename), |
| 240 | bs->backing->bs->filename); |
| 241 | } |
Kevin Wolf | 9196565 | 2017-03-08 15:07:12 +0100 | [diff] [blame] | 242 | |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 243 | static void bdrv_commit_top_child_perm(BlockDriverState *bs, BdrvChild *c, |
| 244 | const BdrvChildRole *role, |
Kevin Wolf | e0995dc | 2017-09-14 12:47:11 +0200 | [diff] [blame] | 245 | BlockReopenQueue *reopen_queue, |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 246 | uint64_t perm, uint64_t shared, |
| 247 | uint64_t *nperm, uint64_t *nshared) |
| 248 | { |
| 249 | *nperm = 0; |
| 250 | *nshared = BLK_PERM_ALL; |
| 251 | } |
| 252 | |
| 253 | /* Dummy node that provides consistent read to its users without requiring it |
| 254 | * from its backing file and that allows writes on the backing file chain. */ |
| 255 | static BlockDriver bdrv_commit_top = { |
Kevin Wolf | 9196565 | 2017-03-08 15:07:12 +0100 | [diff] [blame] | 256 | .format_name = "commit_top", |
| 257 | .bdrv_co_preadv = bdrv_commit_top_preadv, |
Eric Blake | 3e4d0e7 | 2018-02-13 14:26:43 -0600 | [diff] [blame] | 258 | .bdrv_co_block_status = bdrv_co_block_status_from_backing, |
Kevin Wolf | dcbf37c | 2017-03-09 11:49:16 +0100 | [diff] [blame] | 259 | .bdrv_refresh_filename = bdrv_commit_top_refresh_filename, |
Kevin Wolf | 9196565 | 2017-03-08 15:07:12 +0100 | [diff] [blame] | 260 | .bdrv_child_perm = bdrv_commit_top_child_perm, |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 261 | }; |
| 262 | |
Alberto Garcia | fd62c60 | 2016-07-05 17:29:00 +0300 | [diff] [blame] | 263 | void commit_start(const char *job_id, BlockDriverState *bs, |
| 264 | BlockDriverState *base, BlockDriverState *top, int64_t speed, |
John Snow | 8254b6d | 2016-10-27 12:06:58 -0400 | [diff] [blame] | 265 | BlockdevOnError on_error, const char *backing_file_str, |
Kevin Wolf | 0db832f | 2017-02-20 18:10:05 +0100 | [diff] [blame] | 266 | const char *filter_node_name, Error **errp) |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 267 | { |
| 268 | CommitBlockJob *s; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 269 | int orig_base_flags; |
Alberto Garcia | 3e4c512 | 2016-10-28 10:08:08 +0300 | [diff] [blame] | 270 | BlockDriverState *iter; |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 271 | BlockDriverState *commit_top_bs = NULL; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 272 | Error *local_err = NULL; |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 273 | int ret; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 274 | |
Fam Zheng | 18da7f9 | 2013-12-16 14:45:33 +0800 | [diff] [blame] | 275 | assert(top != bs); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 276 | if (top == base) { |
| 277 | error_setg(errp, "Invalid files for merge: top and base are the same"); |
| 278 | return; |
| 279 | } |
| 280 | |
John Snow | 75859b9 | 2018-03-10 03:27:27 -0500 | [diff] [blame] | 281 | s = block_job_create(job_id, &commit_job_driver, NULL, bs, 0, BLK_PERM_ALL, |
Kevin Wolf | bb02b65 | 2018-04-19 17:54:56 +0200 | [diff] [blame] | 282 | speed, JOB_DEFAULT, NULL, NULL, errp); |
Alberto Garcia | 834fe28 | 2016-05-27 12:53:39 +0200 | [diff] [blame] | 283 | if (!s) { |
| 284 | return; |
| 285 | } |
| 286 | |
Kevin Wolf | bde7071 | 2017-06-27 20:36:18 +0200 | [diff] [blame] | 287 | /* convert base to r/w, if necessary */ |
| 288 | orig_base_flags = bdrv_get_flags(base); |
Alberto Garcia | 3db2bd5 | 2015-10-28 15:43:49 +0200 | [diff] [blame] | 289 | if (!(orig_base_flags & BDRV_O_RDWR)) { |
Kevin Wolf | 44487eb | 2017-12-06 13:53:36 +0100 | [diff] [blame] | 290 | bdrv_reopen(base, orig_base_flags | BDRV_O_RDWR, &local_err); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 291 | if (local_err != NULL) { |
| 292 | error_propagate(errp, local_err); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 293 | goto fail; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 294 | } |
| 295 | } |
| 296 | |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 297 | /* Insert commit_top block node above top, so we can block consistent read |
| 298 | * on the backing chain below it */ |
Kevin Wolf | 0db832f | 2017-02-20 18:10:05 +0100 | [diff] [blame] | 299 | commit_top_bs = bdrv_new_open_driver(&bdrv_commit_top, filter_node_name, 0, |
| 300 | errp); |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 301 | if (commit_top_bs == NULL) { |
| 302 | goto fail; |
| 303 | } |
Kevin Wolf | d3c8c67 | 2017-07-18 17:24:05 +0200 | [diff] [blame] | 304 | if (!filter_node_name) { |
| 305 | commit_top_bs->implicit = true; |
| 306 | } |
Kevin Wolf | 0d0676a | 2017-04-06 19:07:14 +0200 | [diff] [blame] | 307 | commit_top_bs->total_sectors = top->total_sectors; |
Kevin Wolf | 02be4ae | 2017-04-06 19:05:07 +0200 | [diff] [blame] | 308 | bdrv_set_aio_context(commit_top_bs, bdrv_get_aio_context(top)); |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 309 | |
Fam Zheng | b69f00d | 2017-03-07 19:07:22 +0800 | [diff] [blame] | 310 | bdrv_set_backing_hd(commit_top_bs, top, &local_err); |
| 311 | if (local_err) { |
| 312 | bdrv_unref(commit_top_bs); |
| 313 | commit_top_bs = NULL; |
| 314 | error_propagate(errp, local_err); |
| 315 | goto fail; |
| 316 | } |
Kevin Wolf | 61f09ce | 2017-09-19 16:22:54 +0200 | [diff] [blame] | 317 | bdrv_replace_node(top, commit_top_bs, &local_err); |
Fam Zheng | b69f00d | 2017-03-07 19:07:22 +0800 | [diff] [blame] | 318 | if (local_err) { |
| 319 | bdrv_unref(commit_top_bs); |
| 320 | commit_top_bs = NULL; |
| 321 | error_propagate(errp, local_err); |
| 322 | goto fail; |
| 323 | } |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 324 | |
| 325 | s->commit_top_bs = commit_top_bs; |
| 326 | bdrv_unref(commit_top_bs); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 327 | |
Alberto Garcia | 3e4c512 | 2016-10-28 10:08:08 +0300 | [diff] [blame] | 328 | /* Block all nodes between top and base, because they will |
| 329 | * disappear from the chain after this operation. */ |
| 330 | assert(bdrv_chain_contains(top, base)); |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 331 | for (iter = top; iter != base; iter = backing_bs(iter)) { |
| 332 | /* XXX BLK_PERM_WRITE needs to be allowed so we don't block ourselves |
| 333 | * at s->base (if writes are blocked for a node, they are also blocked |
| 334 | * for its backing file). The other options would be a second filter |
| 335 | * driver above s->base. */ |
| 336 | ret = block_job_add_bdrv(&s->common, "intermediate node", iter, 0, |
| 337 | BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE, |
| 338 | errp); |
| 339 | if (ret < 0) { |
| 340 | goto fail; |
| 341 | } |
Alberto Garcia | 3e4c512 | 2016-10-28 10:08:08 +0300 | [diff] [blame] | 342 | } |
| 343 | |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 344 | ret = block_job_add_bdrv(&s->common, "base", base, 0, BLK_PERM_ALL, errp); |
| 345 | if (ret < 0) { |
| 346 | goto fail; |
| 347 | } |
| 348 | |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 349 | s->base = blk_new(BLK_PERM_CONSISTENT_READ |
| 350 | | BLK_PERM_WRITE |
| 351 | | BLK_PERM_RESIZE, |
| 352 | BLK_PERM_CONSISTENT_READ |
| 353 | | BLK_PERM_GRAPH_MOD |
| 354 | | BLK_PERM_WRITE_UNCHANGED); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 355 | ret = blk_insert_bs(s->base, base, errp); |
| 356 | if (ret < 0) { |
| 357 | goto fail; |
| 358 | } |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 359 | |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 360 | /* Required permissions are already taken with block_job_add_bdrv() */ |
Kevin Wolf | 6d0eb64 | 2017-01-20 17:07:26 +0100 | [diff] [blame] | 361 | s->top = blk_new(0, BLK_PERM_ALL); |
Kevin Wolf | b247767 | 2017-03-03 16:54:21 +0100 | [diff] [blame] | 362 | ret = blk_insert_bs(s->top, top, errp); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 363 | if (ret < 0) { |
| 364 | goto fail; |
| 365 | } |
Kevin Wolf | 4653456 | 2016-04-14 13:09:53 +0200 | [diff] [blame] | 366 | |
Kevin Wolf | bde7071 | 2017-06-27 20:36:18 +0200 | [diff] [blame] | 367 | s->base_flags = orig_base_flags; |
Jeff Cody | 54e2690 | 2014-06-25 15:40:10 -0400 | [diff] [blame] | 368 | s->backing_file_str = g_strdup(backing_file_str); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 369 | s->on_error = on_error; |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 370 | |
John Snow | 5ccac6f | 2016-11-08 01:50:37 -0500 | [diff] [blame] | 371 | trace_commit_start(bs, base, top, s); |
Kevin Wolf | da01ff7 | 2018-04-13 17:31:02 +0200 | [diff] [blame] | 372 | job_start(&s->common.job); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 373 | return; |
| 374 | |
| 375 | fail: |
| 376 | if (s->base) { |
| 377 | blk_unref(s->base); |
| 378 | } |
| 379 | if (s->top) { |
| 380 | blk_unref(s->top); |
| 381 | } |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 382 | if (commit_top_bs) { |
Kevin Wolf | bde7071 | 2017-06-27 20:36:18 +0200 | [diff] [blame] | 383 | bdrv_replace_node(commit_top_bs, top, &error_abort); |
Kevin Wolf | 8dfba27 | 2017-01-16 16:22:34 +0100 | [diff] [blame] | 384 | } |
Kevin Wolf | 4ad3518 | 2018-04-19 17:30:16 +0200 | [diff] [blame] | 385 | job_early_fail(&s->common.job); |
Jeff Cody | 747ff60 | 2012-09-27 13:29:13 -0400 | [diff] [blame] | 386 | } |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 387 | |
| 388 | |
Eric Blake | d6a644b | 2017-07-07 07:44:57 -0500 | [diff] [blame] | 389 | #define COMMIT_BUF_SIZE (2048 * BDRV_SECTOR_SIZE) |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 390 | |
| 391 | /* commit COW file into the raw image */ |
| 392 | int bdrv_commit(BlockDriverState *bs) |
| 393 | { |
Kevin Wolf | f8e2bd5 | 2016-05-30 16:29:47 +0200 | [diff] [blame] | 394 | BlockBackend *src, *backing; |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 395 | BlockDriverState *backing_file_bs = NULL; |
| 396 | BlockDriverState *commit_top_bs = NULL; |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 397 | BlockDriver *drv = bs->drv; |
Eric Blake | d6a644b | 2017-07-07 07:44:57 -0500 | [diff] [blame] | 398 | int64_t offset, length, backing_length; |
| 399 | int ro, open_flags; |
| 400 | int64_t n; |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 401 | int ret = 0; |
| 402 | uint8_t *buf = NULL; |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 403 | Error *local_err = NULL; |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 404 | |
| 405 | if (!drv) |
| 406 | return -ENOMEDIUM; |
| 407 | |
| 408 | if (!bs->backing) { |
| 409 | return -ENOTSUP; |
| 410 | } |
| 411 | |
| 412 | if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_COMMIT_SOURCE, NULL) || |
| 413 | bdrv_op_is_blocked(bs->backing->bs, BLOCK_OP_TYPE_COMMIT_TARGET, NULL)) { |
| 414 | return -EBUSY; |
| 415 | } |
| 416 | |
| 417 | ro = bs->backing->bs->read_only; |
| 418 | open_flags = bs->backing->bs->open_flags; |
| 419 | |
| 420 | if (ro) { |
| 421 | if (bdrv_reopen(bs->backing->bs, open_flags | BDRV_O_RDWR, NULL)) { |
| 422 | return -EACCES; |
| 423 | } |
| 424 | } |
| 425 | |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 426 | src = blk_new(BLK_PERM_CONSISTENT_READ, BLK_PERM_ALL); |
| 427 | backing = blk_new(BLK_PERM_WRITE | BLK_PERM_RESIZE, BLK_PERM_ALL); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 428 | |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 429 | ret = blk_insert_bs(src, bs, &local_err); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 430 | if (ret < 0) { |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 431 | error_report_err(local_err); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 432 | goto ro_cleanup; |
| 433 | } |
| 434 | |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 435 | /* Insert commit_top block node above backing, so we can write to it */ |
| 436 | backing_file_bs = backing_bs(bs); |
| 437 | |
| 438 | commit_top_bs = bdrv_new_open_driver(&bdrv_commit_top, NULL, BDRV_O_RDWR, |
| 439 | &local_err); |
| 440 | if (commit_top_bs == NULL) { |
| 441 | error_report_err(local_err); |
| 442 | goto ro_cleanup; |
| 443 | } |
Kevin Wolf | 02be4ae | 2017-04-06 19:05:07 +0200 | [diff] [blame] | 444 | bdrv_set_aio_context(commit_top_bs, bdrv_get_aio_context(backing_file_bs)); |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 445 | |
Kevin Wolf | 12fa4af | 2017-02-17 20:42:32 +0100 | [diff] [blame] | 446 | bdrv_set_backing_hd(commit_top_bs, backing_file_bs, &error_abort); |
| 447 | bdrv_set_backing_hd(bs, commit_top_bs, &error_abort); |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 448 | |
| 449 | ret = blk_insert_bs(backing, backing_file_bs, &local_err); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 450 | if (ret < 0) { |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 451 | error_report_err(local_err); |
Kevin Wolf | d708642 | 2017-01-13 19:02:32 +0100 | [diff] [blame] | 452 | goto ro_cleanup; |
| 453 | } |
Kevin Wolf | f8e2bd5 | 2016-05-30 16:29:47 +0200 | [diff] [blame] | 454 | |
| 455 | length = blk_getlength(src); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 456 | if (length < 0) { |
| 457 | ret = length; |
| 458 | goto ro_cleanup; |
| 459 | } |
| 460 | |
Kevin Wolf | f8e2bd5 | 2016-05-30 16:29:47 +0200 | [diff] [blame] | 461 | backing_length = blk_getlength(backing); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 462 | if (backing_length < 0) { |
| 463 | ret = backing_length; |
| 464 | goto ro_cleanup; |
| 465 | } |
| 466 | |
| 467 | /* If our top snapshot is larger than the backing file image, |
| 468 | * grow the backing file image if possible. If not possible, |
| 469 | * we must return an error */ |
| 470 | if (length > backing_length) { |
Max Reitz | 3a691c5 | 2017-06-13 22:20:54 +0200 | [diff] [blame] | 471 | ret = blk_truncate(backing, length, PREALLOC_MODE_OFF, &local_err); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 472 | if (ret < 0) { |
Max Reitz | ed3d2ec | 2017-03-28 22:51:27 +0200 | [diff] [blame] | 473 | error_report_err(local_err); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 474 | goto ro_cleanup; |
| 475 | } |
| 476 | } |
| 477 | |
Kevin Wolf | f8e2bd5 | 2016-05-30 16:29:47 +0200 | [diff] [blame] | 478 | /* blk_try_blockalign() for src will choose an alignment that works for |
| 479 | * backing as well, so no need to compare the alignment manually. */ |
Eric Blake | d6a644b | 2017-07-07 07:44:57 -0500 | [diff] [blame] | 480 | buf = blk_try_blockalign(src, COMMIT_BUF_SIZE); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 481 | if (buf == NULL) { |
| 482 | ret = -ENOMEM; |
| 483 | goto ro_cleanup; |
| 484 | } |
| 485 | |
Eric Blake | d6a644b | 2017-07-07 07:44:57 -0500 | [diff] [blame] | 486 | for (offset = 0; offset < length; offset += n) { |
| 487 | ret = bdrv_is_allocated(bs, offset, COMMIT_BUF_SIZE, &n); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 488 | if (ret < 0) { |
| 489 | goto ro_cleanup; |
| 490 | } |
| 491 | if (ret) { |
Eric Blake | d6a644b | 2017-07-07 07:44:57 -0500 | [diff] [blame] | 492 | ret = blk_pread(src, offset, buf, n); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 493 | if (ret < 0) { |
| 494 | goto ro_cleanup; |
| 495 | } |
| 496 | |
Eric Blake | d6a644b | 2017-07-07 07:44:57 -0500 | [diff] [blame] | 497 | ret = blk_pwrite(backing, offset, buf, n, 0); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 498 | if (ret < 0) { |
| 499 | goto ro_cleanup; |
| 500 | } |
| 501 | } |
| 502 | } |
| 503 | |
| 504 | if (drv->bdrv_make_empty) { |
| 505 | ret = drv->bdrv_make_empty(bs); |
| 506 | if (ret < 0) { |
| 507 | goto ro_cleanup; |
| 508 | } |
Kevin Wolf | f8e2bd5 | 2016-05-30 16:29:47 +0200 | [diff] [blame] | 509 | blk_flush(src); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 510 | } |
| 511 | |
| 512 | /* |
| 513 | * Make sure all data we wrote to the backing device is actually |
| 514 | * stable on disk. |
| 515 | */ |
Kevin Wolf | f8e2bd5 | 2016-05-30 16:29:47 +0200 | [diff] [blame] | 516 | blk_flush(backing); |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 517 | |
| 518 | ret = 0; |
| 519 | ro_cleanup: |
| 520 | qemu_vfree(buf); |
| 521 | |
Kevin Wolf | f8e2bd5 | 2016-05-30 16:29:47 +0200 | [diff] [blame] | 522 | blk_unref(backing); |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 523 | if (backing_file_bs) { |
Kevin Wolf | 12fa4af | 2017-02-17 20:42:32 +0100 | [diff] [blame] | 524 | bdrv_set_backing_hd(bs, backing_file_bs, &error_abort); |
Kevin Wolf | d3f0675 | 2017-01-19 18:16:03 +0100 | [diff] [blame] | 525 | } |
| 526 | bdrv_unref(commit_top_bs); |
| 527 | blk_unref(src); |
Kevin Wolf | f8e2bd5 | 2016-05-30 16:29:47 +0200 | [diff] [blame] | 528 | |
Kevin Wolf | 83fd6dd | 2016-05-30 15:53:15 +0200 | [diff] [blame] | 529 | if (ro) { |
| 530 | /* ignoring error return here */ |
| 531 | bdrv_reopen(bs->backing->bs, open_flags & ~BDRV_O_RDWR, NULL); |
| 532 | } |
| 533 | |
| 534 | return ret; |
| 535 | } |