diff options
| author | Christophe Lyon <christophe.lyon@linaro.org> | 2023-10-05 14:51:43 +0000 |
|---|---|---|
| committer | Christophe Lyon <christophe.lyon@linaro.org> | 2023-10-24 12:27:33 +0000 |
| commit | 5d5e93f6e19fb6d0008f0722eb2e24e0197fb481 (patch) | |
| tree | 1010b6776bb58f8cf629d1b3d18c515960002dc7 /tcwg-base | |
| parent | fc9a2c5a37ad31aabffa1d0e9d836d6dd00b3e28 (diff) | |
tcwg-base/home-data/group: Rename tcwg-build group into tcwg-build-group
This group is only used by the tcwg-build user, when we run precommit
testing, which we want isolated from other processes as much as
possible.
However, having UID == GID and group name == user name for that user
implies that its default umask is 002 instead of 022 for other
users. This results in bogus regression reports when (bogus) tests
depend on file permissions, where our baseline used 022 as umask and
the precommit tests use 002.
The simplest workaround seems to rename tcwg-build group.
Another possibility would have been to give tcwg-buidslave (the user
we use for most CI) its dedicated group (and thus behave the same as
tcwg-build), but this would imply the tedious process of running chgrp
on all machines.
Change-Id: Ice589dc30abf357036d37425e327593b083193b6
Diffstat (limited to 'tcwg-base')
| -rw-r--r-- | tcwg-base/home-data/group | 2 | ||||
| -rw-r--r-- | tcwg-base/home-data/tcwg-build/README | 10 |
2 files changed, 8 insertions, 4 deletions
diff --git a/tcwg-base/home-data/group b/tcwg-base/home-data/group index d65db79e..e4166dad 100644 --- a/tcwg-base/home-data/group +++ b/tcwg-base/home-data/group @@ -4,7 +4,7 @@ tcwg-users:x:10000:maxim.kuvyrkov,alex.bennee,christophe.lyon,richard.henderson, tcwg-llvm:x:9001:tcwg-buildslave,tcwg-buildbot,maxim.kuvyrkov,omair.javaid,prathamesh.kulkarni,adhemerval.zanella,david.spickett,stevan.radakovic,thiago.bauermann,antoine.moynault,carlos.seo,leonardo.sandoval,leandro.lupori tcwg-llvm-root:x:x:maxim.kuvyrkov,omair.javaid,david.spickett,adhemerval.zanella tcwg-guests:x:9002:everton.constantino,anthony.roberts,lina.iyer -tcwg-build:x:9003: +tcwg-build-group:x:9003: tcwg-sudo:x:9004:maxim.kuvyrkov,alex.bennee,christophe.lyon,richard.henderson,prathamesh.kulkarni,omair.javaid,adhemerval.zanella,david.spickett,stevan.radakovic,laurent.alfonsi,thiago.bauermann,pierrick.bouvier,antoine.moynault,carlos.seo,leonardo.sandoval,leandro.lupori,tcwg-benchmark,tcwg-buildslave,tcwg-buildbot,tcwg-ci-bot tcwg-bmk:x:9005:tcwg-benchmark,maxim.kuvyrkov,laurent.alfonsi,prathamesh.kulkarni,antoine.moynault,leandro.lupori tcwg-bmk-root:x:x:tcwg-benchmark,maxim.kuvyrkov,laurent.alfonsi diff --git a/tcwg-base/home-data/tcwg-build/README b/tcwg-base/home-data/tcwg-build/README index ebf5ba19..d5a95bf5 100644 --- a/tcwg-base/home-data/tcwg-build/README +++ b/tcwg-base/home-data/tcwg-build/README @@ -44,10 +44,14 @@ which allow access for groups of users defined in home-data/group. !!! It is important that tcwg-build is NOT a member of ANY group in !!! home-data/group. This prevents it from accessing TCWG machines. -We have a dedicated group with the matching name and matching GID for -tcwg-build to have a primary group. This is it's entry in home-data/group: +We have a dedicated group with the matching GID for tcwg-build to have +a primary group. The group name does not match the user name to avoid +using umask 002 when most other users have 022. This can cause +differences in builds/tests which depend on file permissions, leading +to bogus regression reports (see USERGROUPS_ENAB description in +/etc/login.defs). This is it's entry in home-data/group: === -tcwg-build:x:9003: +tcwg-build-group:x:9003: === !!! It is important that tcwg-build is NOT specified as a member of this !!! group because, otherwise, "tcwg-host/run.sh all" will configure access |