diff options
| author | Dan Liew <dan@su-root.co.uk> | 2018-12-11 12:43:44 +0000 |
|---|---|---|
| committer | Dan Liew <dan@su-root.co.uk> | 2018-12-11 12:43:44 +0000 |
| commit | 30392c7c47fa6dd533ef3a3b691a67e1fcd39c6e (patch) | |
| tree | bba91f04058b0eaa5b66ef616f4162cd2027b3b1 | |
| parent | e527a51bcfcf77036b7d03fdfc40cc348b8a4e7d (diff) | |
Fix bug where we'd try symbolize a second time with the same arguments.
Summary:
Fix bug where we'd try symbolize a second time with the same arguments even though symbolization failed the first time.
This looks like a long standing typo given that the guard for trying
symbolization again is to only try it if symbolization failed using
`binary` and `original_binary != binary`.
Reviewers: kubamracek, glider, samsonov
Subscribers: #sanitizers, llvm-commits
Differential Revision: https://reviews.llvm.org/D55504
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@348841 91177308-0d34-0410-b5e6-96231b3b80d8
| -rwxr-xr-x | lib/asan/scripts/asan_symbolize.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/asan/scripts/asan_symbolize.py b/lib/asan/scripts/asan_symbolize.py index 13e5f0cd4..2dbb05283 100755 --- a/lib/asan/scripts/asan_symbolize.py +++ b/lib/asan/scripts/asan_symbolize.py @@ -477,7 +477,7 @@ class SymbolizationLoop(object): symbolized_line = self.symbolize_address(addr, binary, offset, arch) if not symbolized_line: if original_binary != binary: - symbolized_line = self.symbolize_address(addr, binary, offset, arch) + symbolized_line = self.symbolize_address(addr, original_binary, offset, arch) return self.get_symbolized_lines(symbolized_line) |