lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 1 | /* |
| 2 | * QEMU live block migration |
| 3 | * |
| 4 | * Copyright IBM, Corp. 2009 |
| 5 | * |
| 6 | * Authors: |
| 7 | * Liran Schour <lirans@il.ibm.com> |
| 8 | * |
| 9 | * This work is licensed under the terms of the GNU GPL, version 2. See |
| 10 | * the COPYING file in the top-level directory. |
| 11 | * |
| 12 | */ |
| 13 | |
| 14 | #include "qemu-common.h" |
| 15 | #include "block_int.h" |
| 16 | #include "hw/hw.h" |
Jan Kiszka | 5e5328b | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 17 | #include "qemu-queue.h" |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 18 | #include "monitor.h" |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 19 | #include "block-migration.h" |
| 20 | #include <assert.h> |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 21 | |
Jan Kiszka | 6ea4430 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 22 | #define BLOCK_SIZE (BDRV_SECTORS_PER_DIRTY_CHUNK << BDRV_SECTOR_BITS) |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 23 | |
| 24 | #define BLK_MIG_FLAG_DEVICE_BLOCK 0x01 |
| 25 | #define BLK_MIG_FLAG_EOS 0x02 |
| 26 | |
| 27 | #define MAX_IS_ALLOCATED_SEARCH 65536 |
| 28 | #define MAX_BLOCKS_READ 10000 |
| 29 | #define BLOCKS_READ_CHANGE 100 |
| 30 | #define INITIAL_BLOCKS_READ 100 |
| 31 | |
| 32 | //#define DEBUG_BLK_MIGRATION |
| 33 | |
| 34 | #ifdef DEBUG_BLK_MIGRATION |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 35 | #define dprintf(fmt, ...) \ |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 36 | do { printf("blk_migration: " fmt, ## __VA_ARGS__); } while (0) |
| 37 | #else |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 38 | #define dprintf(fmt, ...) \ |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 39 | do { } while (0) |
| 40 | #endif |
| 41 | |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 42 | typedef struct BlkMigDevState { |
| 43 | BlockDriverState *bs; |
| 44 | int bulk_completed; |
| 45 | int shared_base; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 46 | int64_t cur_sector; |
Jan Kiszka | 82801d8 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 47 | int64_t completed_sectors; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 48 | int64_t total_sectors; |
| 49 | int64_t dirty; |
Jan Kiszka | 5e5328b | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 50 | QSIMPLEQ_ENTRY(BlkMigDevState) entry; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 51 | } BlkMigDevState; |
| 52 | |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 53 | typedef struct BlkMigBlock { |
| 54 | uint8_t *buf; |
| 55 | BlkMigDevState *bmds; |
| 56 | int64_t sector; |
| 57 | struct iovec iov; |
| 58 | QEMUIOVector qiov; |
| 59 | BlockDriverAIOCB *aiocb; |
| 60 | int ret; |
Jan Kiszka | 5e5328b | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 61 | QSIMPLEQ_ENTRY(BlkMigBlock) entry; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 62 | } BlkMigBlock; |
| 63 | |
| 64 | typedef struct BlkMigState { |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 65 | int blk_enable; |
| 66 | int shared_base; |
Jan Kiszka | 5e5328b | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 67 | QSIMPLEQ_HEAD(bmds_list, BlkMigDevState) bmds_list; |
| 68 | QSIMPLEQ_HEAD(blk_list, BlkMigBlock) blk_list; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 69 | int submitted; |
| 70 | int read_done; |
| 71 | int transferred; |
Jan Kiszka | 82801d8 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 72 | int64_t total_sector_sum; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 73 | int64_t print_completion; |
| 74 | } BlkMigState; |
| 75 | |
Jan Kiszka | d11ecd3 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 76 | static BlkMigState block_mig_state; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 77 | |
Jan Kiszka | 13f0b67 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 78 | static void blk_send(QEMUFile *f, BlkMigBlock * blk) |
| 79 | { |
| 80 | int len; |
| 81 | |
| 82 | /* sector number and flags */ |
| 83 | qemu_put_be64(f, (blk->sector << BDRV_SECTOR_BITS) |
| 84 | | BLK_MIG_FLAG_DEVICE_BLOCK); |
| 85 | |
| 86 | /* device name */ |
| 87 | len = strlen(blk->bmds->bs->device_name); |
| 88 | qemu_put_byte(f, len); |
| 89 | qemu_put_buffer(f, (uint8_t *)blk->bmds->bs->device_name, len); |
| 90 | |
| 91 | qemu_put_buffer(f, blk->buf, BLOCK_SIZE); |
| 92 | } |
| 93 | |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 94 | static void blk_mig_read_cb(void *opaque, int ret) |
| 95 | { |
| 96 | BlkMigBlock *blk = opaque; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 97 | |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 98 | blk->ret = ret; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 99 | |
Jan Kiszka | 5e5328b | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 100 | QSIMPLEQ_INSERT_TAIL(&block_mig_state.blk_list, blk, entry); |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 101 | |
Jan Kiszka | d11ecd3 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 102 | block_mig_state.submitted--; |
| 103 | block_mig_state.read_done++; |
| 104 | assert(block_mig_state.submitted >= 0); |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 105 | } |
| 106 | |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 107 | static int mig_save_device_bulk(Monitor *mon, QEMUFile *f, |
| 108 | BlkMigDevState *bmds, int is_async) |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 109 | { |
Jan Kiszka | 57cce12 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 110 | int64_t total_sectors = bmds->total_sectors; |
| 111 | int64_t cur_sector = bmds->cur_sector; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 112 | BlockDriverState *bs = bmds->bs; |
Jan Kiszka | 57cce12 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 113 | BlkMigBlock *blk; |
Jan Kiszka | 13f0b67 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 114 | int nr_sectors; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 115 | |
| 116 | if (bmds->shared_base) { |
Jan Kiszka | b1d1085 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 117 | while (cur_sector < total_sectors && |
Jan Kiszka | 57cce12 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 118 | !bdrv_is_allocated(bs, cur_sector, MAX_IS_ALLOCATED_SEARCH, |
| 119 | &nr_sectors)) { |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 120 | cur_sector += nr_sectors; |
| 121 | } |
| 122 | } |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 123 | |
| 124 | if (cur_sector >= total_sectors) { |
Jan Kiszka | 82801d8 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 125 | bmds->cur_sector = bmds->completed_sectors = total_sectors; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 126 | return 1; |
| 127 | } |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 128 | |
Jan Kiszka | 82801d8 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 129 | bmds->completed_sectors = cur_sector; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 130 | |
Jan Kiszka | 6ea4430 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 131 | cur_sector &= ~((int64_t)BDRV_SECTORS_PER_DIRTY_CHUNK - 1); |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 132 | |
Jan Kiszka | 6ea4430 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 133 | /* we are going to transfer a full block even if it is not allocated */ |
| 134 | nr_sectors = BDRV_SECTORS_PER_DIRTY_CHUNK; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 135 | |
Jan Kiszka | 6ea4430 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 136 | if (total_sectors - cur_sector < BDRV_SECTORS_PER_DIRTY_CHUNK) { |
Jan Kiszka | 57cce12 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 137 | nr_sectors = total_sectors - cur_sector; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 138 | } |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 139 | |
Jan Kiszka | 13f0b67 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 140 | blk = qemu_malloc(sizeof(BlkMigBlock)); |
| 141 | blk->buf = qemu_malloc(BLOCK_SIZE); |
| 142 | blk->bmds = bmds; |
| 143 | blk->sector = cur_sector; |
| 144 | |
Jan Kiszka | 57cce12 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 145 | if (is_async) { |
Jan Kiszka | 57cce12 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 146 | blk->iov.iov_base = blk->buf; |
| 147 | blk->iov.iov_len = nr_sectors * BDRV_SECTOR_SIZE; |
| 148 | qemu_iovec_init_external(&blk->qiov, &blk->iov, 1); |
| 149 | |
| 150 | blk->aiocb = bdrv_aio_readv(bs, cur_sector, &blk->qiov, |
| 151 | nr_sectors, blk_mig_read_cb, blk); |
Jan Kiszka | 57cce12 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 152 | if (!blk->aiocb) { |
Jan Kiszka | 4b64036 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 153 | goto error; |
Jan Kiszka | 57cce12 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 154 | } |
Jan Kiszka | 57cce12 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 155 | block_mig_state.submitted++; |
Jan Kiszka | 57cce12 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 156 | } else { |
Jan Kiszka | 13f0b67 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 157 | if (bdrv_read(bs, cur_sector, blk->buf, nr_sectors) < 0) { |
Jan Kiszka | 4b64036 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 158 | goto error; |
Jan Kiszka | 57cce12 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 159 | } |
Jan Kiszka | 13f0b67 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 160 | blk_send(f, blk); |
Jan Kiszka | 57cce12 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 161 | |
Jan Kiszka | 13f0b67 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 162 | qemu_free(blk->buf); |
| 163 | qemu_free(blk); |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 164 | } |
| 165 | |
Jan Kiszka | 13f0b67 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 166 | bdrv_reset_dirty(bs, cur_sector, nr_sectors); |
| 167 | bmds->cur_sector = cur_sector + nr_sectors; |
| 168 | |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 169 | return (bmds->cur_sector >= total_sectors); |
Jan Kiszka | 4b64036 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 170 | |
| 171 | error: |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 172 | monitor_printf(mon, "Error reading sector %" PRId64 "\n", cur_sector); |
Jan Kiszka | 4b64036 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 173 | qemu_file_set_error(f); |
| 174 | qemu_free(blk->buf); |
| 175 | qemu_free(blk); |
| 176 | return 0; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 177 | } |
| 178 | |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 179 | static void set_dirty_tracking(int enable) |
| 180 | { |
| 181 | BlkMigDevState *bmds; |
Jan Kiszka | 5e5328b | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 182 | |
| 183 | QSIMPLEQ_FOREACH(bmds, &block_mig_state.bmds_list, entry) { |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 184 | bdrv_set_dirty_tracking(bmds->bs, enable); |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 185 | } |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 186 | } |
| 187 | |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 188 | static void init_blk_migration(Monitor *mon, QEMUFile *f) |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 189 | { |
Jan Kiszka | 5e5328b | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 190 | BlkMigDevState *bmds; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 191 | BlockDriverState *bs; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 192 | |
Jan Kiszka | 69d63a9 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 193 | block_mig_state.submitted = 0; |
| 194 | block_mig_state.read_done = 0; |
| 195 | block_mig_state.transferred = 0; |
Jan Kiszka | 82801d8 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 196 | block_mig_state.total_sector_sum = 0; |
Jan Kiszka | 69d63a9 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 197 | block_mig_state.print_completion = 0; |
| 198 | |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 199 | for (bs = bdrv_first; bs != NULL; bs = bs->next) { |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 200 | if (bs->type == BDRV_TYPE_HD) { |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 201 | bmds = qemu_mallocz(sizeof(BlkMigDevState)); |
| 202 | bmds->bs = bs; |
| 203 | bmds->bulk_completed = 0; |
Jan Kiszka | 6ea4430 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 204 | bmds->total_sectors = bdrv_getlength(bs) >> BDRV_SECTOR_BITS; |
Jan Kiszka | 82801d8 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 205 | bmds->completed_sectors = 0; |
Jan Kiszka | d11ecd3 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 206 | bmds->shared_base = block_mig_state.shared_base; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 207 | |
Jan Kiszka | 82801d8 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 208 | block_mig_state.total_sector_sum += bmds->total_sectors; |
| 209 | |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 210 | if (bmds->shared_base) { |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 211 | monitor_printf(mon, "Start migration for %s with shared base " |
| 212 | "image\n", |
| 213 | bs->device_name); |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 214 | } else { |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 215 | monitor_printf(mon, "Start full migration for %s\n", |
| 216 | bs->device_name); |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 217 | } |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 218 | |
Jan Kiszka | 5e5328b | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 219 | QSIMPLEQ_INSERT_TAIL(&block_mig_state.bmds_list, bmds, entry); |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 220 | } |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 221 | } |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 222 | } |
| 223 | |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 224 | static int blk_mig_save_bulked_block(Monitor *mon, QEMUFile *f, int is_async) |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 225 | { |
Jan Kiszka | 82801d8 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 226 | int64_t completed_sector_sum = 0; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 227 | BlkMigDevState *bmds; |
Jan Kiszka | 82801d8 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 228 | int ret = 0; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 229 | |
Jan Kiszka | 5e5328b | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 230 | QSIMPLEQ_FOREACH(bmds, &block_mig_state.bmds_list, entry) { |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 231 | if (bmds->bulk_completed == 0) { |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 232 | if (mig_save_device_bulk(mon, f, bmds, is_async) == 1) { |
Jan Kiszka | 57cce12 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 233 | /* completed bulk section for this device */ |
| 234 | bmds->bulk_completed = 1; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 235 | } |
Jan Kiszka | 82801d8 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 236 | completed_sector_sum += bmds->completed_sectors; |
| 237 | ret = 1; |
| 238 | break; |
| 239 | } else { |
| 240 | completed_sector_sum += bmds->completed_sectors; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 241 | } |
| 242 | } |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 243 | |
Jan Kiszka | 82801d8 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 244 | if (completed_sector_sum >= block_mig_state.print_completion) { |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 245 | monitor_printf(mon, "Completed %" PRId64 " %%\r", |
| 246 | completed_sector_sum * 100 / |
| 247 | block_mig_state.total_sector_sum); |
| 248 | monitor_flush(mon); |
Jan Kiszka | 82801d8 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 249 | block_mig_state.print_completion += |
| 250 | (BDRV_SECTORS_PER_DIRTY_CHUNK * 10000); |
| 251 | } |
| 252 | |
| 253 | return ret; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 254 | } |
| 255 | |
| 256 | #define MAX_NUM_BLOCKS 4 |
| 257 | |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 258 | static void blk_mig_save_dirty_blocks(Monitor *mon, QEMUFile *f) |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 259 | { |
| 260 | BlkMigDevState *bmds; |
Jan Kiszka | 13f0b67 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 261 | BlkMigBlock blk; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 262 | int64_t sector; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 263 | |
Jan Kiszka | 13f0b67 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 264 | blk.buf = qemu_malloc(BLOCK_SIZE); |
Jan Kiszka | 575a58d | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 265 | |
Jan Kiszka | 5e5328b | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 266 | QSIMPLEQ_FOREACH(bmds, &block_mig_state.bmds_list, entry) { |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 267 | for (sector = 0; sector < bmds->cur_sector;) { |
| 268 | if (bdrv_get_dirty(bmds->bs, sector)) { |
Jan Kiszka | 13f0b67 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 269 | if (bdrv_read(bmds->bs, sector, blk.buf, |
Jan Kiszka | 6ea4430 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 270 | BDRV_SECTORS_PER_DIRTY_CHUNK) < 0) { |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 271 | monitor_printf(mon, "Error reading sector %" PRId64 "\n", |
| 272 | sector); |
Jan Kiszka | 4b64036 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 273 | qemu_file_set_error(f); |
| 274 | qemu_free(blk.buf); |
| 275 | return; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 276 | } |
Jan Kiszka | 13f0b67 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 277 | blk.bmds = bmds; |
| 278 | blk.sector = sector; |
| 279 | blk_send(f, &blk); |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 280 | |
| 281 | bdrv_reset_dirty(bmds->bs, sector, |
Jan Kiszka | 6ea4430 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 282 | BDRV_SECTORS_PER_DIRTY_CHUNK); |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 283 | } |
Jan Kiszka | 6ea4430 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 284 | sector += BDRV_SECTORS_PER_DIRTY_CHUNK; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 285 | } |
| 286 | } |
Jan Kiszka | 575a58d | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 287 | |
Jan Kiszka | 13f0b67 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 288 | qemu_free(blk.buf); |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 289 | } |
| 290 | |
| 291 | static void flush_blks(QEMUFile* f) |
| 292 | { |
Jan Kiszka | 5e5328b | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 293 | BlkMigBlock *blk; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 294 | |
Jan Kiszka | d11ecd3 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 295 | dprintf("%s Enter submitted %d read_done %d transferred %d\n", |
| 296 | __FUNCTION__, block_mig_state.submitted, block_mig_state.read_done, |
| 297 | block_mig_state.transferred); |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 298 | |
Jan Kiszka | 5e5328b | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 299 | while ((blk = QSIMPLEQ_FIRST(&block_mig_state.blk_list)) != NULL) { |
| 300 | if (qemu_file_rate_limit(f)) { |
| 301 | break; |
| 302 | } |
Jan Kiszka | 4b64036 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 303 | if (blk->ret < 0) { |
| 304 | qemu_file_set_error(f); |
| 305 | break; |
| 306 | } |
Jan Kiszka | 13f0b67 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 307 | blk_send(f, blk); |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 308 | |
Jan Kiszka | 5e5328b | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 309 | QSIMPLEQ_REMOVE_HEAD(&block_mig_state.blk_list, entry); |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 310 | qemu_free(blk->buf); |
| 311 | qemu_free(blk); |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 312 | |
Jan Kiszka | d11ecd3 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 313 | block_mig_state.read_done--; |
| 314 | block_mig_state.transferred++; |
| 315 | assert(block_mig_state.read_done >= 0); |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 316 | } |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 317 | |
Jan Kiszka | d11ecd3 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 318 | dprintf("%s Exit submitted %d read_done %d transferred %d\n", __FUNCTION__, |
| 319 | block_mig_state.submitted, block_mig_state.read_done, |
| 320 | block_mig_state.transferred); |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 321 | } |
| 322 | |
| 323 | static int is_stage2_completed(void) |
| 324 | { |
| 325 | BlkMigDevState *bmds; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 326 | |
Jan Kiszka | d11ecd3 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 327 | if (block_mig_state.submitted > 0) { |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 328 | return 0; |
| 329 | } |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 330 | |
Jan Kiszka | 5e5328b | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 331 | QSIMPLEQ_FOREACH(bmds, &block_mig_state.bmds_list, entry) { |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 332 | if (bmds->bulk_completed == 0) { |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 333 | return 0; |
| 334 | } |
| 335 | } |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 336 | |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 337 | return 1; |
| 338 | } |
| 339 | |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 340 | static void blk_mig_cleanup(Monitor *mon) |
Jan Kiszka | 4ec7fcc | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 341 | { |
Jan Kiszka | 82801d8 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 342 | BlkMigDevState *bmds; |
| 343 | BlkMigBlock *blk; |
Jan Kiszka | 4ec7fcc | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 344 | |
Jan Kiszka | 82801d8 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 345 | while ((bmds = QSIMPLEQ_FIRST(&block_mig_state.bmds_list)) != NULL) { |
| 346 | QSIMPLEQ_REMOVE_HEAD(&block_mig_state.bmds_list, entry); |
Jan Kiszka | 4ec7fcc | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 347 | qemu_free(bmds); |
| 348 | } |
| 349 | |
Jan Kiszka | 82801d8 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 350 | while ((blk = QSIMPLEQ_FIRST(&block_mig_state.blk_list)) != NULL) { |
| 351 | QSIMPLEQ_REMOVE_HEAD(&block_mig_state.blk_list, entry); |
Jan Kiszka | 4ec7fcc | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 352 | qemu_free(blk->buf); |
| 353 | qemu_free(blk); |
| 354 | } |
| 355 | |
| 356 | set_dirty_tracking(0); |
| 357 | |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 358 | monitor_printf(mon, "\n"); |
Jan Kiszka | 4ec7fcc | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 359 | } |
| 360 | |
Jan Kiszka | f327aa0 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 361 | static int block_save_live(Monitor *mon, QEMUFile *f, int stage, void *opaque) |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 362 | { |
Jan Kiszka | d11ecd3 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 363 | dprintf("Enter save live stage %d submitted %d transferred %d\n", |
| 364 | stage, block_mig_state.submitted, block_mig_state.transferred); |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 365 | |
Jan Kiszka | 4ec7fcc | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 366 | if (stage < 0) { |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 367 | blk_mig_cleanup(mon); |
Jan Kiszka | 4ec7fcc | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 368 | return 0; |
| 369 | } |
| 370 | |
Jan Kiszka | d11ecd3 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 371 | if (block_mig_state.blk_enable != 1) { |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 372 | /* no need to migrate storage */ |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 373 | qemu_put_be64(f, BLK_MIG_FLAG_EOS); |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 374 | return 1; |
| 375 | } |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 376 | |
| 377 | if (stage == 1) { |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 378 | init_blk_migration(mon, f); |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 379 | |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 380 | /* start track dirty blocks */ |
| 381 | set_dirty_tracking(1); |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 382 | } |
| 383 | |
| 384 | flush_blks(f); |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 385 | |
Jan Kiszka | 4b64036 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 386 | if (qemu_file_has_error(f)) { |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 387 | blk_mig_cleanup(mon); |
Jan Kiszka | 4b64036 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 388 | return 0; |
| 389 | } |
| 390 | |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 391 | /* control the rate of transfer */ |
Jan Kiszka | d11ecd3 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 392 | while ((block_mig_state.submitted + |
| 393 | block_mig_state.read_done) * BLOCK_SIZE < |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 394 | qemu_file_get_rate_limit(f)) { |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 395 | if (blk_mig_save_bulked_block(mon, f, 1) == 0) { |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 396 | /* no more bulk blocks for now */ |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 397 | break; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 398 | } |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 399 | } |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 400 | |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 401 | flush_blks(f); |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 402 | |
Jan Kiszka | 4b64036 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 403 | if (qemu_file_has_error(f)) { |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 404 | blk_mig_cleanup(mon); |
Jan Kiszka | 4b64036 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 405 | return 0; |
| 406 | } |
| 407 | |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 408 | if (stage == 3) { |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 409 | while (blk_mig_save_bulked_block(mon, f, 0) != 0) { |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 410 | /* empty */ |
| 411 | } |
| 412 | |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 413 | blk_mig_save_dirty_blocks(mon, f); |
| 414 | blk_mig_cleanup(mon); |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 415 | |
Jan Kiszka | 4b64036 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 416 | if (qemu_file_has_error(f)) { |
| 417 | return 0; |
| 418 | } |
| 419 | |
Jan Kiszka | 7184049 | 2009-11-30 18:21:21 +0100 | [diff] [blame^] | 420 | monitor_printf(mon, "Block migration completed\n"); |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 421 | } |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 422 | |
| 423 | qemu_put_be64(f, BLK_MIG_FLAG_EOS); |
| 424 | |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 425 | return ((stage == 2) && is_stage2_completed()); |
| 426 | } |
| 427 | |
| 428 | static int block_load(QEMUFile *f, void *opaque, int version_id) |
| 429 | { |
| 430 | int len, flags; |
| 431 | char device_name[256]; |
| 432 | int64_t addr; |
| 433 | BlockDriverState *bs; |
| 434 | uint8_t *buf; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 435 | |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 436 | do { |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 437 | addr = qemu_get_be64(f); |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 438 | |
Jan Kiszka | 6ea4430 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 439 | flags = addr & ~BDRV_SECTOR_MASK; |
| 440 | addr >>= BDRV_SECTOR_BITS; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 441 | |
| 442 | if (flags & BLK_MIG_FLAG_DEVICE_BLOCK) { |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 443 | /* get device name */ |
| 444 | len = qemu_get_byte(f); |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 445 | qemu_get_buffer(f, (uint8_t *)device_name, len); |
| 446 | device_name[len] = '\0'; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 447 | |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 448 | bs = bdrv_find(device_name); |
Jan Kiszka | 4b64036 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 449 | if (!bs) { |
| 450 | fprintf(stderr, "Error unknown block device %s\n", |
| 451 | device_name); |
| 452 | return -EINVAL; |
| 453 | } |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 454 | |
Jan Kiszka | 575a58d | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 455 | buf = qemu_malloc(BLOCK_SIZE); |
| 456 | |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 457 | qemu_get_buffer(f, buf, BLOCK_SIZE); |
Jan Kiszka | 4b64036 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 458 | bdrv_write(bs, addr, buf, BDRV_SECTORS_PER_DIRTY_CHUNK); |
Jan Kiszka | 575a58d | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 459 | |
| 460 | qemu_free(buf); |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 461 | } else if (!(flags & BLK_MIG_FLAG_EOS)) { |
Jan Kiszka | 4b64036 | 2009-11-30 18:21:21 +0100 | [diff] [blame] | 462 | fprintf(stderr, "Unknown flags\n"); |
| 463 | return -EINVAL; |
| 464 | } |
| 465 | if (qemu_file_has_error(f)) { |
| 466 | return -EIO; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 467 | } |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 468 | } while (!(flags & BLK_MIG_FLAG_EOS)); |
| 469 | |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 470 | return 0; |
| 471 | } |
| 472 | |
| 473 | static void block_set_params(int blk_enable, int shared_base, void *opaque) |
| 474 | { |
Jan Kiszka | d11ecd3 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 475 | block_mig_state.blk_enable = blk_enable; |
| 476 | block_mig_state.shared_base = shared_base; |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 477 | |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 478 | /* shared base means that blk_enable = 1 */ |
Jan Kiszka | d11ecd3 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 479 | block_mig_state.blk_enable |= shared_base; |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 480 | } |
| 481 | |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 482 | void blk_mig_init(void) |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 483 | { |
Jan Kiszka | 5e5328b | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 484 | QSIMPLEQ_INIT(&block_mig_state.bmds_list); |
| 485 | QSIMPLEQ_INIT(&block_mig_state.blk_list); |
| 486 | |
Jan Kiszka | a55eb92 | 2009-11-30 18:21:19 +0100 | [diff] [blame] | 487 | register_savevm_live("block", 0, 1, block_set_params, block_save_live, |
Jan Kiszka | d11ecd3 | 2009-11-30 18:21:20 +0100 | [diff] [blame] | 488 | NULL, block_load, &block_mig_state); |
lirans@il.ibm.com | c163b5c | 2009-11-02 15:40:58 +0200 | [diff] [blame] | 489 | } |