aboutsummaryrefslogtreecommitdiff
path: root/xen-all.c
diff options
context:
space:
mode:
authorIan Jackson <ian.jackson@eu.citrix.com>2012-12-17 11:44:02 +0000
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>2012-12-17 11:44:02 +0000
commit249e7e0fff080df0eff54730f3b6459d92d61e5a (patch)
tree7db530e15a7a223b0e71c78abc94b1df9df8bfd2 /xen-all.c
parenta38648290ee277c7cb8a53eabdcdb08bb7a9f23f (diff)
cpu_ioreq_pio, cpu_ioreq_move: i should be uint32_t rather than int
The current code compare i (int) with req->count (uint32_t) in a for loop, risking an infinite loop if req->count is equal to UINT_MAX. Also i is only used in comparisons or multiplications with unsigned integers. Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Cc: Dongxiao Xu <dongxiao.xu@intel.com> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Diffstat (limited to 'xen-all.c')
-rw-r--r--xen-all.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/xen-all.c b/xen-all.c
index ef430ca21e..daf43b99d0 100644
--- a/xen-all.c
+++ b/xen-all.c
@@ -721,7 +721,7 @@ static inline void write_phys_req_item(hwaddr addr,
static void cpu_ioreq_pio(ioreq_t *req)
{
- int i;
+ uint32_t i;
if (req->dir == IOREQ_READ) {
if (!req->data_is_ptr) {
@@ -750,7 +750,7 @@ static void cpu_ioreq_pio(ioreq_t *req)
static void cpu_ioreq_move(ioreq_t *req)
{
- int i;
+ uint32_t i;
if (!req->data_is_ptr) {
if (req->dir == IOREQ_READ) {