diff options
| author | David Hildenbrand <david@redhat.com> | 2019-10-17 14:19:22 +0200 |
|---|---|---|
| committer | Cornelia Huck <cohuck@redhat.com> | 2019-10-21 17:30:06 +0200 |
| commit | 8064af6b1dac60491df611e5c49199d2e1c368c4 (patch) | |
| tree | 3e00adf4ae3131cd5bd19baca14a882ae03eb1be /target/s390x/mmu_helper.c | |
| parent | be39110d4cbf82bd4f9154d9958cd0a1aea57633 (diff) | |
s390x/mmu: Remove duplicate check for MMU_DATA_STORE
No need to double-check if we have a write.
Found by Coverity (CID: 1406404).
Fixes: 31b59419069e ("target/s390x: Return exception from mmu_translate_real")
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20191017121922.18840-1-david@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Diffstat (limited to 'target/s390x/mmu_helper.c')
| -rw-r--r-- | target/s390x/mmu_helper.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index 90b81335f9..c9f3f34750 100644 --- a/target/s390x/mmu_helper.c +++ b/target/s390x/mmu_helper.c @@ -556,9 +556,7 @@ int mmu_translate_real(CPUS390XState *env, target_ulong raddr, int rw, *flags |= PAGE_WRITE_INV; if (is_low_address(raddr) && rw == MMU_DATA_STORE) { /* LAP sets bit 56 */ - *tec = (raddr & TARGET_PAGE_MASK) - | (rw == MMU_DATA_STORE ? FS_WRITE : FS_READ) - | 0x80; + *tec = (raddr & TARGET_PAGE_MASK) | FS_WRITE | 0x80; return PGM_PROTECTION; } } |