diff options
| author | Andrea Arcangeli <aarcange@redhat.com> | 2009-06-15 13:52:27 +0200 |
|---|---|---|
| committer | Christoph Hellwig <hch@brick.lst.de> | 2009-06-15 13:52:27 +0200 |
| commit | 986c28d655dc9196c9c426c667c1764bd3d6d5bd (patch) | |
| tree | c617fd5bc12a7c417b0827af64cb016f718934ad /qemu-aio.h | |
| parent | e19252d32c45e92c919109ec32616382eb2afe6b (diff) | |
fix qemu_aio_flush
qemu_aio_wait by invoking the bh or one of the aio completion
callbacks, could end up submitting new pending aio, breaking the
invariant that qemu_aio_flush returns only when no pending aio is
outstanding (possibly a problem for migration as such).
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'qemu-aio.h')
| -rw-r--r-- | qemu-aio.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/qemu-aio.h b/qemu-aio.h index 79678293ef..f262344af3 100644 --- a/qemu-aio.h +++ b/qemu-aio.h @@ -24,9 +24,10 @@ typedef int (AioFlushHandler)(void *opaque); * outstanding AIO operations have been completed or cancelled. */ void qemu_aio_flush(void); -/* Wait for a single AIO completion to occur. This function will until a - * single AIO opeartion has completed. It is intended to be used as a looping - * primative when simulating synchronous IO based on asynchronous IO. */ +/* Wait for a single AIO completion to occur. This function will wait + * until a single AIO event has completed and it will ensure something + * has moved before returning. This can issue new pending aio as + * result of executing I/O completion or bh callbacks. */ void qemu_aio_wait(void); /* Register a file descriptor and associated callbacks. Behaves very similarly |