aboutsummaryrefslogtreecommitdiff
path: root/contrib/plugins
diff options
context:
space:
mode:
authorAlex Chen <alex.chen@huawei.com>2020-11-10 19:23:08 +0000
committerAlex Bennée <alex.bennee@linaro.org>2020-11-16 11:07:37 +0000
commit9cd7dde0730ed823b545910c0d5a676142015e3b (patch)
treefa518ff4b8cebe978044e5d027c38a4154181656 /contrib/plugins
parentdbb864ba4f7bc419a3ce473aa9436cc41b2e3dfd (diff)
plugins: Fix two resource leaks in setup_socket()
Either accept() fails or exits normally, we need to close the fd. Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Alex Chen <alex.chen@huawei.com> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Message-Id: <20201109082829.87496-3-alex.chen@huawei.com> Message-Id: <20201110192316.26397-3-alex.bennee@linaro.org>
Diffstat (limited to 'contrib/plugins')
-rw-r--r--contrib/plugins/lockstep.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index 319bd44b83..5aad50869d 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -268,11 +268,13 @@ static bool setup_socket(const char *path)
socket_fd = accept(fd, NULL, NULL);
if (socket_fd < 0 && errno != EINTR) {
perror("accept socket");
+ close(fd);
return false;
}
qemu_plugin_outs("setup_socket::ready\n");
+ close(fd);
return true;
}