diff options
| author | Luiz Capitulino <lcapitulino@redhat.com> | 2011-11-25 16:15:19 -0200 |
|---|---|---|
| committer | Luiz Capitulino <lcapitulino@redhat.com> | 2011-12-06 11:40:01 -0200 |
| commit | 6106e2492fe0080ad85d4862dec9c3bebc57b2f0 (patch) | |
| tree | 8ebe7e833fdbf1cd3d2caffccbee2cd420fcfa1e /blockdev.h | |
| parent | 5e7caacb2583e6a4657fec51a92147f33c5bae43 (diff) | |
qapi: Convert blockdev_snapshot_sync
Unfortunately, this conversion required an additional change.
In the old QMP command, the 'snapshot-file' argument is specified as
optional. The idea is to take the snapshot internally if 'snapshot-file'
is not passed. However, internal snapshots are not supported yet so
the command returns a MissingParamater error if 'snapshot-file' is not
passed. Which makes the argument actually required and will cause
compatibility breakage if we change that in the future.
To fix this the QAPI converted blockdev_snapshot_sync command makes the
'snapshot-file' argument required. Again, in practice it's actually required,
so this is not incompatible.
If we do implement internal snapshots someday, we'll need a new argument
for it.
Note that this discussion doesn't affect HMP.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Diffstat (limited to 'blockdev.h')
| -rw-r--r-- | blockdev.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/blockdev.h b/blockdev.h index b69a5499d5..f1b639660d 100644 --- a/blockdev.h +++ b/blockdev.h @@ -64,6 +64,4 @@ int do_change_block(Monitor *mon, const char *device, int do_drive_del(Monitor *mon, const QDict *qdict, QObject **ret_data); int do_block_set_io_throttle(Monitor *mon, const QDict *qdict, QObject **ret_data); -int do_snapshot_blkdev(Monitor *mon, const QDict *qdict, QObject **ret_data); - #endif |