aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLoic Poulain <loic.poulain@linaro.org>2020-07-24 16:03:43 +0200
committerLoic Poulain <loic.poulain@linaro.org>2020-08-24 09:30:31 +0200
commita40d0127c3276b88ad8379e8c4ecb73b2bb3b905 (patch)
treecb802793f97fb6c479fb1d7de645c32093833c57
parent78ae661621a230fc07ae281cb514f0b7e14a31c3 (diff)
Revert "wcn36xx: Fix power-saving with some APs"
This reverts commit 117ace24f7573f3fddb8e33bc04b3b06107fd51f.
-rw-r--r--drivers/net/wireless/ath/wcn36xx/pmc.c27
1 files changed, 0 insertions, 27 deletions
diff --git a/drivers/net/wireless/ath/wcn36xx/pmc.c b/drivers/net/wireless/ath/wcn36xx/pmc.c
index be3eade8e945c..2936aaf532738 100644
--- a/drivers/net/wireless/ath/wcn36xx/pmc.c
+++ b/drivers/net/wireless/ath/wcn36xx/pmc.c
@@ -18,26 +18,6 @@
#include "wcn36xx.h"
-static void wcn36xx_send_nullfunc(struct wcn36xx *wcn,
- struct ieee80211_vif *vif, bool powersave)
-{
- struct sk_buff *skb;
- struct ieee80211_hdr_3addr *nullfunc;
-
- skb = ieee80211_nullfunc_get(wcn->hw, vif, true);
- if (!skb)
- return;
-
- nullfunc = (struct ieee80211_hdr_3addr *) skb->data;
- if (powersave)
- nullfunc->frame_control |= cpu_to_le16(IEEE80211_FCTL_PM);
-
- IEEE80211_SKB_CB(skb)->flags |= IEEE80211_TX_INTFL_DONT_ENCRYPT;
-
- if (wcn36xx_start_tx(wcn, NULL, skb))
- ieee80211_free_txskb(wcn->hw, skb);
-}
-
int wcn36xx_pmc_enter_bmps_state(struct wcn36xx *wcn,
struct ieee80211_vif *vif)
{
@@ -49,13 +29,6 @@ int wcn36xx_pmc_enter_bmps_state(struct wcn36xx *wcn,
wcn36xx_dbg(WCN36XX_DBG_PMC, "Entered BMPS\n");
vif_priv->pw_state = WCN36XX_BMPS;
vif->driver_flags |= IEEE80211_VIF_BEACON_FILTER;
-
- /* The firmware sends a standard null data packet with PS flag,
- * but some APs (TPLinks) does not seem to take it into account,
- * leading to disconnection or degraded throughput. Inform the
- * AP with a high priority (7) QoS null function in complement.
- */
- wcn36xx_send_nullfunc(wcn, vif, true);
} else {
/*
* One of the reasons why HW will not enter BMPS is because