diff options
| author | John Ogness <john.ogness@linutronix.de> | 2022-05-26 22:36:56 +0206 |
|---|---|---|
| committer | Petr Mladek <pmladek@suse.com> | 2022-05-27 13:04:46 +0200 |
| commit | 809631e2bff5aba056df75cc4e43127dbd0278c9 (patch) | |
| tree | d6f705499b2731a75747a9eaf0e541a8c5d70ec6 /kernel/printk | |
| parent | 537e62c865dcb9b91d07ed83f8615b71fa0b51bb (diff) | |
Revert "printk: wake up all waiters"
This reverts commit 938ba4084abcf6fdd21d9078513c52f8fb9b00d0.
The wait queue @log_wait never has exclusive waiters, so there
is no need to use wake_up_interruptible_all(). Using
wake_up_interruptible() was the correct function to wake all
waiters.
Since there are no exclusive waiters, erroneously changing
wake_up_interruptible() to wake_up_interruptible_all() did not
result in any behavior change. However, using
wake_up_interruptible_all() on a wait queue without exclusive
waiters is fundamentally wrong.
Go back to using wake_up_interruptible() to wake all waiters.
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20220526203056.81123-1-john.ogness@linutronix.de
Diffstat (limited to 'kernel/printk')
| -rw-r--r-- | kernel/printk/printk.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index a3e1035929b0..ea3dd55709e7 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -3904,7 +3904,7 @@ static void wake_up_klogd_work_func(struct irq_work *irq_work) } if (pending & PRINTK_PENDING_WAKEUP) - wake_up_interruptible_all(&log_wait); + wake_up_interruptible(&log_wait); } static DEFINE_PER_CPU(struct irq_work, wake_up_klogd_work) = |