<rdar://problem/10103468>

I started work on being able to add symbol files after a debug session
had started with a new "target symfile add" command and quickly ran into
problems with stale Address objects in breakpoint locations that had 
lldb_private::Section pointers into modules that had been removed or 
replaced. This also let to grabbing stale modules from those sections. 
So I needed to thread harded the Address, Section and related objects.

To do this I modified the ModuleChild class to now require a ModuleSP
on initialization so that a weak reference can created. I also changed
all places that were handing out "Section *" to have them hand out SectionSP.
All ObjectFile, SymbolFile and SymbolVendors were inheriting from ModuleChild
so all of the find plug-in, static creation function and constructors now
require ModuleSP references instead of Module *. 

Address objects now have weak references to their sections which can
safely go stale when a module gets destructed. 

This checkin doesn't complete the "target symfile add" command, but it
does get us a lot clioser to being able to do such things without a high
risk of crashing or memory corruption.




git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@151336 91177308-0d34-0410-b5e6-96231b3b80d8

1 files changed, 5 insertions, 5 deletions

diff --git a/include/lldb/API/SBSection.h b/include/lldb/API/SBSection.h
index c951cc13e..ed82f28c2 100644
--- a/include/lldb/API/SBSection.h
+++ b/include/lldb/API/SBSection.h
@@ -80,15 +80,15 @@ private:
     friend class SBModule;
     friend class SBTarget;
     
-    SBSection (const lldb_private::Section *section);
+    SBSection (const lldb::SectionSP &section_sp);
 
-    const lldb_private::Section *
-    GetSection();
+    lldb::SectionSP
+    GetSP() const;
     
     void
-    SetSection (const lldb_private::Section *section);
+    SetSP(const lldb::SectionSP &section_sp);
     
-    std::auto_ptr<lldb_private::SectionImpl> m_opaque_ap;
+    lldb::SectionWP m_opaque_wp;
 };