diff options
| author | Simon Glass <sjg@chromium.org> | 2014-04-10 20:01:36 -0600 |
|---|---|---|
| committer | Tom Rini <trini@ti.com> | 2014-05-29 17:52:03 -0400 |
| commit | 95856248ca93b9048d87264fbef67ca382975650 (patch) | |
| tree | 5898148e13d9130c5c41ad2962b56f61b4dbda89 | |
| parent | affb215626f91e717088a27081d24c473895d47d (diff) | |
main: Avoid unncessary strdup()/free()
It doesn't seem necessary to use memory allocation in this code. The setenv()
will make a copy anyway.
Signed-off-by: Simon Glass <sjg@chromium.org>
| -rw-r--r-- | common/main.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/common/main.c b/common/main.c index ce4512741..32618f139 100644 --- a/common/main.c +++ b/common/main.c @@ -10,7 +10,6 @@ #include <common.h> #include <autoboot.h> #include <cli.h> -#include <malloc.h> #include <version.h> DECLARE_GLOBAL_DATA_PTR; @@ -26,10 +25,9 @@ static void modem_init(void) #ifdef CONFIG_MODEM_SUPPORT debug("DEBUG: main_loop: gd->do_mdm_init=%lu\n", gd->do_mdm_init); if (gd->do_mdm_init) { - char *str = strdup(getenv("mdm_cmd")); + char *str = getenv("mdm_cmd"); + setenv("preboot", str); /* set or delete definition */ - if (str != NULL) - free(str); mdm_init(); /* wait for modem connection */ } #endif /* CONFIG_MODEM_SUPPORT */ |