aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStacey Gammon <gammon@elastic.co>2018-06-01 11:35:58 -0400
committerGitHub <noreply@github.com>2018-06-01 11:35:58 -0400
commit7440e9734d69f15d18012e0dd84fc05d4184b369 (patch)
treed7162872188f2aa28065ba5a9fea9af18756dfc8
parenta2f3922f03fd5b5617f97d928e3e15cf7c185d6f (diff)
Accessibility updates (#19561)
* Announce full screen mode to screen reader, use extra helpful text in panel title input * Update jest snapshots * See if removing full sceen mode aria label fixes snapshot test on jenkins. * Bring back EuiScreenReadyOnly to confirm it is breaking snapshot tests * Try updating baselines with slightly larger width for the screen * Move screenready to external, non styled div, go back to original browser size and snapshots * update snaphots
-rw-r--r--src/core_plugins/kibana/public/dashboard/components/__snapshots__/exit_full_screen_button.test.js.snap52
-rw-r--r--src/core_plugins/kibana/public/dashboard/components/exit_full_screen_button.js36
-rw-r--r--src/core_plugins/kibana/public/dashboard/panel/panel_header/panel_options_menu_form.js1
-rw-r--r--test/functional/screenshots/baseline/area_chart.pngbin108470 -> 46032 bytes
4 files changed, 53 insertions, 36 deletions
diff --git a/src/core_plugins/kibana/public/dashboard/components/__snapshots__/exit_full_screen_button.test.js.snap b/src/core_plugins/kibana/public/dashboard/components/__snapshots__/exit_full_screen_button.test.js.snap
index 8f8032a48..b43670b5b 100644
--- a/src/core_plugins/kibana/public/dashboard/components/__snapshots__/exit_full_screen_button.test.js.snap
+++ b/src/core_plugins/kibana/public/dashboard/components/__snapshots__/exit_full_screen_button.test.js.snap
@@ -1,33 +1,41 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`is rendered 1`] = `
-<div
- class="exitFullScreenButton"
->
- <button
- aria-label="Exit full screen mode"
- class="kuiButton exitFullScreenMode"
- type="hollow"
+<div>
+ <p
+ aria-live="polite"
+ class="euiScreenReaderOnly"
>
- <span
- class="kuiButton__inner"
+ In full screen mode, press ESC to exit.
+ </p>
+ <div
+ class="exitFullScreenButton"
+ >
+ <button
+ aria-label="Exit full screen mode"
+ class="kuiButton exitFullScreenMode"
+ type="hollow"
>
- <span>
- <span
- class="exitFullScreenModeLogo"
- data-test-subj="exitFullScreenModeLogo"
- />
- <span
- class="exitFullScreenModeText"
- data-test-subj="exitFullScreenModeText"
- >
- Exit full screen
+ <span
+ class="kuiButton__inner"
+ >
+ <span>
<span
- class="kuiIcon fa fa-angle-left"
+ class="exitFullScreenModeLogo"
+ data-test-subj="exitFullScreenModeLogo"
/>
+ <span
+ class="exitFullScreenModeText"
+ data-test-subj="exitFullScreenModeText"
+ >
+ Exit full screen
+ <span
+ class="kuiIcon fa fa-angle-left"
+ />
+ </span>
</span>
</span>
- </span>
- </button>
+ </button>
+ </div>
</div>
`;
diff --git a/src/core_plugins/kibana/public/dashboard/components/exit_full_screen_button.js b/src/core_plugins/kibana/public/dashboard/components/exit_full_screen_button.js
index 5038875f7..72309f076 100644
--- a/src/core_plugins/kibana/public/dashboard/components/exit_full_screen_button.js
+++ b/src/core_plugins/kibana/public/dashboard/components/exit_full_screen_button.js
@@ -27,6 +27,7 @@ import {
import {
keyCodes,
+ EuiScreenReaderOnly,
} from '@elastic/eui';
export class ExitFullScreenButton extends PureComponent {
@@ -49,21 +50,28 @@ export class ExitFullScreenButton extends PureComponent {
render() {
return (
- <div
- className="exitFullScreenButton"
- >
- <KuiButton
- type="hollow"
- aria-label="Exit full screen mode"
- className="exitFullScreenMode"
- onClick={this.props.onExitFullScreenMode}
+ <div>
+ <EuiScreenReaderOnly>
+ <p aria-live="polite">
+ In full screen mode, press ESC to exit.
+ </p>
+ </EuiScreenReaderOnly>
+ <div
+ className="exitFullScreenButton"
>
- <span className="exitFullScreenModeLogo" data-test-subj="exitFullScreenModeLogo"/>
- <span className="exitFullScreenModeText" data-test-subj="exitFullScreenModeText">
- Exit full screen
- <span className="kuiIcon fa fa-angle-left"/>
- </span>
- </KuiButton>
+ <KuiButton
+ type="hollow"
+ aria-label="Exit full screen mode"
+ className="exitFullScreenMode"
+ onClick={this.props.onExitFullScreenMode}
+ >
+ <span className="exitFullScreenModeLogo" data-test-subj="exitFullScreenModeLogo"/>
+ <span className="exitFullScreenModeText" data-test-subj="exitFullScreenModeText">
+ Exit full screen
+ <span className="kuiIcon fa fa-angle-left"/>
+ </span>
+ </KuiButton>
+ </div>
</div>
);
}
diff --git a/src/core_plugins/kibana/public/dashboard/panel/panel_header/panel_options_menu_form.js b/src/core_plugins/kibana/public/dashboard/panel/panel_header/panel_options_menu_form.js
index 121aaacd0..35f668484 100644
--- a/src/core_plugins/kibana/public/dashboard/panel/panel_header/panel_options_menu_form.js
+++ b/src/core_plugins/kibana/public/dashboard/panel/panel_header/panel_options_menu_form.js
@@ -54,6 +54,7 @@ export function PanelOptionsMenuForm({ title, onReset, onUpdatePanelTitle, onClo
value={title}
onChange={onInputChange}
onKeyDown={onKeyDown}
+ aria-label="Changes to this input are applied immediately. Press enter to exit."
/>
<KuiButton
buttonType="hollow"
diff --git a/test/functional/screenshots/baseline/area_chart.png b/test/functional/screenshots/baseline/area_chart.png
index 75240f4db..9cb3458e7 100644
--- a/test/functional/screenshots/baseline/area_chart.png
+++ b/test/functional/screenshots/baseline/area_chart.png
Binary files differ