summaryrefslogtreecommitdiff
path: root/fs/file.c
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2008-05-10 10:08:32 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2008-05-16 17:22:52 -0400
commiteceea0b3df05ed262ae32e0c6340cc7a3626632d (patch)
tree73e5e33acace9187d5729a9a8c8ff53c3d720d52 /fs/file.c
parentadbecb128cd2cc5d14b0ebef6d020ced0efd0ec6 (diff)
[PATCH] avoid multiplication overflows and signedness issues for max_fds
Limit sysctl_nr_open - we don't want ->max_fds to exceed MAX_INT and we don't want size calculation for ->fd[] to overflow. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/file.c')
-rw-r--r--fs/file.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/file.c b/fs/file.c
index 0f705c7cfef..7b3887e054d 100644
--- a/fs/file.c
+++ b/fs/file.c
@@ -26,6 +26,8 @@ struct fdtable_defer {
};
int sysctl_nr_open __read_mostly = 1024*1024;
+int sysctl_nr_open_min = BITS_PER_LONG;
+int sysctl_nr_open_max = 1024 * 1024; /* raised later */
/*
* We use this list to defer free fdtables that have vmalloced
@@ -405,6 +407,8 @@ void __init files_defer_init(void)
int i;
for_each_possible_cpu(i)
fdtable_defer_list_init(i);
+ sysctl_nr_open_max = min((size_t)INT_MAX, ~(size_t)0/sizeof(void *)) &
+ -BITS_PER_LONG;
}
struct files_struct init_files = {