diff options
| author | Chris Redpath <chris.redpath@arm.com> | 2012-06-29 16:07:46 +0100 |
|---|---|---|
| committer | Jon Medhurst <tixy@linaro.org> | 2013-07-01 11:04:25 +0100 |
| commit | 5705f5f9c6d47d59af73145b5febd1b1d5a56775 (patch) | |
| tree | 4d15f3a8dae9904d467b4b6c791f1e0e857e7a4d /drivers | |
| parent | 7195cb14440127f4bcda912dd51cfc2760f9f25e (diff) | |
ARM HDLCD: Review comments from Liviu - extraneous memcpy
Signed-off-by: Chris Redpath <chris.redpath@arm.com>
Reviewed-By: Liviu Dudau <liviu.dudau@arm.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/video/arm-hdlcd.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/video/arm-hdlcd.c b/drivers/video/arm-hdlcd.c index 8d5409db6b1..f16bb882e0c 100644 --- a/drivers/video/arm-hdlcd.c +++ b/drivers/video/arm-hdlcd.c @@ -262,10 +262,10 @@ static int hdlcd_set_par(struct fb_info *info) if (!memcmp(&info->var, &cached_var_screeninfo, sizeof(struct fb_var_screeninfo))) { if(old_yoffset != info->var.yoffset) { - /* we only changed yoffset */ + /* we only changed yoffset, and we already + * already recorded it a couple lines up + */ hdlcd_pan_display(&info->var, info); - memcpy(&cached_var_screeninfo, &info->var, - sizeof(struct fb_var_screeninfo)); } /* or no change */ return 0; |