From 5705f5f9c6d47d59af73145b5febd1b1d5a56775 Mon Sep 17 00:00:00 2001 From: Chris Redpath Date: Fri, 29 Jun 2012 16:07:46 +0100 Subject: ARM HDLCD: Review comments from Liviu - extraneous memcpy Signed-off-by: Chris Redpath Reviewed-By: Liviu Dudau --- drivers/video/arm-hdlcd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'drivers') diff --git a/drivers/video/arm-hdlcd.c b/drivers/video/arm-hdlcd.c index 8d5409db6b1..f16bb882e0c 100644 --- a/drivers/video/arm-hdlcd.c +++ b/drivers/video/arm-hdlcd.c @@ -262,10 +262,10 @@ static int hdlcd_set_par(struct fb_info *info) if (!memcmp(&info->var, &cached_var_screeninfo, sizeof(struct fb_var_screeninfo))) { if(old_yoffset != info->var.yoffset) { - /* we only changed yoffset */ + /* we only changed yoffset, and we already + * already recorded it a couple lines up + */ hdlcd_pan_display(&info->var, info); - memcpy(&cached_var_screeninfo, &info->var, - sizeof(struct fb_var_screeninfo)); } /* or no change */ return 0; -- cgit v1.2.3