diff options
author | Milo Casagrande <milo@ubuntu.com> | 2013-03-26 09:59:38 +0100 |
---|---|---|
committer | Milo Casagrande <milo@ubuntu.com> | 2013-03-26 09:59:38 +0100 |
commit | c217c6faa3bb2d876c38a49a175df39fdb6e29f4 (patch) | |
tree | 425bde87529a35b37485aed6a21942c4ae0bf616 /linaro_image_tools | |
parent | 873a852567f6e05b1561db3cdaa0a5cead6ca28a (diff) |
Fixed regression when using actual dtb file name, not the general one.
Diffstat (limited to 'linaro_image_tools')
-rw-r--r-- | linaro_image_tools/media_create/android_boards.py | 29 | ||||
-rw-r--r-- | linaro_image_tools/media_create/boards.py | 2 | ||||
-rw-r--r-- | linaro_image_tools/media_create/tests/test_media_create.py | 10 |
3 files changed, 35 insertions, 6 deletions
diff --git a/linaro_image_tools/media_create/android_boards.py b/linaro_image_tools/media_create/android_boards.py index 668872f..52a92b4 100644 --- a/linaro_image_tools/media_create/android_boards.py +++ b/linaro_image_tools/media_create/android_boards.py @@ -514,6 +514,35 @@ class AndroidArndaleConfig(AndroidSamsungConfig, ArndaleConfig): self._extra_serial_options = 'ttySAC2,115200n8' self._extra_boot_args_options = 'rootdelay=3' + def _get_bootcmd(self, i_img_data, d_img_data): + """Get the bootcmd for this board. + + In general subclasses should not have to override this. + """ + replacements = dict( + fatload_command=self.fatload_command, uimage_path=self.uimage_path, + mmc_option=self.mmc_option, kernel_addr=self.kernel_addr, + initrd_addr=self.initrd_addr, dtb_addr=self.dtb_addr) + boot_script = ( + ("%(fatload_command)s mmc %(mmc_option)s %(kernel_addr)s " + + "%(uimage_path)suImage; ")) % replacements + if i_img_data is not None: + boot_script += ( + ("%(fatload_command)s mmc %(mmc_option)s %(initrd_addr)s " + + "%(uimage_path)suInitrd; ")) % replacements + if d_img_data is not None: + assert self.dtb_addr is not None, ( + "Need a dtb_addr when passing d_img_data") + boot_script += (("%(fatload_command)s mmc %(mmc_option)s " + "%(dtb_addr)s ")) % replacements + boot_script += "%s; " % d_img_data + boot_script += (("bootm %(kernel_addr)s")) % replacements + if i_img_data is not None: + boot_script += ((" %(initrd_addr)s")) % replacements + if d_img_data is not None: + boot_script += ((" %(dtb_addr)s")) % replacements + return boot_script + def populate_raw_partition(self, boot_device_or_file, chroot_dir): boot_bin_0 = {'name': 'arndale-bl1.bin', 'seek': 1} boot_bin_1 = {'name': 'u-boot-mmc-spl.bin', 'seek': 17} diff --git a/linaro_image_tools/media_create/boards.py b/linaro_image_tools/media_create/boards.py index 85284bc..9a4efb6 100644 --- a/linaro_image_tools/media_create/boards.py +++ b/linaro_image_tools/media_create/boards.py @@ -535,7 +535,7 @@ class BoardConfig(object): "Need a dtb_addr when passing d_img_data") boot_script += (("%(fatload_command)s mmc %(mmc_option)s " "%(dtb_addr)s ")) % replacements - boot_script += "%s; " % d_img_data + boot_script += "board.dtb; " boot_script += (("bootm %(kernel_addr)s")) % replacements if i_img_data is not None: boot_script += ((" %(initrd_addr)s")) % replacements diff --git a/linaro_image_tools/media_create/tests/test_media_create.py b/linaro_image_tools/media_create/tests/test_media_create.py index 03b8f82..d14464c 100644 --- a/linaro_image_tools/media_create/tests/test_media_create.py +++ b/linaro_image_tools/media_create/tests/test_media_create.py @@ -2002,7 +2002,7 @@ class TestGetBootCmd(TestCase): 'root=UUID=deadbeef rootwait ro', 'bootcmd': 'fatload mmc 0:2 0x90000000 uImage; ' 'fatload mmc 0:2 0x92000000 uInitrd; ' - 'fatload mmc 0:2 0x91ff0000 mx51.dtb; ' + 'fatload mmc 0:2 0x91ff0000 board.dtb; ' 'bootm 0x90000000 0x92000000 0x91ff0000', 'fdt_high': '0xffffffff', 'initrd_high': '0xffffffff'} @@ -2126,7 +2126,7 @@ class TestGetBootCmd(TestCase): 'mem=456M@0x80000000 mem=512M@0xA0000000', 'bootcmd': 'fatload mmc 0:1 0x80200000 uImage; ' 'fatload mmc 0:1 0x81600000 uInitrd; ' - 'fatload mmc 0:1 0x815f0000 panda.dtb; ' + 'fatload mmc 0:1 0x815f0000 board.dtb; ' 'bootm 0x80200000 0x81600000 0x815f0000', 'fdt_high': '0xffffffff', 'initrd_high': '0xffffffff'} @@ -2149,7 +2149,7 @@ class TestGetBootCmd(TestCase): 'omapfb.mode=dvi:1280x720MR-16@60 mpurate=${mpurate}', 'bootcmd': 'fatload mmc 0:1 0x80000000 uImage; ' 'fatload mmc 0:1 0x81600000 uInitrd; ' - 'fatload mmc 0:1 0x815f0000 beagle.dtb; ' + 'fatload mmc 0:1 0x815f0000 board.dtb; ' 'bootm 0x80000000 0x81600000 0x815f0000', 'fdt_high': '0xffffffff', 'initrd_high': '0xffffffff'} @@ -2172,7 +2172,7 @@ class TestGetBootCmd(TestCase): 'omapfb.mode=dvi:1280x720MR-16@60 mpurate=${mpurate}', 'bootcmd': 'fatload mmc 0:1 0x80000000 uImage; ' 'fatload mmc 0:1 0x81600000 uInitrd; ' - 'fatload mmc 0:1 0x815f0000 igep.dtb; ' + 'fatload mmc 0:1 0x815f0000 board.dtb; ' 'bootm 0x80000000 0x81600000 0x815f0000', 'fdt_high': '0xffffffff', 'initrd_high': '0xffffffff'} @@ -2196,7 +2196,7 @@ class TestGetBootCmd(TestCase): 'omapfb.mode=dvi:${dvimode}', 'bootcmd': 'fatload mmc 0:1 0x80000000 uImage; ' 'fatload mmc 0:1 0x81600000 uInitrd; ' - 'fatload mmc 0:1 0x815f0000 overo.dtb; ' + 'fatload mmc 0:1 0x815f0000 board.dtb; ' 'bootm 0x80000000 0x81600000 0x815f0000', 'fdt_high': '0xffffffff', 'initrd_high': '0xffffffff'} |