summaryrefslogtreecommitdiff
path: root/ShellPkg
diff options
context:
space:
mode:
authorShumin Qiu <shumin.qiu@intel.com>2014-01-28 00:37:11 +0000
committershenshushi <shenshushi@6f19259b-4bc3-4df7-8a09-765794883524>2014-01-28 00:37:11 +0000
commit7bc3ec3d80985b10bf8f4f9c4203ccd8c1cd6e7e (patch)
treedb164747641d27bc13fc7c97336d150f6dd68cb4 /ShellPkg
parent5c1e62f35a5a5ad28b2f7f29ae0bf1d255b229a3 (diff)
1. Fix several comments in function headers for 'ShellProtocol.c', 'ShellProtocol.h' and 'Ls.c'. 2. Remove the initialization of variable 'CalleeExitStatus' in function 'RunScriptFileHandle' of 'Shell.c' from its declarartion.
Signed-off-by: Shumin Qiu <shumin.qiu@intel.com> Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com> git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15190 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'ShellPkg')
-rw-r--r--ShellPkg/Application/Shell/Shell.c4
-rw-r--r--ShellPkg/Application/Shell/ShellProtocol.c1
-rw-r--r--ShellPkg/Application/Shell/ShellProtocol.h2
-rw-r--r--ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c4
4 files changed, 6 insertions, 5 deletions
diff --git a/ShellPkg/Application/Shell/Shell.c b/ShellPkg/Application/Shell/Shell.c
index e56b3f836..dc99c5c97 100644
--- a/ShellPkg/Application/Shell/Shell.c
+++ b/ShellPkg/Application/Shell/Shell.c
@@ -2412,9 +2412,11 @@ RunScriptFileHandle (
CONST CHAR16 *CurDir;
UINTN LineCount;
CHAR16 LeString[50];
- SHELL_STATUS CalleeExitStatus = SHELL_SUCCESS;
+ SHELL_STATUS CalleeExitStatus;
ASSERT(!ShellCommandGetScriptExit());
+
+ CalleeExitStatus = SHELL_SUCCESS;
PreScriptEchoState = ShellCommandGetEchoState();
diff --git a/ShellPkg/Application/Shell/ShellProtocol.c b/ShellPkg/Application/Shell/ShellProtocol.c
index fe63e6a8d..9260d9b02 100644
--- a/ShellPkg/Application/Shell/ShellProtocol.c
+++ b/ShellPkg/Application/Shell/ShellProtocol.c
@@ -1367,7 +1367,6 @@ EfiShellEnablePageBreak (
variables with the format 'x=y', where x is the
environment variable name and y is the value. If this
is NULL, then the current shell environment is used.
- @param StatusCode Points to the status code returned by the command.
@param[out] ExitDataSize ExitDataSize as returned from gBS->StartImage
@param[out] ExitData ExitData as returned from gBS->StartImage
diff --git a/ShellPkg/Application/Shell/ShellProtocol.h b/ShellPkg/Application/Shell/ShellProtocol.h
index 4920d8283..ff123277c 100644
--- a/ShellPkg/Application/Shell/ShellProtocol.h
+++ b/ShellPkg/Application/Shell/ShellProtocol.h
@@ -446,8 +446,6 @@ EfiShellEnablePageBreak (
@param[out] ExitDataSize ExitDataSize as returned from gBS->StartImage
@param[out] ExitData ExitData as returned from gBS->StartImage
- @param StatusCode Points to the status code returned by the command.
-
@retval EFI_SUCCESS The command executed successfully. The status code
returned by the command is pointed to by StatusCode.
@retval EFI_INVALID_PARAMETER The parameters are invalid.
diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c
index 60b8c5b49..fa588ff7f 100644
--- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c
+++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c
@@ -295,7 +295,9 @@ PrintNonSfoHeader(
/**
print out the footer when not using standard format output.
- @param[in] Path String with starting path.
+ @param[in] Files The number of files.
+ @param[in] Size The size of files in bytes.
+ @param[in] Dirs The number of directories.
**/
VOID
EFIAPI