|author||David Spickett <firstname.lastname@example.org>||2021-10-07 11:49:03 +0100|
|committer||David Spickett <email@example.com>||2021-10-07 11:49:03 +0100|
Previously the post-commit builds would have branch main. Now they have branch master, of the pre-commit checks repo. Instead of looking for the branch, just look for the Phabricator review number in the env. Any build without that is post commit. Change-Id: I80214d5c29922dd60daf250b7a927085d7657016
1 files changed, 5 insertions, 5 deletions
diff --git a/monitor/buildkite_status.py b/monitor/buildkite_status.py
index 07a848f..09c8d3f 100755
@@ -64,11 +64,11 @@ def get_last_finished_build_status(organisation, job_name,
builds = get_pipeline_builds(organisation, pipeline)
for build in builds:
- # There are two kinds of builds. Ones triggered from phab reviews
- # and ones run perdidically to post commit build the main branch.
- # For the status page failures in pre-commit aren't very useful
- # so we ignore them.
- if build['branch'] != 'main':
+ # There are two kinds of builds. Those triggered from phab reviews
+ # and those run perdidically to post-commit build the main branch.
+ # For the status page we ignore pre-commit builds.
+ # ph_buildable_revision is set if Phabricator triggered this build.
+ if 'ph_buildable_revision' in build['env']:
# Where each "job" is a config e.g. AArch64, MacOS, C++20 etc.