Remove local keywords and uninitialized variables
Remove keywords such as "let", "typeset", and "local" that
are defined in BASH. Also, clean up any unused variables in
the process.
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
Signed-off-by: Lisa Nguyen <lisa.nguyen@linaro.org>
diff --git a/cpufreq/cpufreq_03.sh b/cpufreq/cpufreq_03.sh
index acd1c2a..32e2114 100755
--- a/cpufreq/cpufreq_03.sh
+++ b/cpufreq/cpufreq_03.sh
@@ -29,12 +29,12 @@
check_governor() {
- local cpu=$1
- local newgov=$2
+ cpu=$1
+ newgov=$2
shift 2
- local oldgov=$(get_governor $cpu)
+ oldgov=$(get_governor $cpu)
set_governor $cpu $newgov
diff --git a/cpufreq/cpufreq_04.sh b/cpufreq/cpufreq_04.sh
index 98b0fa1..6813a2a 100755
--- a/cpufreq/cpufreq_04.sh
+++ b/cpufreq/cpufreq_04.sh
@@ -29,13 +29,13 @@
check_frequency() {
- local cpu=$1
- local newfreq=$2
+ cpu=$1
+ newfreq=$2
shift 2
- local oldgov=$(get_governor $cpu)
- local oldfreq=$(get_frequency $cpu)
+ oldgov=$(get_governor $cpu)
+ oldfreq=$(get_frequency $cpu)
set_governor $cpu userspace
set_frequency $cpu $newfreq
diff --git a/cpufreq/cpufreq_05.sh b/cpufreq/cpufreq_05.sh
index f74a23e..862d310 100755
--- a/cpufreq/cpufreq_05.sh
+++ b/cpufreq/cpufreq_05.sh
@@ -32,23 +32,23 @@
trap restore_governors HUP INT TERM
switch_ondemand() {
- local cpu=$1
+ cpu=$1
set_governor $cpu 'ondemand'
}
switch_conservative() {
- local cpu=$1
+ cpu=$1
set_governor $cpu 'conservative'
}
switch_userspace() {
- local cpu=$1
+ cpu=$1
set_governor $cpu 'userspace'
}
check_governor() {
- local cpu=$1
- local gov=$2
+ cpu=$1
+ gov=$2
if [ -d $CPU_PATH/$cpu/cpufreq/$gov ]; then
GOV_PATH=$CPU_PATH/$cpu/cpufreq/$gov
diff --git a/cpufreq/cpufreq_06.sh b/cpufreq/cpufreq_06.sh
index 803b937..a6fbd15 100755
--- a/cpufreq/cpufreq_06.sh
+++ b/cpufreq/cpufreq_06.sh
@@ -31,8 +31,8 @@
compute_freq_ratio() {
- local cpu=$1
- local freq=$2
+ cpu=$1
+ freq=$2
set_frequency $cpu $freq
@@ -75,8 +75,8 @@
check_freq_deviation() {
- local cpu=$1
- local freq=$2
+ cpu=$1
+ freq=$2
check "deviation for frequency $(frequnit $freq)" __check_freq_deviation
@@ -84,7 +84,7 @@
check_deviation() {
- local cpu=$1
+ cpu=$1
set_governor $cpu userspace
diff --git a/cpufreq/cpufreq_07.sh b/cpufreq/cpufreq_07.sh
index 9f41c49..f5c9e2b 100755
--- a/cpufreq/cpufreq_07.sh
+++ b/cpufreq/cpufreq_07.sh
@@ -31,11 +31,10 @@
check_ondemand() {
- local cpu=$1
- local maxfreq=$(get_max_frequency $cpu)
- local minfreq=$(get_min_frequency $cpu)
- local curfreq=$(get_frequency $cpu)
- local pid=
+ cpu=$1
+ maxfreq=$(get_max_frequency $cpu)
+ minfreq=$(get_min_frequency $cpu)
+ curfreq=$(get_frequency $cpu)
set_governor $cpu ondemand
diff --git a/cpufreq/cpufreq_08.sh b/cpufreq/cpufreq_08.sh
index 29b2b9f..f81976d 100755
--- a/cpufreq/cpufreq_08.sh
+++ b/cpufreq/cpufreq_08.sh
@@ -30,10 +30,8 @@
CPUBURN=../utils/cpuburn
check_frequency() {
- local cpu=$1
- local freq=$2
- local curfreq=
- local pid=
+ cpu=$1
+ freq=$2
$CPUBURN $cpu &
pid=$!
@@ -54,10 +52,10 @@
check_userspace() {
- local cpu=$1
- local maxfreq=$(get_max_frequency $cpu)
- local minfreq=$(get_min_frequency $cpu)
- local curfreq=$(get_frequency $cpu)
+ cpu=$1
+ maxfreq=$(get_max_frequency $cpu)
+ minfreq=$(get_min_frequency $cpu)
+ curfreq=$(get_frequency $cpu)
set_governor $cpu userspace
diff --git a/cpufreq/cpufreq_09.sh b/cpufreq/cpufreq_09.sh
index 746c7de..2ba1652 100755
--- a/cpufreq/cpufreq_09.sh
+++ b/cpufreq/cpufreq_09.sh
@@ -31,9 +31,9 @@
check_powersave() {
- local cpu=$1
- local minfreq=$(get_min_frequency $cpu)
- local curfreq=$(get_frequency $cpu)
+ cpu=$1
+ minfreq=$(get_min_frequency $cpu)
+ curfreq=$(get_frequency $cpu)
set_governor $cpu powersave
diff --git a/cpufreq/cpufreq_sanity.sh b/cpufreq/cpufreq_sanity.sh
index 24784f9..6aba317 100755
--- a/cpufreq/cpufreq_sanity.sh
+++ b/cpufreq/cpufreq_sanity.sh
@@ -33,7 +33,7 @@
check_cpufreq_sysfs_entry() {
- local dirpath=$CPU_PATH/cpufreq
+ dirpath=$CPU_PATH/cpufreq
test -d $dirpath
if [ $? -ne 0 ]; then