Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 1 | #!/usr/bin/python3 |
| 2 | import argparse |
| 3 | import os |
| 4 | import sys |
| 5 | import subprocess |
| 6 | import traceback |
| 7 | import yaml |
Chase Qi | 827203c | 2019-03-07 16:19:15 +0800 | [diff] [blame] | 8 | import magic |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 9 | |
Chase Qi | 3029053 | 2018-11-20 18:54:43 +0800 | [diff] [blame] | 10 | run_pycodestyle = False |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 11 | try: |
Chase Qi | 3029053 | 2018-11-20 18:54:43 +0800 | [diff] [blame] | 12 | import pycodestyle |
| 13 | run_pycodestyle = True |
| 14 | except ImportError: |
| 15 | print("pycodestyle is not available!") |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 16 | |
| 17 | |
| 18 | def print_stderr(message): |
| 19 | sys.stderr.write(message) |
| 20 | sys.stderr.write("\n") |
| 21 | |
| 22 | |
Milosz Wasilewski | 65d6f0e | 2016-11-08 13:54:59 +0000 | [diff] [blame] | 23 | def publish_result(result_message_list, args): |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 24 | result_message = '\n'.join(result_message_list) |
Milosz Wasilewski | 65d6f0e | 2016-11-08 13:54:59 +0000 | [diff] [blame] | 25 | try: |
| 26 | f = open(args.result_file, 'a') |
| 27 | f.write("\n\n") |
| 28 | f.write(result_message) |
| 29 | f.write("\n\n") |
| 30 | f.close() |
| 31 | except IOError as e: |
| 32 | print_stderr("Cannot write to result file: %s" % args.result_file) |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 33 | print_stderr(result_message) |
| 34 | |
| 35 | |
Dan Rue | 8ec540c | 2018-01-25 14:38:12 -0600 | [diff] [blame] | 36 | def detect_abi(): |
| 37 | # Retrieve the current canonical abi from |
| 38 | # automated/lib/sh-test-lib:detect_abi |
| 39 | return subprocess.check_output( |
| 40 | ". automated/lib/sh-test-lib && detect_abi && echo $abi", |
| 41 | shell=True).decode('utf-8').strip() |
| 42 | |
| 43 | |
Chase Qi | 3029053 | 2018-11-20 18:54:43 +0800 | [diff] [blame] | 44 | def pycodestyle_check(filepath, args): |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 45 | _fmt = "%(row)d:%(col)d: %(code)s %(text)s" |
| 46 | options = { |
Chase Qi | 3029053 | 2018-11-20 18:54:43 +0800 | [diff] [blame] | 47 | 'ignore': args.pycodestyle_ignore, |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 48 | "show_source": True} |
Chase Qi | 3029053 | 2018-11-20 18:54:43 +0800 | [diff] [blame] | 49 | pycodestyle_checker = pycodestyle.StyleGuide(options) |
| 50 | fchecker = pycodestyle_checker.checker_class( |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 51 | filepath, |
Chase Qi | 3029053 | 2018-11-20 18:54:43 +0800 | [diff] [blame] | 52 | options=pycodestyle_checker.options) |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 53 | fchecker.check_all() |
| 54 | if fchecker.report.file_errors > 0: |
| 55 | result_message_list = [] |
Chase Qi | 3029053 | 2018-11-20 18:54:43 +0800 | [diff] [blame] | 56 | result_message_list.append("* PYCODESTYLE: [FAILED]: " + filepath) |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 57 | fchecker.report.print_statistics() |
| 58 | for line_number, offset, code, text, doc in fchecker.report._deferred_print: |
| 59 | result_message_list.append( |
| 60 | _fmt % { |
| 61 | 'path': filepath, |
| 62 | 'row': fchecker.report.line_offset + line_number, |
| 63 | 'col': offset + 1, |
| 64 | 'code': code, 'text': text, |
| 65 | }) |
Milosz Wasilewski | 65d6f0e | 2016-11-08 13:54:59 +0000 | [diff] [blame] | 66 | publish_result(result_message_list, args) |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 67 | return 1 |
| 68 | else: |
Chase Qi | 3029053 | 2018-11-20 18:54:43 +0800 | [diff] [blame] | 69 | message = "* PYCODESTYLE: [PASSED]: " + filepath |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 70 | print_stderr(message) |
| 71 | return 0 |
| 72 | |
Milosz Wasilewski | 7ae041c | 2016-11-07 11:10:06 +0000 | [diff] [blame] | 73 | |
Dan Rue | 8ec540c | 2018-01-25 14:38:12 -0600 | [diff] [blame] | 74 | def validate_yaml_contents(filepath, args): |
Chase Qi | 827203c | 2019-03-07 16:19:15 +0800 | [diff] [blame] | 75 | def validate_testdef_yaml(y, args): |
Milosz Wasilewski | c69b409 | 2017-10-20 14:04:52 +0100 | [diff] [blame] | 76 | result_message_list = [] |
Milosz Wasilewski | c69b409 | 2017-10-20 14:04:52 +0100 | [diff] [blame] | 77 | if 'metadata' not in y.keys(): |
| 78 | result_message_list.append("* METADATA [FAILED]: " + filepath) |
| 79 | result_message_list.append("\tmetadata section missing") |
| 80 | publish_result(result_message_list, args) |
| 81 | exit(1) |
| 82 | metadata_dict = y['metadata'] |
| 83 | mandatory_keys = set([ |
| 84 | 'name', |
| 85 | 'format', |
| 86 | 'description', |
| 87 | 'maintainer', |
| 88 | 'os', |
| 89 | 'devices']) |
| 90 | if not mandatory_keys.issubset(set(metadata_dict.keys())): |
| 91 | result_message_list.append("* METADATA [FAILED]: " + filepath) |
| 92 | result_message_list.append("\tmandatory keys missing: %s" % |
| 93 | mandatory_keys.difference(set(metadata_dict.keys()))) |
| 94 | result_message_list.append("\tactual keys present: %s" % |
| 95 | metadata_dict.keys()) |
| 96 | publish_result(result_message_list, args) |
| 97 | return 1 |
| 98 | for key in mandatory_keys: |
| 99 | if len(metadata_dict[key]) == 0: |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 100 | result_message_list.append("* METADATA [FAILED]: " + filepath) |
Milosz Wasilewski | c69b409 | 2017-10-20 14:04:52 +0100 | [diff] [blame] | 101 | result_message_list.append("\t%s has no content" % key) |
Milosz Wasilewski | 65d6f0e | 2016-11-08 13:54:59 +0000 | [diff] [blame] | 102 | publish_result(result_message_list, args) |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 103 | return 1 |
Milosz Wasilewski | c69b409 | 2017-10-20 14:04:52 +0100 | [diff] [blame] | 104 | result_message_list.append("* METADATA [PASSED]: " + filepath) |
| 105 | publish_result(result_message_list, args) |
Dan Rue | 8ec540c | 2018-01-25 14:38:12 -0600 | [diff] [blame] | 106 | return 0 |
| 107 | |
| 108 | def validate_skipgen_yaml(filepath, args): |
| 109 | abi = detect_abi() |
| 110 | # Run skipgen on skipgen yaml file to check for output and errors |
| 111 | skips = subprocess.check_output( |
| 112 | "automated/bin/{}/skipgen {}".format(abi, filepath), |
| 113 | shell=True).decode('utf-8').strip() |
| 114 | if len(skips.split('\n')) < 1: |
| 115 | publish_result(["* SKIPGEN [FAILED]: " + filepath + " - No skips found"], args) |
| 116 | return 1 |
| 117 | publish_result(["* SKIPGEN [PASSED]: " + filepath], args) |
| 118 | return 0 |
| 119 | |
| 120 | filecontent = None |
| 121 | try: |
| 122 | with open(filepath, "r") as f: |
| 123 | filecontent = f.read() |
| 124 | except FileNotFoundError: |
| 125 | publish_result(["* YAMLVALIDCONTENTS [PASSED]: " + filepath + " - deleted"], args) |
| 126 | return 0 |
| 127 | y = yaml.load(filecontent) |
Chase Qi | 827203c | 2019-03-07 16:19:15 +0800 | [diff] [blame] | 128 | if 'run' in y.keys(): |
| 129 | # test definition yaml file |
| 130 | return validate_testdef_yaml(y, args) |
Dan Rue | 8ec540c | 2018-01-25 14:38:12 -0600 | [diff] [blame] | 131 | elif 'skiplist' in y.keys(): |
| 132 | # skipgen yaml file |
| 133 | return validate_skipgen_yaml(filepath, args) |
| 134 | else: |
Chase Qi | 827203c | 2019-03-07 16:19:15 +0800 | [diff] [blame] | 135 | publish_result(["* YAMLVALIDCONTENTS [SKIPPED]: " + filepath + " - Unknown yaml type detected"], args) |
| 136 | return 0 |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 137 | |
Milosz Wasilewski | 7ae041c | 2016-11-07 11:10:06 +0000 | [diff] [blame] | 138 | |
Milosz Wasilewski | 65d6f0e | 2016-11-08 13:54:59 +0000 | [diff] [blame] | 139 | def validate_yaml(filename, args): |
Milosz Wasilewski | c69b409 | 2017-10-20 14:04:52 +0100 | [diff] [blame] | 140 | filecontent = None |
| 141 | try: |
| 142 | with open(filename, "r") as f: |
| 143 | filecontent = f.read() |
| 144 | except FileNotFoundError: |
| 145 | publish_result(["* YAMLVALID [PASSED]: " + filename + " - deleted"], args) |
| 146 | return 0 |
| 147 | try: |
Chase Qi | ed01743 | 2018-12-14 16:56:20 +0800 | [diff] [blame] | 148 | yaml.load(filecontent) |
Milosz Wasilewski | c69b409 | 2017-10-20 14:04:52 +0100 | [diff] [blame] | 149 | message = "* YAMLVALID: [PASSED]: " + filename |
| 150 | print_stderr(message) |
Chase Qi | 3029053 | 2018-11-20 18:54:43 +0800 | [diff] [blame] | 151 | except yaml.YAMLError: |
Milosz Wasilewski | c69b409 | 2017-10-20 14:04:52 +0100 | [diff] [blame] | 152 | message = "* YAMLVALID: [FAILED]: " + filename |
| 153 | result_message_list = [] |
| 154 | result_message_list.append(message) |
| 155 | result_message_list.append("\n\n") |
| 156 | exc_type, exc_value, exc_traceback = sys.exc_info() |
| 157 | for line in traceback.format_exception_only(exc_type, exc_value): |
| 158 | result_message_list.append(' ' + line) |
| 159 | publish_result(result_message_list, args) |
| 160 | return 1 |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 161 | return 0 |
| 162 | |
| 163 | |
| 164 | def validate_shell(filename, ignore_options): |
| 165 | ignore_string = "" |
Milosz Wasilewski | 65d6f0e | 2016-11-08 13:54:59 +0000 | [diff] [blame] | 166 | if args.shellcheck_ignore is not None: |
Chase Qi | ed01743 | 2018-12-14 16:56:20 +0800 | [diff] [blame] | 167 | # Exclude types of warnings in the following format: |
| 168 | # -e CODE1,CODE2.. |
| 169 | ignore_string = "-e %s" % ",".join(args.shellcheck_ignore) |
Milosz Wasilewski | ab7645a | 2016-11-07 10:45:34 +0000 | [diff] [blame] | 170 | if len(ignore_string) < 4: # contains only "-e " |
| 171 | ignore_string = "" |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 172 | cmd = 'shellcheck %s' % ignore_string |
Milosz Wasilewski | 65d6f0e | 2016-11-08 13:54:59 +0000 | [diff] [blame] | 173 | return validate_external(cmd, filename, "SHELLCHECK", args) |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 174 | |
| 175 | |
Milosz Wasilewski | 65d6f0e | 2016-11-08 13:54:59 +0000 | [diff] [blame] | 176 | def validate_php(filename, args): |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 177 | cmd = 'php -l' |
Milosz Wasilewski | 65d6f0e | 2016-11-08 13:54:59 +0000 | [diff] [blame] | 178 | return validate_external(cmd, filename, "PHPLINT", args) |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 179 | |
| 180 | |
Milosz Wasilewski | 65d6f0e | 2016-11-08 13:54:59 +0000 | [diff] [blame] | 181 | def validate_external(cmd, filename, prefix, args): |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 182 | final_cmd = "%s %s 2>&1" % (cmd, filename) |
| 183 | status, output = subprocess.getstatusoutput(final_cmd) |
| 184 | if status == 0: |
| 185 | message = '* %s: [PASSED]: %s' % (prefix, filename) |
| 186 | print_stderr(message) |
| 187 | else: |
| 188 | result_message_list = [] |
| 189 | result_message_list.append('* %s: [FAILED]: %s' % (prefix, filename)) |
| 190 | result_message_list.append('* %s: [OUTPUT]:' % prefix) |
| 191 | for line in output.splitlines(): |
| 192 | result_message_list.append(' ' + line) |
Milosz Wasilewski | 65d6f0e | 2016-11-08 13:54:59 +0000 | [diff] [blame] | 193 | publish_result(result_message_list, args) |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 194 | return 1 |
| 195 | return 0 |
| 196 | |
| 197 | |
| 198 | def validate_file(args, path): |
Chase Qi | 827203c | 2019-03-07 16:19:15 +0800 | [diff] [blame] | 199 | filetype = magic.from_file(path, mime=True) |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 200 | exitcode = 0 |
Chase Qi | 827203c | 2019-03-07 16:19:15 +0800 | [diff] [blame] | 201 | # libmagic takes yaml as 'text/plain', so use file extension here. |
| 202 | if path.endswith((".yaml", "yml")): |
Milosz Wasilewski | d0b7813 | 2016-11-22 19:21:14 +0000 | [diff] [blame] | 203 | exitcode = validate_yaml(path, args) |
| 204 | if exitcode == 0: |
| 205 | # if yaml isn't valid there is no point in checking metadata |
Dan Rue | 8ec540c | 2018-01-25 14:38:12 -0600 | [diff] [blame] | 206 | exitcode = validate_yaml_contents(path, args) |
Chase Qi | 827203c | 2019-03-07 16:19:15 +0800 | [diff] [blame] | 207 | elif run_pycodestyle and filetype == "text/x-python": |
Chase Qi | 3029053 | 2018-11-20 18:54:43 +0800 | [diff] [blame] | 208 | exitcode = pycodestyle_check(path, args) |
Chase Qi | 827203c | 2019-03-07 16:19:15 +0800 | [diff] [blame] | 209 | elif filetype == "text/x-php": |
Milosz Wasilewski | 65d6f0e | 2016-11-08 13:54:59 +0000 | [diff] [blame] | 210 | exitcode = validate_php(path, args) |
Chase Qi | 827203c | 2019-03-07 16:19:15 +0800 | [diff] [blame] | 211 | elif filetype == "text/x-shellscript": |
Milosz Wasilewski | 65d6f0e | 2016-11-08 13:54:59 +0000 | [diff] [blame] | 212 | exitcode = validate_shell(path, args) |
Chase Qi | 827203c | 2019-03-07 16:19:15 +0800 | [diff] [blame] | 213 | else: |
| 214 | publish_result(["* UNKNOWN [SKIPPED]: " + path + " - Unknown file type detected: " + filetype], args) |
| 215 | return 0 |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 216 | return exitcode |
| 217 | |
| 218 | |
| 219 | def run_unit_tests(args, filelist=None): |
| 220 | exitcode = 0 |
| 221 | if filelist is not None: |
| 222 | for filename in filelist: |
Milosz Wasilewski | db49939 | 2016-11-07 19:43:51 +0000 | [diff] [blame] | 223 | tmp_exitcode = validate_file(args, filename) |
| 224 | if tmp_exitcode != 0: |
| 225 | exitcode = 1 |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 226 | else: |
| 227 | for root, dirs, files in os.walk('.'): |
| 228 | if not root.startswith("./.git"): |
| 229 | for name in files: |
Milosz Wasilewski | db49939 | 2016-11-07 19:43:51 +0000 | [diff] [blame] | 230 | tmp_exitcode = validate_file( |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 231 | args, |
| 232 | root + "/" + name) |
Milosz Wasilewski | db49939 | 2016-11-07 19:43:51 +0000 | [diff] [blame] | 233 | if tmp_exitcode != 0: |
| 234 | exitcode = 1 |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 235 | return exitcode |
| 236 | |
| 237 | |
| 238 | def main(args): |
| 239 | exitcode = 0 |
| 240 | if args.git_latest: |
| 241 | # check if git exists |
| 242 | git_status, git_result = subprocess.getstatusoutput( |
Chase Qi | 6b5b465 | 2019-01-11 14:18:28 +0800 | [diff] [blame] | 243 | "git diff --name-only HEAD~1") |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 244 | if git_status == 0: |
| 245 | filelist = git_result.split() |
| 246 | exitcode = run_unit_tests(args, filelist) |
| 247 | elif len(args.file_path) > 0: |
| 248 | exitcode = run_unit_tests(args, [args.file_path]) |
| 249 | else: |
| 250 | exitcode = run_unit_tests(args) |
| 251 | exit(exitcode) |
| 252 | |
| 253 | |
| 254 | if __name__ == '__main__': |
| 255 | parser = argparse.ArgumentParser() |
| 256 | parser.add_argument("-p", |
Chase Qi | 3029053 | 2018-11-20 18:54:43 +0800 | [diff] [blame] | 257 | "--pycodestyle-ignore", |
Milosz Wasilewski | 7ae041c | 2016-11-07 11:10:06 +0000 | [diff] [blame] | 258 | nargs="*", |
Milosz Wasilewski | ab7645a | 2016-11-07 10:45:34 +0000 | [diff] [blame] | 259 | default=["E501"], |
Chase Qi | 3029053 | 2018-11-20 18:54:43 +0800 | [diff] [blame] | 260 | help="Space separated list of pycodestyle exclusions", |
| 261 | dest="pycodestyle_ignore") |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 262 | parser.add_argument("-s", |
Milosz Wasilewski | 7ae041c | 2016-11-07 11:10:06 +0000 | [diff] [blame] | 263 | "--shellcheck-ignore", |
| 264 | nargs="*", |
| 265 | help="Space separated list of shellcheck exclusions", |
| 266 | dest="shellcheck_ignore") |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 267 | parser.add_argument("-g", |
Milosz Wasilewski | 7ae041c | 2016-11-07 11:10:06 +0000 | [diff] [blame] | 268 | "--git-latest", |
| 269 | action="store_true", |
| 270 | default=False, |
| 271 | help="If set, the script will try to evaluate files in last git \ |
| 272 | commit instead of the whole repository", |
| 273 | dest="git_latest") |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 274 | parser.add_argument("-f", |
Milosz Wasilewski | 7ae041c | 2016-11-07 11:10:06 +0000 | [diff] [blame] | 275 | "--file-path", |
| 276 | default="", |
| 277 | help="Path to the file that should be checked", |
| 278 | dest="file_path") |
Milosz Wasilewski | 65d6f0e | 2016-11-08 13:54:59 +0000 | [diff] [blame] | 279 | parser.add_argument("-r", |
| 280 | "--result-file", |
| 281 | default="build-error.txt", |
| 282 | help="Path to the file that contains results in case of failure", |
| 283 | dest="result_file") |
Milosz Wasilewski | dbf52aa | 2016-11-01 17:51:26 +0000 | [diff] [blame] | 284 | |
| 285 | args = parser.parse_args() |
| 286 | main(args) |