commit 7a3e1f07c4c6cd2daabed712f47718ce5f8a17a2
author Peter Maydell <peter.maydell@linaro.org> Sun Dec 01 15:23:00 2013 +0000
committer Peter Maydell <peter.maydell@linaro.org> Sun Dec 01 15:23:00 2013 +0000
tree 965d67dcff903fe537cc820aa988ac46888fbd65
parent 8ae1aa47f0ec7475d69de3d63e8eb9e85e1e4862

BUGFIX arithmetic in disas_pc_rel_adr

Fix a bug where we weren't signextending the
immediate properly. Isn't C great?

target-arm/translate-a64.c

diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
index 161f18b..15c2fde 100644
--- a/target-arm/translate-a64.c
+++ b/target-arm/translate-a64.c
@@ -1827,7 +1827,7 @@
     int64_t offset; /* SignExtend(immhi:immlo) -> offset */
 
     page = insn & (1 << 31) ? 1 : 0;
-    offset = sextract32(insn, 5, 19) << 2 | extract32(insn, 29, 2);
+    offset = ((int64_t)sextract32(insn, 5, 19) << 2) | extract32(insn, 29, 2);
     rd = extract32(insn, 0, 5);
     base = s->pc - 4;