commit ba806ffbdf11a63993e4b5d64cca085d385dc1bc
author Marc-André Lureau <marcandre.lureau@redhat.com> Fri Jan 10 19:30:18 2020 +0400
committer Paolo Bonzini <pbonzini@redhat.com> Fri Jan 24 20:59:12 2020 +0100
tree 555be21f84710cc74cb8e4421f5f0b6a00227abf
parent 915901599554b57e386ee4110efcd3c79b87a2cb

object: avoid extra class property key duplication

Like object properties, no need to duplicate property name, as it is
owned already by ObjectProperty value.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200110153039.1379601-6-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

qom/object.c

diff --git a/qom/object.c b/qom/object.c
index dcb6863..e921363 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -311,7 +311,7 @@
         memcpy(ti->class, parent->class, parent->class_size);
         ti->class->interfaces = NULL;
         ti->class->properties = g_hash_table_new_full(
-            g_str_hash, g_str_equal, g_free, object_property_free);
+            g_str_hash, g_str_equal, NULL, object_property_free);
 
         for (e = parent->class->interfaces; e; e = e->next) {
             InterfaceClass *iface = e->data;
@@ -343,7 +343,7 @@
         }
     } else {
         ti->class->properties = g_hash_table_new_full(
-            g_str_hash, g_str_equal, g_free, object_property_free);
+            g_str_hash, g_str_equal, NULL, object_property_free);
     }
 
     ti->class->type = ti;
@@ -1187,7 +1187,7 @@
     prop->release = release;
     prop->opaque = opaque;
 
-    g_hash_table_insert(klass->properties, g_strdup(name), prop);
+    g_hash_table_insert(klass->properties, prop->name, prop);
 
     return prop;
 }