commit ac84b0fa2857383ca25e86970fb12a067e56f66c
author Markus Armbruster <armbru@redhat.com> Fri Nov 13 09:26:23 2020 +0100
committer Markus Armbruster <armbru@redhat.com> Thu Dec 10 17:16:44 2020 +0100
tree b83d0cc3f8beb9d61fbae5890a2c2abce57b6852
parent 99750d82e43e3825ded46b41828552d357f346bc

qga: Replace an unreachable error by abort()

check_suspend_mode()'s error message

    Parameter 'mode' expects GuestSuspendMode

makes no sense to users: GuestSuspendMode is a C enum.  Fortunately,
it is unreachable.  Replace it by abort().

Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20201113082626.2725812-8-armbru@redhat.com>

qga/commands-win32.c

diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 300b87c..87dc43e 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -1441,8 +1441,7 @@
         }
         break;
     default:
-        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "mode",
-                   "GuestSuspendMode");
+        abort();
     }
 }