commit 75158ebbe259f0bd8bf435e8f4827a43ec89c877
author Markus Armbruster <armbru@redhat.com> Mon Mar 16 08:57:47 2015 +0100
committer Markus Armbruster <armbru@redhat.com> Mon Jun 22 18:20:39 2015 +0200
tree eba61e08212343a1a688dae6f51897b0702ee8db
parent c6bf0f7ffa90c720377eb6bddd27037041acbc5b

qerror: Eliminate QERR_DEVICE_NOT_FOUND

Error classes other than ERROR_CLASS_GENERIC_ERROR should not be used
in new code.  Hiding them in QERR_ macros makes new uses hard to spot.
Fortunately, there's just one such macro left.  Eliminate it with this
coccinelle semantic patch:

    @@
    expression EP, E;
    @@
    -error_set(EP, QERR_DEVICE_NOT_FOUND, E)
    +error_set(EP, ERROR_CLASS_DEVICE_NOT_FOUND, "Device '%s' not found", E)

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>

net/net.c

diff --git a/net/net.c b/net/net.c
index 85c4b20..7b5f519 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1127,7 +1127,8 @@
 
     nc = qemu_find_netdev(id);
     if (!nc) {
-        error_set(errp, QERR_DEVICE_NOT_FOUND, id);
+        error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
+                  "Device '%s' not found", id);
         return;
     }
 
@@ -1238,7 +1239,8 @@
                                           MAX_QUEUE_NUM);
 
     if (queues == 0) {
-        error_set(errp, QERR_DEVICE_NOT_FOUND, name);
+        error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
+                  "Device '%s' not found", name);
         return;
     }
     nc = ncs[0];