commit 5fa96cad01bf408064aeea19812c0692ddfbd2b6
author Philippe Mathieu-Daudé <f4bug@amsat.org> Mon Jun 25 09:41:56 2018 -0300
committer Paolo Bonzini <pbonzini@redhat.com> Mon Jul 02 14:45:23 2018 +0200
tree 509e4e8dd5736a99b916c74ea2f4338c269f4d45
parent 6a4e0614c3e2ca01ac030e9c486c77d4d7225021

checkpatch: Recognize IEC binary prefix definitions

Do not match the IEC binary prefix as camelcase typedefs.

This fixes:

    ERROR: "foo * bar" should be "foo *bar"
    #310: FILE: hw/ppc/ppc440_uc.c:564:
    +        size = 8 * MiB * sh;
    total: 1 errors, 0 warnings, 433 lines checked

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20180625124238.25339-5-f4bug@amsat.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

scripts/checkpatch.pl

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e3d8c2c..223681b 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -242,6 +242,7 @@
 # There are still some false positives, but this catches most
 # common cases.
 our $typeTypedefs = qr{(?x:
+        (?![KMGTPE]iB)                      # IEC binary prefix (do not match)
         [A-Z][A-Z\d_]*[a-z][A-Za-z\d_]*     # camelcase
         | [A-Z][A-Z\d_]*AIOCB               # all uppercase
         | [A-Z][A-Z\d_]*CPU                 # all uppercase