commit 5c878008ddc1fbdb688dee7cdca93e1fd55845dc
author Stefan Weil <sw@weilnetz.de> Sat Apr 28 02:32:42 2012 +0000
committer Stefan Weil <sw@weilnetz.de> Thu May 03 07:04:48 2012 +0200
tree e6165850dd4eacb2d9dd370fbbfe73611153d42b
parent 3881725cf0c34b366285e2c9ddda941185c9f861

qdev: Fix memory leak in function set_pci_devfn

Valgrind reported this memory leak which occured very often.

Test scenario:

qemu-system-i386 (no arguments), only BIOS started, terminate with
monitor command (quit).

v2:
Use error_free instead of g_free (hint from Andreas Färber, thanks).

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Acked-by: Andreas Färber <afaerber@suse.de>

hw/qdev-properties.c

diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 98dd06a..c5545dc 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -834,6 +834,7 @@
 
     visit_type_str(v, &str, name, &local_err);
     if (local_err) {
+        error_free(local_err);
         return set_int32(obj, v, opaque, name, errp);
     }