commit 481537451302fc63eee5cf3663a92629bb78954f
author Markus Armbruster <armbru@redhat.com> Wed Mar 15 13:56:58 2017 +0100
committer Markus Armbruster <armbru@redhat.com> Thu Mar 16 07:13:02 2017 +0100
tree 29cfcab01ca3552013ba6d32efd21070bb0765ed
parent 707fb2d381de7a03e5bf9d2bd305dc7883fd992e

qapi: Fix to reject empty union base gracefully

Common Python pitfall: 'assert base_members' fires on [] in addition
to None.  Correct to 'assert base_members is not None'.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <1489582656-31133-10-git-send-email-armbru@redhat.com>

scripts/qapi.py

diff --git a/scripts/qapi.py b/scripts/qapi.py
index 78db319..f4c8210 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -735,7 +735,7 @@
             raise QAPISemError(info, "Flat union '%s' must have a base"
                                % name)
         base_members = find_base_members(base)
-        assert base_members
+        assert base_members is not None
 
         # The value of member 'discriminator' must name a non-optional
         # member of the base struct.