commit 42eab8dbec2f3fd4a14bd63ab01aa155ce5724a3
author Marc-André Lureau <marcandre.lureau@redhat.com> Thu Jul 05 18:42:01 2018 +0200
committer Markus Armbruster <armbru@redhat.com> Wed Jul 11 21:11:15 2018 +0200
tree ccb23cf9b12a64dba913e9a15a97b7ccff039169
parent c447afd5783b9237fa51b7a85777007d8d568bfc

monitor: fix double-free of request error

qmp_error_response() will free the given error. Fix double-free in
later qmp_request_free().

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20180705164201.9853-1-marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Fixes: 1cc37471525d03f963bc71d724f0dc9eab888fc1
Signed-off-by: Markus Armbruster <armbru@redhat.com>

monitor.c

diff --git a/monitor.c b/monitor.c
index 3c9c97b..7af1f18 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4186,6 +4186,7 @@
     } else {
         assert(req_obj->err);
         rsp = qmp_error_response(req_obj->err);
+        req_obj->err = NULL;
         monitor_qmp_respond(req_obj->mon, rsp, NULL);
         qobject_unref(rsp);
     }