commit 283d845c9164f57f5dba020a4783bb290493802f
author Daniel P. Berrangé <berrange@redhat.com> Fri Feb 19 17:56:13 2021 +0000
committer Daniel P. Berrangé <berrange@redhat.com> Thu Mar 18 09:22:55 2021 +0000
tree 1084e0cac2bfd04266ebf4d3a413cb32f20a3a8c
parent 5994dcb8d8525ac044a31913c6bceeee788ec700

monitor: raise error when 'pretty' option is used with HMP

This is only semantically useful for QMP.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

monitor/monitor.c

diff --git a/monitor/monitor.c b/monitor/monitor.c
index 640496e..636bcc8 100644
--- a/monitor/monitor.c
+++ b/monitor/monitor.c
@@ -716,8 +716,8 @@
             return -1;
         }
         if (opts->pretty) {
-            warn_report("'pretty' is deprecated for HMP monitors, it has no "
-                        "effect and will be removed in future versions");
+            error_setg(errp, "'pretty' is not compatible with HMP monitors");
+            return -1;
         }
         monitor_init_hmp(chr, true, &local_err);
         break;