commit a14ce77b28146526661c79c89b2e6ff6837c2bb0
author Bas van Sisseren <bas@vansisseren.nl> Sat Aug 12 14:40:49 2017 +0200
committer Damien George <damien.p.george@gmail.com> Tue Aug 15 11:33:43 2017 +1000
tree a2ddf36cb50e584a59bcae8a36b9ab3bc7c0b535
parent c127ace28a4faeb93ef86743c703a14258137efc

py/binary.c: Fix bug when packing big-endian 'Q' values.

Without bugfix:

    struct.pack('>Q', 16)
    b'\x00\x00\x00\x10\x00\x00\x00\x00'

With bugfix:

    struct.pack('>Q', 16)
    b'\x00\x00\x00\x00\x00\x00\x00\x10'

py/binary.c

diff --git a/py/binary.c b/py/binary.c
index e38aae8..870a094 100644
--- a/py/binary.c
+++ b/py/binary.c
@@ -303,7 +303,10 @@
                 // zero/sign extend if needed
                 if (BYTES_PER_WORD < 8 && size > sizeof(val)) {
                     int c = (is_signed(val_type) && (mp_int_t)val < 0) ? 0xff : 0x00;
-                    memset(p + sizeof(val), c, size - sizeof(val));
+                    memset(p, c, size);
+                    if (struct_type == '>') {
+                        p += size - sizeof(val);
+                    }
                 }
             }
     }