commit 090c9236e8b1c213dd147fc46dabd8106cd421ad
author Damien George <damien.p.george@gmail.com> Fri Oct 17 14:08:49 2014 +0000
committer Damien George <damien.p.george@gmail.com> Fri Oct 17 14:08:49 2014 +0000
tree 955679208ec1ee0cb5bdc7c0cdd0b14ded4e5d1e
parent 37ada236b32e04338d24cb0e8a952af6b6bde55d

py: Fix compiling of nested while/for and exception handler.

Addresses issue #912.

py/compile.c

diff --git a/py/compile.c b/py/compile.c
index 644e55b..81a9dc9 100644
--- a/py/compile.c
+++ b/py/compile.c
@@ -83,7 +83,7 @@
     uint16_t break_label; // highest bit set indicates we are breaking out of a for loop
     uint16_t continue_label;
     uint16_t cur_except_level; // increased for SETUP_EXCEPT, SETUP_FINALLY; decreased for POP_BLOCK, POP_EXCEPT
-    int break_continue_except_level;
+    uint16_t break_continue_except_level;
 
     scope_t *scope_head;
     scope_t *scope_cur;
@@ -1367,6 +1367,7 @@
     if (comp->break_label == 0) {
         compile_syntax_error(comp, (mp_parse_node_t)pns, "'break' outside loop");
     }
+    assert(comp->cur_except_level >= comp->break_continue_except_level);
     EMIT_ARG(break_loop, comp->break_label, comp->cur_except_level - comp->break_continue_except_level);
 }
 
@@ -1374,6 +1375,7 @@
     if (comp->continue_label == 0) {
         compile_syntax_error(comp, (mp_parse_node_t)pns, "'continue' outside loop");
     }
+    assert(comp->cur_except_level >= comp->break_continue_except_level);
     EMIT_ARG(continue_loop, comp->continue_label, comp->cur_except_level - comp->break_continue_except_level);
 }
 
@@ -1717,8 +1719,9 @@
 }
 
 #define START_BREAK_CONTINUE_BLOCK \
-    uint old_break_label = comp->break_label; \
-    uint old_continue_label = comp->continue_label; \
+    uint16_t old_break_label = comp->break_label; \
+    uint16_t old_continue_label = comp->continue_label; \
+    uint16_t old_break_continue_except_level = comp->break_continue_except_level; \
     uint break_label = comp_next_label(comp); \
     uint continue_label = comp_next_label(comp); \
     comp->break_label = break_label; \
@@ -1728,7 +1731,7 @@
 #define END_BREAK_CONTINUE_BLOCK \
     comp->break_label = old_break_label; \
     comp->continue_label = old_continue_label; \
-    comp->break_continue_except_level = comp->cur_except_level;
+    comp->break_continue_except_level = old_break_continue_except_level;
 
 void compile_while_stmt(compiler_t *comp, mp_parse_node_struct_t *pns) {
     START_BREAK_CONTINUE_BLOCK