Fix up huge numbers of pylint warnings
Change-Id: I9112ab123943a81e60d2c6bf096bc125e8e042b7
diff --git a/config/test.py b/config/test.py
index 62f6b4f..3d66aaf 100644
--- a/config/test.py
+++ b/config/test.py
@@ -6,7 +6,7 @@
os.chdir(vlandpath)
from config.config import VlanConfig
-from errors import CriticalError, InputError, ConfigError
+from errors import ConfigError
class MyTest(unittest.TestCase):
@@ -14,36 +14,43 @@
def test_missing_database_section(self):
with self.assertRaisesRegexp(ConfigError, 'No database'):
config = VlanConfig(filenames=("/dev/null",))
+ del config
# Check that we raise on broken database config values
def test_missing_database_config(self):
with self.assertRaisesRegexp(ConfigError, 'Invalid database'):
config = VlanConfig(filenames=("test-invalid-DB.cfg",))
+ del config
# Check that we raise on missing database config values
def test_missing_dbname(self):
with self.assertRaisesRegexp(ConfigError, 'Database.*incomplete'):
config = VlanConfig(filenames=("test-missing-dbname.cfg",))
+ del config
# Check that we raise on missing database config values
def test_missing_db_username(self):
with self.assertRaisesRegexp(ConfigError, 'Database.*incomplete'):
config = VlanConfig(filenames=("test-missing-db-username.cfg",))
+ del config
# Check that we raise on broken vland config values
def test_missing_vlan_config(self):
with self.assertRaisesRegexp(ConfigError, 'Invalid vland'):
config = VlanConfig(filenames=("test-invalid-vland.cfg",))
+ del config
# Check that we raise on repeated switch names
def test_missing_repeated_switch_names(self):
with self.assertRaisesRegexp(ConfigError, 'same name'):
config = VlanConfig(filenames=("test-reused-switch-names.cfg",))
+ del config
# Check that we raise on unknown config section
def test_unknown_config(self):
with self.assertRaisesRegexp(ConfigError, 'Unrecognised config'):
config = VlanConfig(filenames=("test-unknown-section.cfg",))
+ del config
# Check we get expected values on a known-good config
def test_known_good(self):