Revert "cpuset: Fix allow_attach hook for cpusets on android."
This reverts commit ef03f44369b42906cac45108585acd404b4d9d56.
Part of Chromium commit series:
CHROMIUM: remove Android's cgroup generic permissions checks
The implementation is utterly broken, resulting in all processes being
allows to move tasks between sets (as long as they have access to the
"tasks" attribute), and upstream is heading towards checking only
capability anyway, so let's get rid of this code.
BUG=b:31790445,chromium:647994
TEST=Boot android container, examine logcat
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/394967
Reviewed-by: Ricky Zhou <rickyz@chromium.org>
Reviewed-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 815b03f..5222f5c 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -2075,13 +2075,13 @@
task->mems_allowed = current->mems_allowed;
}
-static int cpuset_allow_attach(struct cgroup_subsys_state *css,
- struct cgroup_taskset *tset)
+static int cpuset_allow_attach(struct cgroup_taskset *tset)
{
const struct cred *cred = current_cred(), *tcred;
struct task_struct *task;
+ struct cgroup_subsys_state *css;
- cgroup_taskset_for_each(task, tset) {
+ cgroup_taskset_for_each(task, css, tset) {
tcred = __task_cred(task);
if ((current != task) && !capable(CAP_SYS_ADMIN) &&