commit 69382320d96232ee8c73e664797da61e733c2427
author Lukas Fleischer <cgit@cryptocrack.de> Tue May 24 20:38:40 2011 +0200
committer Lars Hjemli <hjemli@gmail.com> Mon May 30 23:55:19 2011 +0200
tree 7f1d53505859cc6e15b261249a22d1604b3cd037
parent ec79265f2053e6dc20e0ec486719f5954d2be83d

Properly escape ampersands inside HTML attributes

Ampersands ("&") appearing inside HTML attributes need to be translated
to "&". Otherwise, invalid XHTML will be generated at various
places, such as at tree views containing links to submodules.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>

html.c

diff --git a/html.c b/html.c
index a0f6db4..24a03a5 100644
--- a/html.c
+++ b/html.c
@@ -138,7 +138,7 @@
 	const char *t = txt;
 	while(t && *t){
 		int c = *t;
-		if (c=='<' || c=='>' || c=='\'' || c=='\"') {
+		if (c=='<' || c=='>' || c=='\'' || c=='\"' || c=='&') {
 			html_raw(txt, t - txt);
 			if (c=='>')
 				html("&gt;");
@@ -148,6 +148,8 @@
 				html("&#x27;");
 			else if (c=='"')
 				html("&quot;");
+			else if (c=='&')
+				html("&amp;");
 			txt = t+1;
 		}
 		t++;