pxe: simplify menu display and selection
Menus with lots of entries and long append lines are hard to read.
Just show a numbered list using the label or name and make the choice
by entering the number.
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
diff --git a/common/cmd_pxe.c b/common/cmd_pxe.c
index 83bf673..5d672af 100644
--- a/common/cmd_pxe.c
+++ b/common/cmd_pxe.c
@@ -448,6 +448,7 @@
* list - lets these form a list, which a pxe_menu struct will hold.
*/
struct pxe_label {
+ char num[4];
char *name;
char *menu;
char *kernel;
@@ -537,21 +538,9 @@
static void label_print(void *data)
{
struct pxe_label *label = data;
- const char *c = label->menu ? label->menu : label->kernel;
+ const char *c = label->menu ? label->menu : label->name;
- printf("%s:\t%s\n", label->name, c);
-
- if (label->kernel)
- printf("\t\tkernel: %s\n", label->kernel);
-
- if (label->append)
- printf("\t\tappend: %s\n", label->append);
-
- if (label->initrd)
- printf("\t\tinitrd: %s\n", label->initrd);
-
- if (label->fdt)
- printf("\tfdt: %s\n", label->fdt);
+ printf("%s:\t%s\n", label->num, c);
}
/*
@@ -638,8 +627,10 @@
return 1;
}
- if (label->append)
+ if (label->append) {
setenv("bootargs", label->append);
+ printf("append: %s\n", label->append);
+ }
bootm_argv[1] = getenv("kernel_addr_r");
@@ -1288,6 +1279,7 @@
struct list_head *pos;
struct menu *m;
int err;
+ int i = 1;
/*
* Create a menu and add items for all the labels.
@@ -1300,7 +1292,8 @@
list_for_each(pos, &cfg->labels) {
label = list_entry(pos, struct pxe_label, list);
- if (menu_item_add(m, label->name, label) != 1) {
+ sprintf(label->num, "%d", i++);
+ if (menu_item_add(m, label->num, label) != 1) {
menu_destroy(m);
return NULL;
}