From 3d937150dce20cb95cbaae99b6fd48dca4261f32 Mon Sep 17 00:00:00 2001 From: John Snow Date: Mon, 5 Oct 2015 12:00:55 -0400 Subject: qtest/ahci: fix redundant assertion Fixes https://bugs.launchpad.net/qemu/+bug/1497711 (!ncq || (ncq && lba48)) is the same as (!ncq || lba48). The intention is simply: "If a command is NCQ, it must also be LBA48." Signed-off-by: John Snow Message-id: 1442868929-17777-1-git-send-email-jsnow@redhat.com --- tests/libqos/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c index cf66b3e32c..adb2665c6d 100644 --- a/tests/libqos/ahci.c +++ b/tests/libqos/ahci.c @@ -742,7 +742,7 @@ AHCICommand *ahci_command_create(uint8_t command_name) g_assert(!(props->lba28 && props->lba48)); g_assert(!(props->read && props->write)); g_assert(!props->size || props->data); - g_assert(!props->ncq || (props->ncq && props->lba48)); + g_assert(!props->ncq || props->lba48); /* Defaults and book-keeping */ cmd->props = props; -- cgit v1.2.3