From 75cb298d905030fca897ea1d80e409c7f7e3e5ea Mon Sep 17 00:00:00 2001 From: Peter Maydell Date: Fri, 14 Jul 2017 12:12:25 +0100 Subject: slirp: Handle error returns from sosendoob() sosendoob() can return a failure code, but all its callers ignore it. This is OK in sbappend(), as the comment there states -- we will try again later in sowrite(). Add a (void) cast to tell Coverity so. In sowrite() we do need to check the return value -- we should handle a write failure in sosendoob() the same way we handle a write failure for the normal data. Signed-off-by: Peter Maydell Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Samuel Thibault --- slirp/sbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'slirp/sbuf.c') diff --git a/slirp/sbuf.c b/slirp/sbuf.c index 10119d3ad5..912f235f65 100644 --- a/slirp/sbuf.c +++ b/slirp/sbuf.c @@ -91,7 +91,7 @@ sbappend(struct socket *so, struct mbuf *m) if (so->so_urgc) { sbappendsb(&so->so_rcv, m); m_free(m); - sosendoob(so); + (void)sosendoob(so); return; } -- cgit v1.2.3