From ed26b92290768818371fbfd4317988eab6009ad5 Mon Sep 17 00:00:00 2001 From: Eduardo Habkost Date: Thu, 12 Feb 2015 15:23:48 -0200 Subject: numa: Fix off-by-one error at MAX_CPUMASK_BITS check Fix the CPU index check to ensure we don't go beyond the size of the node_cpu bitmap. CPU index is always less than MAX_CPUMASK_BITS, as documented at sysemu.h: > The following shall be true for all CPUs: > cpu->cpu_index < max_cpus <= MAX_CPUMASK_BITS Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- numa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'numa.c') diff --git a/numa.c b/numa.c index ffbec68fd8..13b2f01dba 100644 --- a/numa.c +++ b/numa.c @@ -76,9 +76,9 @@ static void numa_node_parse(NumaNodeOptions *node, QemuOpts *opts, Error **errp) } for (cpus = node->cpus; cpus; cpus = cpus->next) { - if (cpus->value > MAX_CPUMASK_BITS) { + if (cpus->value >= MAX_CPUMASK_BITS) { error_setg(errp, "CPU number %" PRIu16 " is bigger than %d", - cpus->value, MAX_CPUMASK_BITS); + cpus->value, MAX_CPUMASK_BITS - 1); return; } bitmap_set(numa_info[nodenr].node_cpu, cpus->value, 1); -- cgit v1.2.3