From 6106e2492fe0080ad85d4862dec9c3bebc57b2f0 Mon Sep 17 00:00:00 2001 From: Luiz Capitulino Date: Fri, 25 Nov 2011 16:15:19 -0200 Subject: qapi: Convert blockdev_snapshot_sync Unfortunately, this conversion required an additional change. In the old QMP command, the 'snapshot-file' argument is specified as optional. The idea is to take the snapshot internally if 'snapshot-file' is not passed. However, internal snapshots are not supported yet so the command returns a MissingParamater error if 'snapshot-file' is not passed. Which makes the argument actually required and will cause compatibility breakage if we change that in the future. To fix this the QAPI converted blockdev_snapshot_sync command makes the 'snapshot-file' argument required. Again, in practice it's actually required, so this is not incompatible. If we do implement internal snapshots someday, we'll need a new argument for it. Note that this discussion doesn't affect HMP. Signed-off-by: Luiz Capitulino --- hmp.h | 1 + 1 file changed, 1 insertion(+) (limited to 'hmp.h') diff --git a/hmp.h b/hmp.h index c236fd2baf..e4227d3b4d 100644 --- a/hmp.h +++ b/hmp.h @@ -45,5 +45,6 @@ void hmp_set_link(Monitor *mon, const QDict *qdict); void hmp_block_passwd(Monitor *mon, const QDict *qdict); void hmp_balloon(Monitor *mon, const QDict *qdict); void hmp_block_resize(Monitor *mon, const QDict *qdict); +void hmp_snapshot_blkdev(Monitor *mon, const QDict *qdict); #endif -- cgit v1.2.3