From eab2ac9d3c1675a58989000c2647aa33e440906a Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Mon, 14 Sep 2015 13:12:34 +0200 Subject: block/ssh: remove dead code The "err" label cannot be reached with qp != NULL. Remove the free-ing of qp and avoid future regressions by removing the initializer. Signed-off-by: Paolo Bonzini ACKed-by: Richard W.M. Jones Reviewed-by: Fam Zheng Signed-off-by: Michael Tokarev --- block/ssh.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index 8d0673903d..d35b51f987 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -193,7 +193,7 @@ sftp_error_report(BDRVSSHState *s, const char *fs, ...) static int parse_uri(const char *filename, QDict *options, Error **errp) { URI *uri = NULL; - QueryParams *qp = NULL; + QueryParams *qp; int i; uri = uri_parse(filename); @@ -249,9 +249,6 @@ static int parse_uri(const char *filename, QDict *options, Error **errp) return 0; err: - if (qp) { - query_params_free(qp); - } if (uri) { uri_free(uri); } -- cgit v1.2.3