path: root/trace
diff options
authorStefan Hajnoczi <stefanha@redhat.com>2013-10-08 11:58:31 +0200
committerStefan Hajnoczi <stefanha@redhat.com>2014-03-25 13:39:31 +0100
commitae2990c259abec198879c362dc13f7047f26c2cf (patch)
treedbf4815eff7df7791a089fffef00d9dc4b71117d /trace
parent839a5547574e57cce62f49bfc50fe1f04b00589a (diff)
osdep: initialize glib threads in all QEMU tools
glib versions prior to 2.31.0 require an explicit g_thread_init() call to enable multi-threading. Failure to initialize threading causes glib to take single-threaded code paths without synchronization. For example, the g_slice allocator will crash due to race conditions. Fix this for all QEMU tool programs (qemu-nbd, qemu-io, qemu-img) by moving the g_thread_init() call from vl.c:main() into a new osdep.c:thread_init() constructor function. thread_init() has __attribute__((constructor)) and is automatically invoked by the runtime during startup. We can now drop the "simple" trace backend's g_thread_init() call since thread_init() already called it. Note that we must keep coroutine-gthread.c's g_thread_init() call which is located in a constructor function. There is no guarantee for constructor function ordering so thread_init() may only be called later. Reported-by: Mario de Chenno <mario.dechenno@unina2.it> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'trace')
1 files changed, 0 insertions, 9 deletions
diff --git a/trace/simple.c b/trace/simple.c
index 57572c4905..aaa010ee2b 100644
--- a/trace/simple.c
+++ b/trace/simple.c
@@ -414,15 +414,6 @@ bool trace_backend_init(const char *events, const char *file)
GThread *thread;
- if (!g_thread_supported()) {
-#if !GLIB_CHECK_VERSION(2, 31, 0)
- g_thread_init(NULL);
- fprintf(stderr, "glib threading failed to initialize.\n");
- exit(1);
- }
#if !GLIB_CHECK_VERSION(2, 31, 0)
trace_available_cond = g_cond_new();
trace_empty_cond = g_cond_new();