aboutsummaryrefslogtreecommitdiff
path: root/tests/io-channel-helpers.c
diff options
context:
space:
mode:
authorDaniel P. Berrange <berrange@redhat.com>2016-03-08 15:37:29 +0000
committerDaniel P. Berrange <berrange@redhat.com>2016-03-10 17:10:18 +0000
commit294bbbb4252ab5ff42d0e2c09f209c0bd7eb9748 (patch)
tree639534d3a53a8c392cbb1026effd152b8972c0b2 /tests/io-channel-helpers.c
parent256920eb94f4de9430122b7618b9c2a16cb2df32 (diff)
io: assert errors before asserting content in I/O test
When checking the results of an I/O operation test, assert that the error objects are NULL before asserting on the content. This is found to give more useful indication of the problem when diagnosing test failures. Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Diffstat (limited to 'tests/io-channel-helpers.c')
-rw-r--r--tests/io-channel-helpers.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/io-channel-helpers.c b/tests/io-channel-helpers.c
index d513792068..a4dedbe0ad 100644
--- a/tests/io-channel-helpers.c
+++ b/tests/io-channel-helpers.c
@@ -233,11 +233,11 @@ void qio_channel_test_run_reader(QIOChannelTest *test,
void qio_channel_test_validate(QIOChannelTest *test)
{
+ g_assert(test->readerr == NULL);
+ g_assert(test->writeerr == NULL);
g_assert_cmpint(memcmp(test->input,
test->output,
test->len), ==, 0);
- g_assert(test->readerr == NULL);
- g_assert(test->writeerr == NULL);
g_free(test->inputv);
g_free(test->outputv);