diff options
| author | Lluís Vilanova <vilanova@ac.upc.edu> | 2016-08-23 10:58:58 +0200 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2016-09-05 13:47:02 -0400 |
| commit | 8eb1b9db559e243043aaeac3a0aa97e1f4a403c4 (patch) | |
| tree | 2c1c91cd7439424b54369082720ac4b54eb95723 /stubs | |
| parent | a4d50b1d2a6c07a13fb8401a0c3b471f25b44b2a (diff) | |
trace: Avoid implicit bool->integer conversions
An explicit if/else is clearer than arithmetic assuming #true is 1,
while the compiler should be able to generate just as optimal code.
Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
Message-id: 147194273830.26836.5875729707953474838.stgit@fimbulvetr.bsc.es
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'stubs')
| -rw-r--r-- | stubs/trace-control.c | 17 |
1 files changed, 15 insertions, 2 deletions
diff --git a/stubs/trace-control.c b/stubs/trace-control.c index 3740c38589..2dfcd9fb2b 100644 --- a/stubs/trace-control.c +++ b/stubs/trace-control.c @@ -19,10 +19,23 @@ void trace_event_set_state_dynamic_init(TraceEvent *ev, bool state) void trace_event_set_state_dynamic(TraceEvent *ev, bool state) { TraceEventID id; + bool state_pre; assert(trace_event_get_state_static(ev)); id = trace_event_get_id(ev); - trace_events_enabled_count += state - trace_events_dstate[id]; - trace_events_dstate[id] = state; + /* + * We ignore the "vcpu" property here, since there's no target code. Then + * dstate can only be 1 or 0. + */ + state_pre = trace_events_dstate[id]; + if (state_pre != state) { + if (state) { + trace_events_enabled_count++; + trace_events_dstate[id] = 1; + } else { + trace_events_enabled_count--; + trace_events_dstate[id] = 0; + } + } } void trace_event_set_vcpu_state_dynamic(CPUState *vcpu, |